All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@pmcs.com>
To: JBottomley@Parallels.com, linux-scsi@vger.kernel.org
Cc: Mahesh.Rajashekhara@pmcs.com, Murthy.Bhat@pmcs.com,
	Santosh.Akula@pmcs.com, Gana.Sridaran@pmcs.com,
	aacraid@pmc-sierra.com, Scott.Benesh@pmcs.com,
	RaghavaAditya.Renukunta@pmcs.com
Subject: [PATCH v2 7/9] aacraid: Fix AIF triggered IOP_RESET
Date: Thu, 10 Dec 2015 10:45:57 -0800	[thread overview]
Message-ID: <1449773159-25058-8-git-send-email-RaghavaAditya.Renukunta@pmcs.com> (raw)
In-Reply-To: <1449773159-25058-1-git-send-email-RaghavaAditya.Renukunta@pmcs.com>

From: Raghava Aditya Renukunta <raghavaaditya.renukunta@pmcs.com>

while driver removal is in progress or PCI shutdown is invoked, driver
kills AIF aacraid thread, but IOCTL requests from the management tools
re-start AIF thread leading to IOP_RESET.

Fixed by setting adapter_shutdown flag when PCI shutdown is invoked.

Changes in V2:
Set adapter_shutdown flag before shutdown command is sent to \
controller

Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renukunta@pmcs.com>
---
 drivers/scsi/aacraid/comminit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
index 0e954e3..fe08854 100644
--- a/drivers/scsi/aacraid/comminit.c
+++ b/drivers/scsi/aacraid/comminit.c
@@ -212,8 +212,9 @@ int aac_send_shutdown(struct aac_dev * dev)
 		return -ENOMEM;
 	aac_fib_init(fibctx);
 
-	cmd = (struct aac_close *) fib_data(fibctx);
+	dev->adapter_shutdown = 1;
 
+	cmd = (struct aac_close *) fib_data(fibctx);
 	cmd->command = cpu_to_le32(VM_CloseAll);
 	cmd->cid = cpu_to_le32(0xfffffffe);
 
@@ -229,7 +230,6 @@ int aac_send_shutdown(struct aac_dev * dev)
 	/* FIB should be freed only after getting the response from the F/W */
 	if (status != -ERESTARTSYS)
 		aac_fib_free(fibctx);
-	dev->adapter_shutdown = 1;
 	if ((dev->pdev->device == PMC_DEVICE_S7 ||
 	     dev->pdev->device == PMC_DEVICE_S8 ||
 	     dev->pdev->device == PMC_DEVICE_S9) &&
-- 
1.9.1


  parent reply	other threads:[~2015-12-11  1:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 18:45 [PATCH V2 0/9] aacraid: Patchset for aacraid driver version 41052 Raghava Aditya Renukunta
2015-12-10 18:45 ` [PATCH v2 1/9] aacraid: SCSI blk tag support Raghava Aditya Renukunta
2015-12-10 18:45 ` [PATCH v2 2/9] aacraid: Fix RRQ overload Raghava Aditya Renukunta
2015-12-10 18:45 ` [PATCH v2 3/9] aacraid: Added EEH support Raghava Aditya Renukunta
2015-12-13  0:28   ` kbuild test robot
2015-12-15 19:10     ` Raghava Aditya Renukunta
2015-12-10 18:45 ` [PATCH v2 4/9] aacraid: Fix memory leak in aac_fib_map_free Raghava Aditya Renukunta
2015-12-10 18:45 ` [PATCH v2 5/9] aacraid: Set correct msix count for EEH recovery Raghava Aditya Renukunta
2015-12-10 18:45 ` [PATCH v2 6/9] aacraid: Fundamental reset support for Series 7 Raghava Aditya Renukunta
2015-12-10 18:45 ` Raghava Aditya Renukunta [this message]
2015-12-10 18:45 ` [PATCH v2 8/9] aacraid: Fix character device re-initialization Raghava Aditya Renukunta
2015-12-10 18:45 ` [PATCH v2 9/9] aacraid: Update driver version Raghava Aditya Renukunta
2016-01-05  2:07 ` [PATCH V2 0/9] aacraid: Patchset for aacraid driver version 41052 Martin K. Petersen
2016-01-06 23:01   ` Raghava Aditya Renukunta
  -- strict thread matches above, loose matches on Subject: below --
2016-01-07  7:22 Raghava Aditya Renukunta
2016-01-07  7:22 ` [PATCH V2 7/9] aacraid: Fix AIF triggered IOP_RESET Raghava Aditya Renukunta
2016-01-08  5:57   ` Seymour, Shane M
2016-01-08 23:37     ` Raghava Aditya Renukunta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449773159-25058-8-git-send-email-RaghavaAditya.Renukunta@pmcs.com \
    --to=raghavaaditya.renukunta@pmcs.com \
    --cc=Gana.Sridaran@pmcs.com \
    --cc=JBottomley@Parallels.com \
    --cc=Mahesh.Rajashekhara@pmcs.com \
    --cc=Murthy.Bhat@pmcs.com \
    --cc=Santosh.Akula@pmcs.com \
    --cc=Scott.Benesh@pmcs.com \
    --cc=aacraid@pmc-sierra.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.