From: Joe Perches <joe@perches.com>
To: "Moritz König" <moritz.koenig@fau.de>,
"Ian Abbott" <abbotti@mev.co.uk>,
"H Hartley Sweeten" <hsweeten@visionengravers.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Colin Cronin" <colinpatrickcronin@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Fabian Lang <fabian.lang@fau.de>, linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 2/2] staging: COMEDI: Added missing spaces at binary operators
Date: Thu, 10 Dec 2015 12:22:41 -0800 [thread overview]
Message-ID: <1449778961.12972.12.camel@perches.com> (raw)
In-Reply-To: <49eab985686323b43a0a286e6ae810b0725e9957.1449755183.git.moritz.koenig@fau.de>
On Thu, 2015-12-10 at 15:57 +0100, Moritz König wrote:
> #define CR_AREF(a) (((a) >> 24)&0x03)
If you are going to fix these, it'd probably be better
to use spaces around the '&' too
#define CR_AREF(a) (((a) >> 24) & 0x03)
next prev parent reply other threads:[~2015-12-10 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 14:57 [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h Moritz König
2015-12-10 14:57 ` [PATCH 1/2] staging: COMEDI: Fixed the format of comments Moritz König
2015-12-10 14:57 ` [PATCH 2/2] staging: COMEDI: Added missing spaces at binary operators Moritz König
2015-12-10 20:22 ` Joe Perches [this message]
2015-12-11 10:01 ` [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449778961.12972.12.camel@perches.com \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=colinpatrickcronin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabian.lang@fau.de \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz.koenig@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.