All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Felipe Balbi <balbi@ti.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	"Ivan T. Ivanov" <iivanov@mm-sol.com>,
	Andy Gross <agross@codeaurora.org>,
	Jack Pham <jackp@codeaurora.org>,
	Greg Kroah-Hartman <greg@kroah.com>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	Philip Elcan <pelcan@codeaurora.org>,
	Mark Langsdorf <mlangsdo@redhat.com>,
	Jon Masters <jcm@redhat.com>
Subject: [PATCH 1/5] [v2] usb: host: ehci-msm: Allow LS devices to work
Date: Thu, 10 Dec 2015 18:28:53 -0600	[thread overview]
Message-ID: <1449793737-1816-1-git-send-email-timur@codeaurora.org> (raw)

From: Jack Pham <jackp@codeaurora.org>

Disable the silicon quirk which is normally enabled for HSIC
host mode. This would otherwise prevent low speed devices
from enumerating properly.

Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
 drivers/usb/host/ehci-msm.c      | 2 ++
 include/linux/usb/msm_hsusb_hw.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c
index c23e285..aed499d 100644
--- a/drivers/usb/host/ehci-msm.c
+++ b/drivers/usb/host/ehci-msm.c
@@ -61,6 +61,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd)
 	writel(0x8, USB_AHBMODE);
 	/* Disable streaming mode and select host mode */
 	writel(0x13, USB_USBMODE);
+	/* Disable ULPI_TX_PKT_EN_CLR_FIX which is valid only for HSIC */
+	writel(readl(USB_GENCONFIG_2) & ~ULPI_TX_PKT_EN_CLR_FIX, USB_GENCONFIG_2);
 
 	return 0;
 }
diff --git a/include/linux/usb/msm_hsusb_hw.h b/include/linux/usb/msm_hsusb_hw.h
index e159b39..974c379 100644
--- a/include/linux/usb/msm_hsusb_hw.h
+++ b/include/linux/usb/msm_hsusb_hw.h
@@ -22,6 +22,7 @@
 #define USB_AHBBURST         (MSM_USB_BASE + 0x0090)
 #define USB_AHBMODE          (MSM_USB_BASE + 0x0098)
 #define USB_GENCONFIG_2      (MSM_USB_BASE + 0x00a0)
+#define ULPI_TX_PKT_EN_CLR_FIX	BIT(19)
 
 #define USB_CAPLENGTH        (MSM_USB_BASE + 0x0100) /* 8 bit */
 
-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

             reply	other threads:[~2015-12-11  0:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  0:28 Timur Tabi [this message]
2015-12-11  0:28 ` [PATCH 2/5] [v2] usb: host: ehci-msm: Remove dependency on OTG PHY Timur Tabi
     [not found]   ` <1449793737-1816-2-git-send-email-timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-12-11 21:32     ` Andy Gross
     [not found] ` <1449793737-1816-1-git-send-email-timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-12-11  0:28   ` [PATCH 3/5] [v2] usb: host: ehci-msm: Add support for ACPI probing Timur Tabi
2015-12-11 21:33     ` Andy Gross
2015-12-11  0:28   ` [PATCH 4/5] [v2] usb: host: ehci-msm: Fix register initialization Timur Tabi
2015-12-11 21:34     ` Andy Gross
2015-12-11  0:28 ` [PATCH 5/5] [v2] usb: host: ehci-msm: Register usb shutdown function Timur Tabi
2015-12-11 21:34   ` Andy Gross
2016-01-06 20:20 ` [PATCH 1/5] [v2] usb: host: ehci-msm: Allow LS devices to work Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449793737-1816-1-git-send-email-timur@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=balbi@ti.com \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=greg@kroah.com \
    --cc=iivanov@mm-sol.com \
    --cc=jackp@codeaurora.org \
    --cc=jcm@redhat.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mlangsdo@redhat.com \
    --cc=pelcan@codeaurora.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.