Re: [OSSTEST PATCH 5/8] Schema: Support database schema updates

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-12-11 at 15:34 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database
> schema updates"):
> > On Fri, 2015-12-11 at 15:15 +0000, Ian Jackson wrote:
> > > I can put this in a comment if you like.
> > 
> > I suppose a comment next to any such override is a pretty good policy
> > to
> > have.
> 
> OK.  See below; I have folded each hunk into the appropriate patch.

Looks good, thanks.

> 
> > With that: Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Thanks,
> Ian.
> 
> diff --git a/mg-schema-create b/mg-schema-create
> index e15ecb9..9bb3040 100755
> --- a/mg-schema-create
> +++ b/mg-schema-create
> @@ -67,9 +67,17 @@ while [ $# != 0 ]; do
>  done
>  
>  export OSSTEST_DB_USEREAL_IGNORETEST='.*'
> +# Completely disable this safety catch, because it otherwise breaks
> +# when run on an empty schema (since there is no `tasks' table).
> +#
> +# It is not needed because if we are mistakenly operating on an
> +# existing database (test or real) we will bomb out because the first
> +# thing in `initial.sql' is to create the already-existing `flights'
> +# table ...
>  
>  . ./cri-getconfig
>  
> +# ... Unless some update has been applied which removed `flights':
>  updates_applied=$(./mg-schema-update list-applied)
>  if [ "x$updates_applied" != x ]; then
>      ./mg-schema-update show

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel