From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbbLKVPN (ORCPT ); Fri, 11 Dec 2015 16:15:13 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37415 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbbLKVPL (ORCPT ); Fri, 11 Dec 2015 16:15:11 -0500 From: David Eccher To: Felipe Balbi Cc: Greg Kroah-Hartman , Al Viro , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, David Eccher Subject: [PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write Date: Fri, 11 Dec 2015 22:13:55 +0100 Message-Id: <1449868435-11492-1-git-send-email-d.eccher@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config. Signed-off-by: David Eccher --- drivers/usb/gadget/legacy/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index f454c7a..365afd7 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -1137,10 +1137,9 @@ ep0_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) dev->gadget->ep0, dev->req, GFP_KERNEL); } + spin_lock_irq(&dev->lock); if (retval < 0) { - spin_lock_irq (&dev->lock); clean_req (dev->gadget->ep0, dev->req); - spin_unlock_irq (&dev->lock); } else retval = len; -- 1.8.1.2