From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
linux-wireless@vger.kernel.org, Felix Fietkau <nbd@openwrt.org>,
Ido Yariv <ido@wizery.com>
Subject: Re: SUPPORTS_CLONED_SKBS question
Date: Mon, 14 Dec 2015 14:30:51 +0100 [thread overview]
Message-ID: <1450099851.3871.19.camel@sipsolutions.net> (raw)
In-Reply-To: <CALhHN=prjjYLWEa6XSZSOwWTW+3eggPKQ3P1eNCt1fhKUwwvMQ@mail.gmail.com> (sfid-20151214_135825_770699_738420CE)
+Ido.
On Mon, 2015-12-14 at 13:58 +0100, Janusz Dziedzic wrote:
> Base of SUPPORTS_CLONED_SKBS description, we can set this flag
> in case driver will not touch payload or tailroom.
> What exactly does it mean?
Well, you must not modify the data in a way that would make the clone
invalid. That means you can't write to any of the data, essentially.
> What in case of headroom, while ath9k already move 80211 header - add
> padding
> after header (skb_push(hdrlen & 3) + memmove) and remove this padding
> in tx_completion.
I think that should be OK since you don't touch the payload data or the
tailroom.
> What in case of FCS?
What about it? Hopefully that's added by hardware and has no effect on
the skb?!
johannes
prev parent reply other threads:[~2015-12-14 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 12:58 SUPPORTS_CLONED_SKBS question Janusz Dziedzic
2015-12-14 13:30 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450099851.3871.19.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ido@wizery.com \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.