From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 14 Dec 2015 22:20:05 +0000 Subject: Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection Message-Id: <1450131605.15946.396.camel@freescale.com> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <566F3E49.2010506@users.sourceforge.net> In-Reply-To: <566F3E49.2010506@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Mon, 2015-12-14 at 23:10 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 14 Dec 2015 23:01:32 +0100 > > A status check was performed by the fsl_get_immr() function even if it > was known already that a system setting did not fit to the expectations. > > This implementation detail could be improved by an adjustment for > a jump label according to the Linux coding style convention. What is the actual problem you're trying to solve? Cluttering the code to micro-optimize an error path is not an improvement. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0144.outbound.protection.outlook.com [157.56.110.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id B923F1A0026 for ; Tue, 15 Dec 2015 09:20:31 +1100 (AEDT) Message-ID: <1450131605.15946.396.camel@freescale.com> Subject: Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection From: Scott Wood To: SF Markus Elfring , "Benjamin Herrenschmidt" , Michael Ellerman , Paul Mackerras , CC: LKML , , Julia Lawall Date: Mon, 14 Dec 2015 16:20:05 -0600 In-Reply-To: <566F3E49.2010506@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <566F3E49.2010506@users.sourceforge.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-12-14 at 23:10 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 14 Dec 2015 23:01:32 +0100 > > A status check was performed by the fsl_get_immr() function even if it > was known already that a system setting did not fit to the expectations. > > This implementation detail could be improved by an adjustment for > a jump label according to the Linux coding style convention. What is the actual problem you're trying to solve? Cluttering the code to micro-optimize an error path is not an improvement. -Scott