From: Vladislav Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: Vladislav Yasevich <vyasevich@gmail.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Patrick McHardy <kaber@trash.net>
Subject: [PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header
Date: Mon, 14 Dec 2015 17:44:10 -0500 [thread overview]
Message-ID: <1450133050-24636-1-git-send-email-vyasevich@gmail.com> (raw)
In-Reply-To: <566ED772.8070600@6wind.com>
skb_reorder_vlan_header is called after the vlan header has
been pulled. As a result the offset of the begining of
the mac header has been incrased by 4 bytes (VLAN_HLEN).
When moving the mac addresses, include this incrase in
the offset calcualation so that the mac addresses are
copied correctly.
Fixes: a6e18ff1117 (vlan: Fix untag operations of stacked vlans with REORDER_HEADER off)
CC: Nicolas Dichtel <nicolas.dichtel@6wind.com>
CC: Patrick McHardy <kaber@trash.net>
Signed-off-by: Vladislav Yasevich <vyasevich@gmail.com>
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 152b9c7..5cc43d37 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4268,7 +4268,7 @@ static struct sk_buff *skb_reorder_vlan_header(struct sk_buff *skb)
return NULL;
}
- memmove(skb->data - ETH_HLEN, skb->data - skb->mac_len,
+ memmove(skb->data - ETH_HLEN, skb->data - skb->mac_len - VLAN_HLEN,
2 * ETH_ALEN);
skb->mac_header += VLAN_HLEN;
return skb;
--
2.1.0
next prev parent reply other threads:[~2015-12-14 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 20:43 [PATCH 0/2] Fix issues with vlans without REORDER_HEADER Vladislav Yasevich
2015-11-16 20:43 ` [PATCH 1/2] vlan: Fix untag operations of stacked vlans with REORDER_HEADER off Vladislav Yasevich
2015-12-14 14:51 ` Nicolas Dichtel
2015-12-14 22:44 ` Vladislav Yasevich [this message]
2015-12-15 5:31 ` [PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header David Miller
2015-12-15 14:57 ` Nicolas Dichtel
2015-11-16 20:43 ` [PATCH 2/2] vlan: Do not put vlan headers back on bridge and macvlan ports Vladislav Yasevich
2015-11-17 19:39 ` [PATCH 0/2] Fix issues with vlans without REORDER_HEADER David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450133050-24636-1-git-send-email-vyasevich@gmail.com \
--to=vyasevich@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.