All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v1 2/2] libxl: re-implement libxl__xs_printf()
Date: Tue, 15 Dec 2015 12:29:35 +0000	[thread overview]
Message-ID: <1450182575.16856.161.camel@citrix.com> (raw)
In-Reply-To: <1449594243.16124.117.camel@citrix.com>

On Tue, 2015-12-08 at 17:04 +0000, Ian Campbell wrote:
> On Wed, 2015-12-02 at 15:22 +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > > Sent: 02 December 2015 15:21
> > > To: Paul Durrant; xen-devel@lists.xenproject.org
> > > Cc: Ian Jackson; Stefano Stabellini; Wei Liu
> > > Subject: Re: [PATCH v1 2/2] libxl: re-implement libxl__xs_printf()
> > > 
> > > On Tue, 2015-12-01 at 13:55 +0000, Paul Durrant wrote:
> > > > This patch adds a new libxl__xs_vprintf() which actually checks the
> > > > success of the underlying call to xs_write() (logging if it fails)
> > > > and
> > > > then re-implements libxl__xs_printf() using this (and replacing the
> > > > call to vasprintf() with a call to libxl__vsprintf()).
> > > 
> > > Is the addition of libxl__xs_vprintf() an end in itself (i.e. do you
> > > have
> > > an upcoming use for it) or just an artefact of how you decided to fix
> > > libxl__xs_printf()?
> > > 
> > 
> > It's an artefact but seemed sufficiently useful to expose.
> 
> Thanks:
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

And now applied, sorry for the delay.

The comment on libxl__xs_mknod in the context was different but I resolved
that, hopefully correctly!

Did you have any other of these updates available? IIRC there were two
series and both are now in, but there might be a third?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-12-15 13:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 13:55 [PATCH v1 0/2] libxl: change libxl__xs_write() to libxl__xs_printf() Paul Durrant
2015-12-01 13:55 ` [PATCH v1 1/2] libxl: re-name " Paul Durrant
2015-12-01 13:55 ` [PATCH v1 2/2] libxl: re-implement libxl__xs_printf() Paul Durrant
2015-12-02 15:20   ` Ian Campbell
2015-12-02 15:22     ` Paul Durrant
2015-12-08 17:04       ` Ian Campbell
2015-12-15 12:29         ` Ian Campbell [this message]
2015-12-15 12:30           ` Ian Campbell
2015-12-15 13:52             ` Paul Durrant
2015-12-15 15:13               ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2015-11-25 15:28 [PATCH v1 0/2] libxl: change libxl__xs_write() to libxl__xs_printf() Paul Durrant
2015-11-25 15:28 ` [PATCH v1 2/2] libxl: re-implement libxl__xs_printf() Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450182575.16856.161.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=Stefano.Stabellini@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.