diff for duplicates of <1450203011.4142.4.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index 9918612..709b2ee 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,7 +18,7 @@ On Tue, 2015-12-15 at 20:48 +0300, Dan Carpenter wrote: > > go on... > > > -> No. There is no test. The original code looks like: +> No.??There is no test.??The original code looks like: > > result = foo(); > if (result) @@ -35,7 +35,7 @@ Here is the original code: --------------------- /* Copy hsm_progress struct */ req_hpk = req_capsule_client_get(&req->rq_pill, &RMF_MDS_HSM_PROGRESS); - if (req_hpk = NULL) { + if (req_hpk == NULL) { rc = -EPROTO; goto out; } @@ -59,7 +59,3 @@ then it should be replaced by a blank line. It separates the last operation block from the return. cheers, Joe --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 1d3af62..3df4903 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,18 +6,9 @@ "ref\01450191751.3551.14.camel@perches.com\0" "ref\020151215174844.GE5284@mwanda\0" "From\0Joe Perches <joe@perches.com>\0" - "Subject\0Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions\0" - "Date\0Tue, 15 Dec 2015 18:10:11 +0000\0" - "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Cc\0SF Markus Elfring <elfring@users.sourceforge.net>" - Andreas Dilger <andreas.dilger@intel.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - Oleg Drokin <oleg.drokin@intel.com> - lustre-devel@lists.lustre.org - devel@driverdev.osuosl.org - LKML <linux-kernel@vger.kernel.org> - kernel-janitors@vger.kernel.org - " Julia Lawall <julia.lawall@lip6.fr>\0" + "Subject\0[lustre-devel] [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions\0" + "Date\0Tue, 15 Dec 2015 10:10:11 -0800\0" + "To\0lustre-devel@lists.lustre.org\0" "\00:1\0" "b\0" "On Tue, 2015-12-15 at 20:48 +0300, Dan Carpenter wrote:\n" @@ -40,7 +31,7 @@ "> > \tgo on...\n" "> > \n" "> \n" - "> No.\302\240\302\240There is no test.\302\240\302\240The original code looks like:\n" + "> No.??There is no test.??The original code looks like:\n" "> \n" "> \tresult = foo();\n" "> \tif (result)\n" @@ -57,7 +48,7 @@ "---------------------\n" "\t/* Copy hsm_progress struct */\n" "\treq_hpk = req_capsule_client_get(&req->rq_pill, &RMF_MDS_HSM_PROGRESS);\n" - "\tif (req_hpk = NULL) {\n" + "\tif (req_hpk == NULL) {\n" "\t\trc = -EPROTO;\n" "\t\tgoto out;\n" "\t}\n" @@ -80,10 +71,6 @@ "\n" "It separates the last operation block from the return.\n" "\n" - "cheers, Joe\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + cheers, Joe -6ba6a9ef30ffa0cf4b7a5c25a6c0416ab1568b4d80a9d56ff2c2244d23ad5c62 +3c34042d026ee1a6e79f578f0ddc06b615807346167cabc2eeefcc1a5533dc3c
diff --git a/a/1.txt b/N2/1.txt index 9918612..48eb0bb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -35,7 +35,7 @@ Here is the original code: --------------------- /* Copy hsm_progress struct */ req_hpk = req_capsule_client_get(&req->rq_pill, &RMF_MDS_HSM_PROGRESS); - if (req_hpk = NULL) { + if (req_hpk == NULL) { rc = -EPROTO; goto out; } @@ -59,7 +59,3 @@ then it should be replaced by a blank line. It separates the last operation block from the return. cheers, Joe --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 1d3af62..dc8c8d7 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -7,7 +7,7 @@ "ref\020151215174844.GE5284@mwanda\0" "From\0Joe Perches <joe@perches.com>\0" "Subject\0Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions\0" - "Date\0Tue, 15 Dec 2015 18:10:11 +0000\0" + "Date\0Tue, 15 Dec 2015 10:10:11 -0800\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0SF Markus Elfring <elfring@users.sourceforge.net>" Andreas Dilger <andreas.dilger@intel.com> @@ -57,7 +57,7 @@ "---------------------\n" "\t/* Copy hsm_progress struct */\n" "\treq_hpk = req_capsule_client_get(&req->rq_pill, &RMF_MDS_HSM_PROGRESS);\n" - "\tif (req_hpk = NULL) {\n" + "\tif (req_hpk == NULL) {\n" "\t\trc = -EPROTO;\n" "\t\tgoto out;\n" "\t}\n" @@ -80,10 +80,6 @@ "\n" "It separates the last operation block from the return.\n" "\n" - "cheers, Joe\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + cheers, Joe -6ba6a9ef30ffa0cf4b7a5c25a6c0416ab1568b4d80a9d56ff2c2244d23ad5c62 +658c6f600cbe6df01d464ee8bcf8673796b9b9c6f29e8faed560a27a940f70d6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.