From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Subject: Re: [PATCH] Revert "drm: Stop resetting connector state to unknown" Date: Tue, 15 Dec 2015 15:34:18 -0500 Message-ID: <1450211658.8084.11.camel@redhat.com> References: <1450202871-15062-1-git-send-email-cpaul@redhat.com> <20151215183339.GO4437@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4D2A6E7B4 for ; Tue, 15 Dec 2015 12:34:23 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: kuddel.mail@gmx.de, Julien Wajsberg , Daniel Vetter , open list , "open list:DRM DRIVERS" , Benjamin Tissoires , Lennart Poettering List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE1LTEyLTE1IGF0IDEzOjQyIC0wNTAwLCBSb2IgQ2xhcmsgd3JvdGU6Cj4gT24g VHVlLCBEZWMgMTUsIDIwMTUgYXQgMTozMyBQTSwgVmlsbGUgU3lyasOkbMOkCj4gPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+IE9uIFR1ZSwgRGVjIDE1LCAyMDE1IGF0 IDAxOjIzOjA2UE0gLTA1MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+ID4gT24gVHVlLCBEZWMgMTUs IDIwMTUgYXQgMTowNyBQTSwgTHl1ZGUgPGNwYXVsQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPiA+ IFRoaXMgcmV2ZXJ0cyBjb21taXQgNTY3N2Q2N2FlMzk0ICgiZHJtOiBTdG9wIHJlc2V0dGluZyBj b25uZWN0b3Igc3RhdGUKPiA+ID4gPiB0bwo+ID4gPiA+IHVua25vd24iKQo+ID4gPiA+IAo+ID4g PiA+IFVuZm9ydHVuYXRlbHksIG5vdCByZXNldHRpbmcgdGhlIGNvbm5lY3RvciBzdGF0dXMgdG8g dW5rbm93biBhY3R1YWxseQo+ID4gPiA+IGJyZWFrcyByZXByb2Jpbmcgb24gc3VzcGVuZC9yZXN1 bWUgaW4gaTkxNSwgd2hpY2ggaXMgaW1wb3J0YW50IHRvIGhhdmUKPiA+ID4gPiB3b3JraW5nIHNp bmNlIGl0IG1lYW5zIGEgdXNlciBkb2NraW5nIHRoZWlyIGxhcHRvcCBpbiBzdXNwZW5kIHdvbid0 IGhhdmUKPiA+ID4gPiB0aGVpciBtb25pdG9ycyB3b3JrIGFmdGVyIHJlc3VtZS4gVGhpcyBjb21t aXQgd2FzIG9yaWdpbmFsbHkgcHVzaGVkIHRvCj4gPiA+ID4gZml4Cj4gPiA+ID4gYSBidWcgd2l0 aCBzeXN0ZW1kWzFdLCBob3dldmVyIHNhaWQgYnVnIGhhcyBhbHJlYWR5IGJlZW4gZml4ZWQgaW4K PiA+ID4gPiB1c2Vyc3BhY2UuCj4gPiA+ID4gCj4gPiA+ID4gU2luY2UgInVua25vd24iIGlzIHRl Y2huaWNhbGx5IGEgdmFsaWQgb3B0aW9uIHRvIHJldHVybiB0byB1c2Vyc3BhY2UgZm9yCj4gPiA+ ID4gYQo+ID4gPiA+IGNvbm5lY3RvcidzIHN0YXR1cywgSSB3b3VsZCB0aGluayB0aGF0IHRoaXMg c29ydCBvZiBiZWhhdmlvciBzaG91bGQKPiA+ID4gPiBwcm9iYWJseSBiZSBleHBlY3RlZCBmcm9t IHVzZXJzcGFjZS4gU29tZSBnb29kIGV4YW1wbGVzIG9mIHRoaXMgYXJlIHRoZQo+ID4gPiA+IHJh ZGVvbiBkcml2ZXIgcmVwb3J0aW5nICJ1bmtub3duIiBmb3IgY29ubmVjdG9ycyB0aGF0IGhhdmUg ZG9uZQo+ID4gPiA+IHNvbWV0aGluZwo+ID4gPiA+IHdvbmt5IGR1cmluZyBhIGhvdHBsdWcgZXZl bnQgKGUuZy4gcGFydCBvZiB0aGUgaW5pdGlhbGl6YXRpb24gb2YgdGhlCj4gPiA+ID4gY29ubmVj dG9yIGZhaWxlZCksIGFuZCB0aGUgb21hcGRybSBkcml2ZXIgcmV0dXJucyAidW5rbm93biIgZm9y IGNlcnRhaW4KPiA+ID4gPiBjb25uZWN0b3IgdHlwZXMgYnkgZGVmYXVsdC4KPiA+ID4gPiAKPiA+ ID4gPiBbMV06IGh0dHBzOi8vYnVnemlsbGEua2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw NjQxCj4gPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgPGNwYXVsQHJlZGhhdC5j b20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyB8IDcg KysrKy0tLQo+ID4gPiA+IMKgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4gPiA+IGluZGV4IDI0YzU0 MzQuLjQ3NGU2MzYgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRj LmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4gPiA+IEBAIC01 MzEyLDExICs1MzEyLDEyIEBAIHZvaWQgZHJtX21vZGVfY29uZmlnX3Jlc2V0KHN0cnVjdCBkcm1f ZGV2aWNlCj4gPiA+ID4gKmRldikKPiA+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoGlmIChlbmNvZGVyLT5mdW5jcy0+cmVzZXQpCj4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZW5jb2Rlci0+ZnVuY3MtPnJlc2V0KGVuY29k ZXIpOwo+ID4gPiA+IAo+ID4gPiA+IC3CoMKgwqDCoMKgwqDCoG11dGV4X2xvY2soJmRldi0+bW9k ZV9jb25maWcubXV0ZXgpOwo+ID4gPiA+IC3CoMKgwqDCoMKgwqDCoGRybV9mb3JfZWFjaF9jb25u ZWN0b3IoY29ubmVjdG9yLCBkZXYpCj4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgbGlzdF9mb3JfZWFj aF9lbnRyeShjb25uZWN0b3IsICZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rvcl9saXN0LCAKPiA+ ID4gPiBoZWFkKSB7Cj4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGNvbm5l Y3Rvci0+c3RhdHVzID0gY29ubmVjdG9yX3N0YXR1c191bmtub3duOwo+ID4gPiA+ICsKPiA+ID4g PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGlmIChjb25uZWN0b3ItPmZ1bmNzLT5y ZXNldCkKPiA+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqBjb25uZWN0b3ItPmZ1bmNzLT5yZXNldChjb25uZWN0b3IpOwo+ID4gPiA+IC3CoMKgwqDC oMKgwqDCoG11dGV4X3VubG9jaygmZGV2LT5tb2RlX2NvbmZpZy5tdXRleCk7Cj4gPiA+ID4gK8Kg wqDCoMKgwqDCoMKgfQo+ID4gPiA+IMKgfQo+ID4gPiAKPiA+ID4gbG9va3MgbGlrZSBnaXQtcmV2 ZXJ0IG1pZ2h0IGhhdmUgYmVlbiBhIGJpdCBvdmVyLWFtYml0aW91cyBhbmQKPiA+ID4gY2xvYmJl cmVkIGEgY291cGxlIHN1YnNlcXVlbnQgY2hhbmdlcy4uIGJ1dCB0aGF0IGlzIGVhc3kgZW5vdWdo IHRvIGZpeAo+ID4gPiBvbmNlIHdlIGZpZ3VyZSBvdXQgd2hhdCB0aGUgcmlnaHQgdGhpbmcgdG8g ZG8gaXMuCj4gPiA+IAo+ID4gPiBCZXlvbmQgdGhhdC4uIEknbSBub3QgcmVhbGx5IHN1cmUgaG93 IHRvIGFwcGx5IHRoZSAiZG8gbm90IGJyZWFrCj4gPiA+IHVzZXJzcGFjZSIgcnVsZSBoZXJlLi4g c2luY2UgcHJpb3IgdG8KPiA+ID4gYzQ4NGYwMmQwZjAyZmJiZmM2ZGVjYzk0NWE2OWFhZTAxMTA0 MWEyNyB1c2Vyc3BhY2UgY291bGQgc2VlICJ1bmtub3duIgo+ID4gPiBmb3IgY2VydGFpbiBoYXJk d2FyZS7CoMKgQnV0IGFmdGVyIHRoYXQgY29tbWl0IGl0IGNvdWxkIHN0YXJ0IHNlZWluZwo+ID4g PiAidW5rbm93biIgZm9yIGRyaXZlcnMvY29ubmVjdG9ycyB0aGF0IG5ldmVyIHdvdWxkIGhhdmUg cmV0dXJuZWQKPiA+ID4gInVua25vd24iIGJlZm9yZS7CoMKgSWYgdXNlcnNwYWNlIGhhZCBhIHBy b2JsZW0gd2l0aCAidW5rbm93biIsIGl0Cj4gPiA+IHNvdW5kcyBsaWtlIGEgdXNlcnNwYWNlIGJ1 ZyB0aGF0IHdhcyBqdXN0IHVubm90aWNlZCBiZWNhdXNlIG5vIG9uZQo+ID4gPiB0ZXN0ZWQgb24g dGhlIHJpZ2h0IGhhcmR3YXJlLgo+ID4gPiAKPiA+ID4gQnV0IGFueXdheXMsIG9uZSBpZGVhIHRv IHJldmVydCB0aGluZ3MgdG8gb3JpZ2luYWwgYmVoYXZpb3IgcHJpb3IgdG8KPiA+ID4gYzQ4NGYw MmQwZjAyZmJiZmM2ZGVjYzk0NWE2OWFhZTAxMTA0MWEyNyAoc28gYXQgbGVhc3QgdXNlcnNwYWNl Cj4gPiA+IGRvZXNuJ3Qgc2VlICd1bmtub3duJyBmb3IgZHJpdmVycy9jb25uZWN0b3JzIHRoYXQg bmV2ZXIgdXNlZCB0byByZXBvcnQKPiA+ID4gJ3Vua25vd24nKSB3b3VsZCBiZSB0byBkbyBzb21l dGhpbmcgcm91Z2hseSBsaWtlIHRoaXMgaW4KPiA+ID4gc3RhdHVzX3Nob3coKToKPiA+ID4gCj4g PiA+IMKgIGlmIChzdGF0dXMgPT0gdW5rbm93bikKPiA+ID4gwqDCoMKgwqDCoHN0YXR1cyA9IGNv bm5lY3Rvci0+ZnVuY3MtPmRldGVjdChjb25uZWN0b3IpCj4gPiA+IAo+ID4gPiBTbyBJIGNvdWxk IGdvIHdpdGggZWl0aGVyIGp1c3QgcmV2ZXJ0aW5nIHRoaXMgY29tbWl0LCBvciByZXZlcnRpbmcK PiA+ID4gY29tbWl0IHBsdXMgYWJvdmUgY2hhbmdlLsKgwqBNeSAkMC4wMiBhbnl3YXlzLi4KPiA+ IAo+ID4gSG1tLiBPciBtYXliZSBsZWF2ZSB0aGUgc3RhdGVzIGFsb25lLCBhbmQganVzdCBmaXJl IG9mZiB0aGUgdWV2ZW50Cj4gPiB1bmNvbmRpdGlvbmFsbHkgYW5kIGxldCB1c2Vyc3BhY2UgaW5p dGlhdGUgdGhlIHByb2JlLiBUaGF0IHdheSB3ZSBjb3VsZAo+ID4gc2tpcCBhbGwgLT5kZXRlY3Qo KSBjYWxscyBkdXJpbmcgcmVzdW1lIGZvciBhIGJpdCBvZiBleHRyYSBzcGVlZC4KVGhlIGN1cnJl bnQgcHVycG9zZSBvZiBhbGwgb2YgdGhlIGRldGVjdCgpIGNhbGxzIGlzIHRvIGNoZWNrIHdoZXRo ZXIgb3Igbm90IGl0CndvdWxkIGJlIGFwcHJvcHJpYXRlIHRvIHNlbmQgdGhlIGhvdHBsdWcgZXZl bnQgKGFzc3VtaW5nIHlvdSBtZWFuCmRybV9rbXNfaGVscGVyX2hvdHBsdWdfZXZlbnQoKSksIGp1 c3Qgc28gdGhhdCB3ZSBjYW4gc2F2ZSByZXByb2JpbmcgYSBkaXNwbGF5IGlmCm5vdGhpbmcgY2hh bmdlZC4gQW55d2F5LCBpZiBzcGVlZCB3ZXJlIGFuIGlzc3VlIGhlcmUgd2UgY291bGQganVzdCBm aXJlIG9mZiBhCndvcmtlciBzbyB0aGF0IHRoZSByZXByb2JpbmcgZG9lc24ndCBob2xkIHVwIHRo ZSByZXN1bWUgcHJvY2Vzcy4KCldoaWxlIEknZCBiZSBmaW5lIHdpdGgganVzdCBmaXJpbmcgb2Zm IGEgcHJvYmUsIEkgZG9uJ3QgdGhpbmsgaXQgbWFrZXMgc2Vuc2UgdG8KYXZvaWQgaGF2aW5nIGFu IHVua25vd24gc3RhdGUgaGVyZSB3aGVuIG51bWVyb3VzIGRyaXZlcnMgYWxyZWFkeSB1c2UgdW5r bm93bgpzdGF0ZXMgcmVndWxhcmx5LCB1bmxlc3MgdGhlcmUgd2FzIGEgcmVhc29uIG90aGVyIHRo ZW4gdGhlIG9uZSBtZW50aW9uZWQgaW4gdGhlCmJ1Z3ppbGxhIGZvciBkb2luZyB0aGlzLgoKPiBU aGF0IGlzLCBpaXJjLCBzb21ldGhpbmcgdGhhdCBMeXVkZSBzdWdnZXN0ZWQgd2hlbiB3ZSBkaXNj dXNzZWQgaW4KPiBwZXJzb24gKGJ1dCBJIGFza2VkIGhpbSB0byBzZW5kIHJldmVydCBwYXRjaCBq dXN0IHRvIHN0YXJ0IGJyb2FkZXIKKmhlciBwbGVhc2UgOikKCj4gZGlzY3Vzc2lvbiBvbiB3aGF0 IHRoZSByaWdodCBzb2x1dGlvbiB3b3VsZCBiZSkuwqDCoERlcGVuZGluZyBvbgo+IHVzZXJzcGFj ZSB0byByZXByb2JlIHNlZW1zIGxpa2UgYXQgbGVhc3QgdGhlIHdyb25nIHRoaW5nIGZvciBmYmNv bi4uCj4gd2hpY2ggYXMgbXVjaCBhcyBJIHdpc2ggaXQgd291bGQgZ28gYXdheSwgYXMgbG9uZyBh cyBpdCBpcyBlbmFibGVkIGluCj4ga2VybmVsIGNvbmZpZywgSSBkb24ndCB0aGluayB3ZSBjYW4g aWdub3JlLgo+IAo+IEJSLAo+IC1SCj4gCj4gPiBOb3QgMTAwJSBpZiB0aGF0IHdvdWxkIGJlIHNh ZmUuIE1heWJlIHNvbWV0aGluZyBpbnRlcm5hbCBkZXBlbmRzIG9uIHRoZQo+ID4gLT5kZXRlY3Qo KSBoYXZpbmcgYmVlbiBjYWxsZWQ/IERQIHN0dWZmIHBlcmhhcHM/IFdoaWNoIG1ha2VzIG1lIHdv bmRlcgo+ID4gaG93IGk5MTUgY29wZXMgd2l0aCBhIERQIG1vbml0b3IgZ2V0aW5nIHVucGx1Z2dl ZC9jaGFuZ2Ugd2hpbGUKPiA+IHN1c3BlbmRlZC4gSSBzaG91bGQgcHJvYmFibHkgdHJ5IHRoYXQu Cj4gPiAKPiA+IC0tCj4gPiBWaWxsZSBTeXJqw6Rsw6QKPiA+IEludGVsIE9UQwotLSAKQ2hlZXJz LAoJTHl1ZGUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933678AbbLOUeW (ORCPT ); Tue, 15 Dec 2015 15:34:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59883 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933478AbbLOUeV (ORCPT ); Tue, 15 Dec 2015 15:34:21 -0500 Message-ID: <1450211658.8084.11.camel@redhat.com> Subject: Re: [PATCH] Revert "drm: Stop resetting connector state to unknown" From: Lyude To: Rob Clark , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: kuddel.mail@gmx.de, Daniel Vetter , open list , "open list:DRM DRIVERS" , Julien Wajsberg , Benjamin Tissoires , Lennart Poettering Date: Tue, 15 Dec 2015 15:34:18 -0500 In-Reply-To: References: <1450202871-15062-1-git-send-email-cpaul@redhat.com> <20151215183339.GO4437@intel.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-12-15 at 13:42 -0500, Rob Clark wrote: > On Tue, Dec 15, 2015 at 1:33 PM, Ville Syrjälä > wrote: > > On Tue, Dec 15, 2015 at 01:23:06PM -0500, Rob Clark wrote: > > > On Tue, Dec 15, 2015 at 1:07 PM, Lyude wrote: > > > > This reverts commit 5677d67ae394 ("drm: Stop resetting connector state > > > > to > > > > unknown") > > > > > > > > Unfortunately, not resetting the connector status to unknown actually > > > > breaks reprobing on suspend/resume in i915, which is important to have > > > > working since it means a user docking their laptop in suspend won't have > > > > their monitors work after resume. This commit was originally pushed to > > > > fix > > > > a bug with systemd[1], however said bug has already been fixed in > > > > userspace. > > > > > > > > Since "unknown" is technically a valid option to return to userspace for > > > > a > > > > connector's status, I would think that this sort of behavior should > > > > probably be expected from userspace. Some good examples of this are the > > > > radeon driver reporting "unknown" for connectors that have done > > > > something > > > > wonky during a hotplug event (e.g. part of the initialization of the > > > > connector failed), and the omapdrm driver returns "unknown" for certain > > > > connector types by default. > > > > > > > > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=100641 > > > > > > > > Signed-off-by: Lyude > > > > --- > > > >  drivers/gpu/drm/drm_crtc.c | 7 ++++--- > > > >  1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > > > index 24c5434..474e636 100644 > > > > --- a/drivers/gpu/drm/drm_crtc.c > > > > +++ b/drivers/gpu/drm/drm_crtc.c > > > > @@ -5312,11 +5312,12 @@ void drm_mode_config_reset(struct drm_device > > > > *dev) > > > >                 if (encoder->funcs->reset) > > > >                         encoder->funcs->reset(encoder); > > > > > > > > -       mutex_lock(&dev->mode_config.mutex); > > > > -       drm_for_each_connector(connector, dev) > > > > +       list_for_each_entry(connector, &dev->mode_config.connector_list, > > > > head) { > > > > +               connector->status = connector_status_unknown; > > > > + > > > >                 if (connector->funcs->reset) > > > >                         connector->funcs->reset(connector); > > > > -       mutex_unlock(&dev->mode_config.mutex); > > > > +       } > > > >  } > > > > > > looks like git-revert might have been a bit over-ambitious and > > > clobbered a couple subsequent changes.. but that is easy enough to fix > > > once we figure out what the right thing to do is. > > > > > > Beyond that.. I'm not really sure how to apply the "do not break > > > userspace" rule here.. since prior to > > > c484f02d0f02fbbfc6decc945a69aae011041a27 userspace could see "unknown" > > > for certain hardware.  But after that commit it could start seeing > > > "unknown" for drivers/connectors that never would have returned > > > "unknown" before.  If userspace had a problem with "unknown", it > > > sounds like a userspace bug that was just unnoticed because no one > > > tested on the right hardware. > > > > > > But anyways, one idea to revert things to original behavior prior to > > > c484f02d0f02fbbfc6decc945a69aae011041a27 (so at least userspace > > > doesn't see 'unknown' for drivers/connectors that never used to report > > > 'unknown') would be to do something roughly like this in > > > status_show(): > > > > > >   if (status == unknown) > > >      status = connector->funcs->detect(connector) > > > > > > So I could go with either just reverting this commit, or reverting > > > commit plus above change.  My $0.02 anyways.. > > > > Hmm. Or maybe leave the states alone, and just fire off the uevent > > unconditionally and let userspace initiate the probe. That way we could > > skip all ->detect() calls during resume for a bit of extra speed. The current purpose of all of the detect() calls is to check whether or not it would be appropriate to send the hotplug event (assuming you mean drm_kms_helper_hotplug_event()), just so that we can save reprobing a display if nothing changed. Anyway, if speed were an issue here we could just fire off a worker so that the reprobing doesn't hold up the resume process. While I'd be fine with just firing off a probe, I don't think it makes sense to avoid having an unknown state here when numerous drivers already use unknown states regularly, unless there was a reason other then the one mentioned in the bugzilla for doing this. > That is, iirc, something that Lyude suggested when we discussed in > person (but I asked him to send revert patch just to start broader *her please :) > discussion on what the right solution would be).  Depending on > userspace to reprobe seems like at least the wrong thing for fbcon.. > which as much as I wish it would go away, as long as it is enabled in > kernel config, I don't think we can ignore. > > BR, > -R > > > Not 100% if that would be safe. Maybe something internal depends on the > > ->detect() having been called? DP stuff perhaps? Which makes me wonder > > how i915 copes with a DP monitor geting unplugged/change while > > suspended. I should probably try that. > > > > -- > > Ville Syrjälä > > Intel OTC -- Cheers, Lyude