From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH] net: add Qualcomm IPC router Date: Tue, 15 Dec 2015 15:13:25 -0600 Message-ID: <1450214005.4464.9.camel@redhat.com> References: <1449866519-14551-1-git-send-email-bjorn.andersson@sonymobile.com> <20151215.160114.1178824607335349574.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151215.160114.1178824607335349574.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Miller , bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, courtney.cavin-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org List-Id: linux-api@vger.kernel.org On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote: > From: Bjorn Andersson > Date: Fri, 11 Dec 2015 12:41:59 -0800 > > > +static unsigned int qrtr_local_nid = 1; > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO); > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier"); Also s/idVendor/node_id? Dan > Module parameters suck. > > Allow the user to choose this dynamically. You have roughtly two > choices. > > 1) Subvert the 'protocol' field passed to ->create() and use that, it > is > being ignored otherwise. > > 2) Put it into the socket address for bind(). > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: dcbw@redhat.com (Dan Williams) Date: Tue, 15 Dec 2015 15:13:25 -0600 Subject: [PATCH] net: add Qualcomm IPC router In-Reply-To: <20151215.160114.1178824607335349574.davem@davemloft.net> References: <1449866519-14551-1-git-send-email-bjorn.andersson@sonymobile.com> <20151215.160114.1178824607335349574.davem@davemloft.net> Message-ID: <1450214005.4464.9.camel@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote: > From: Bjorn Andersson > Date: Fri, 11 Dec 2015 12:41:59 -0800 > > > +static unsigned int qrtr_local_nid = 1; > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO); > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier"); Also s/idVendor/node_id? Dan > Module parameters suck. > > Allow the user to choose this dynamically. You have roughtly two > choices. > > 1) Subvert the 'protocol' field passed to ->create() and use that, it > is > being ignored otherwise. > > 2) Put it into the socket address for bind(). > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965413AbbLOVNc (ORCPT ); Tue, 15 Dec 2015 16:13:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41705 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754266AbbLOVNa (ORCPT ); Tue, 15 Dec 2015 16:13:30 -0500 Message-ID: <1450214005.4464.9.camel@redhat.com> Subject: Re: [PATCH] net: add Qualcomm IPC router From: Dan Williams To: David Miller , bjorn.andersson@sonymobile.com Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, netdev@vger.kernel.org, srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, courtney.cavin@sonymobile.com Date: Tue, 15 Dec 2015 15:13:25 -0600 In-Reply-To: <20151215.160114.1178824607335349574.davem@davemloft.net> References: <1449866519-14551-1-git-send-email-bjorn.andersson@sonymobile.com> <20151215.160114.1178824607335349574.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote: > From: Bjorn Andersson > Date: Fri, 11 Dec 2015 12:41:59 -0800 > > > +static unsigned int qrtr_local_nid = 1; > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO); > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier"); Also s/idVendor/node_id? Dan > Module parameters suck. > > Allow the user to choose this dynamically. You have roughtly two > choices. > > 1) Subvert the 'protocol' field passed to ->create() and use that, it > is > being ignored otherwise. > > 2) Put it into the socket address for bind(). > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html