Re: [PATCH RFC XEN v1 12/14] tools: libxc: implement modify_returncode for ARM.

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-12-16 at 16:22 +0000, Stefano Stabellini wrote:
> On Wed, 9 Dec 2015, Ian Campbell wrote:
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > ---
> >  tools/libxc/xc_resume.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/tools/libxc/xc_resume.c b/tools/libxc/xc_resume.c
> > index 87d4324..fa16c3e 100644
> > --- a/tools/libxc/xc_resume.c
> > +++ b/tools/libxc/xc_resume.c
> > @@ -81,6 +81,24 @@ static int modify_returncode(xc_interface *xch,
> > uint32_t domid)
> >      return 0;
> >  }
> >  
> > +#elif defined (__arm__) || defined(__aarch64__)
> > +
> > +static int modify_returncode(xc_interface *xch, uint32_t domid)
> > +{
> > +    vcpu_guest_context_any_t ctxt;
> > +    int rc;
> 
> 
> Should we call xc_domain_getinfo and check for info.shutdown_reason !=
> SHUTDOWN_suspend, like x86 does?

Yes absolutely, I'd missed that aspect and thought x86 was only looking for
HVM vs PV.

Actually, I bet I can refactor a bunch of this into common code with only a
small arch specific core.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel