From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/4] build: Hook the schedulers into Kconfig Date: Fri, 18 Dec 2015 02:35:03 +0100 Message-ID: <1450402503.19320.97.camel@citrix.com> References: <1450385974-12732-1-git-send-email-jonathan.creekmore@gmail.com> <1450385974-12732-2-git-send-email-jonathan.creekmore@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4400291680910989307==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a9jwx-0004MJ-Cx for xen-devel@lists.xenproject.org; Fri, 18 Dec 2015 01:35:15 +0000 In-Reply-To: <1450385974-12732-2-git-send-email-jonathan.creekmore@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jonathan Creekmore , xen-devel@lists.xenproject.org Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org --===============4400291680910989307== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-+uGjXof1NsbAhGEl2S5O" --=-+uGjXof1NsbAhGEl2S5O Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-12-17 at 14:59 -0600, Jonathan Creekmore wrote: > Allow the schedulers to be independently enabled or disabled at > compile-time instead of just allowing the scheduler to be selected on > the command line.=20 > Reading this quickly, that "instead" gave me a bit of an hard time. I'm not a native English speaker, and I'm sure it's me that am wrong, but for some reason the sentence made me think that the patch would somehow disallow specifying a scheduler during boot, in Xen's command line. Fact is, I don't think the phrase "instead of just allowing the scheduler to be selected on the command line." adds much information, and I'd just remove it. > To match existing behavior, all four schedulers are > compiled in by default, although the RTDS and ARINC653 are marked > EXPERIMENTAL to match their not currently supported status. >=20 This may change shortly, but as of now, Credit2 is still experimental too. I think I'd still recommend enabling it in the help file (i.e., I'm ok with "If unsure, say Y"), but we certainly should mark it with "(EPERIMENTAL)". I don't know much on how kconfig works, so all the changes to the makefile, etc, I'm not able to review them properly. On the other hand, the code here below... > --- a/xen/common/schedule.c > +++ b/xen/common/schedule.c > @@ -38,8 +38,8 @@ > =C2=A0#include > =C2=A0#include > =C2=A0 > -/* opt_sched: scheduler - default to credit */ > -static char __initdata opt_sched[10] =3D "credit"; > +/* opt_sched: scheduler - default to configured value */ > +static char __initdata opt_sched[10] =3D CONFIG_SCHED_DEFAULT; > =C2=A0string_param("sched", opt_sched); > =C2=A0 > =C2=A0/* if sched_smt_power_savings is set, > @@ -65,10 +65,18 @@ DEFINE_PER_CPU(struct schedule_data, > schedule_data); > =C2=A0DEFINE_PER_CPU(struct scheduler *, scheduler); > =C2=A0 > =C2=A0static const struct scheduler *schedulers[] =3D { > +#ifdef CONFIG_SCHED_CREDIT > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&sched_credit_def, > +#endif > +#ifdef CONFIG_SCHED_CREDIT2 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&sched_credit2_def, > +#endif > +#ifdef CONFIG_SCHED_ARINC653 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&sched_arinc653_def, > +#endif > +#ifdef CONFIG_SCHED_RTDS > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&sched_rtds_def, > +#endif > =C2=A0}; > =C2=A0 ... can have, with the changelog changed as shown, my: =C2=A0Acked-by: Dario Faggioli Regards, Daio --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-+uGjXof1NsbAhGEl2S5O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlZzYsgACgkQk4XaBE3IOsT4NQCghrdQhMZTfyTGTvE3vnYWgD0p nekAoJAttSu6PVC8MPUnIH0KX8X/qPLd =llgj -----END PGP SIGNATURE----- --=-+uGjXof1NsbAhGEl2S5O-- --===============4400291680910989307== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4400291680910989307==--