Re: [PATCH 1/4] build: Hook the schedulers into Kconfig

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1505 bytes --]

On Fri, 2015-12-18 at 10:52 +0000, George Dunlap wrote:
> On 18/12/15 01:35, Dario Faggioli wrote:
> > On Thu, 2015-12-17 at 14:59 -0600, Jonathan Creekmore wrote:
> > > Allow the schedulers to be independently enabled or disabled at
> > > compile-time instead of just allowing the scheduler to be
> > > selected on
> > > the command line. 
> > > 
> > Reading this quickly, that "instead" gave me a bit of an hard time.
> > I'm
> > not a native English speaker, and I'm sure it's me that am wrong,
> > but
> > for some reason the sentence made me think that the patch would
> > somehow
> > disallow specifying a scheduler during boot, in Xen's command line.
> 
> I think the "just" in the sentence is an attempt to disambiguate
> (i.e.,
> instead of *only* allowing the scheduler to be chosen on the
> command-line, *also* allow it to be chosen at compile-time).
> 
Indeed (for what my opinion on English grammar is worth :-D). That
"just" was what made me eventually get the meaning (together with
looking at the code). And, in fact, I don't dispute correctness, it's
just...

> But I agree that the whole clause isn't really necessary and it would
> be
> clearer without it.
> 
... this :-D

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel