diff for duplicates of <1450441926.30729.208.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 450111b..828255a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,19 +9,19 @@ On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: > +++ b/drivers/tty/serial/8250/8250_pnp.c > @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const > struct pnp_device_id *dev_id) -> =C2=A0 return -ENODEV; -> =C2=A0 -> =C2=A0#ifdef SERIAL_DEBUG_PNP +> return -ENODEV; +> +> #ifdef SERIAL_DEBUG_PNP > - printk(KERN_DEBUG I think it's not okay. -The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a +The rationale to have printk(KERN_DEBUG …) here is to allow a compilation with support of those messages independently on DYNAMIC_DEBUG. If you want to switch to DYNAMIC_DEBUG you have to carefully check what -is done under=C2=A0SERIAL_DEBUG_PNP. +is done under SERIAL_DEBUG_PNP. git grep on current linux-next shows that SERIAL_DEBUG_PNP is an orphan. @@ -30,23 +30,21 @@ So, I would suggest to remove #ifdef. > - "Setup PNP port: port %x, mem 0x%lx, irq %d, type > %d\n", -> - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uart.port.iobase, uart.p= -ort.mapbase, +> - uart.port.iobase, uart.port.mapbase, > uart.port.irq, uart.port.iotype); > + pr_debug("Setup PNP port: port %x, mem 0x%lx, irq %d, type > %d\n", -> + =C2=A0uart.port.iobase, uart.port.mapbase, -> + =C2=A0uart.port.irq, uart.port.iotype); -> =C2=A0#endif ->=20 +> + uart.port.iobase, uart.port.mapbase, +> + uart.port.irq, uart.port.iotype); +> #endif +> ---=20 +-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy -- -To unsubscribe from this list: send the line "unsubscribe linux-parisc"= - in +To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 4bb1a0f..ebc2916 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -40,19 +40,19 @@ "> +++ b/drivers/tty/serial/8250/8250_pnp.c\n" "> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const\n" "> struct pnp_device_id *dev_id)\n" - "> =C2=A0\t\treturn -ENODEV;\n" - "> =C2=A0\n" - "> =C2=A0#ifdef SERIAL_DEBUG_PNP\n" + "> \302\240\t\treturn -ENODEV;\n" + "> \302\240\n" + "> \302\240#ifdef SERIAL_DEBUG_PNP\n" "> -\tprintk(KERN_DEBUG\n" "\n" "I think it's not okay.\n" "\n" - "The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a\n" + "The rationale to have printk(KERN_DEBUG \342\200\246) here is to allow a\n" "compilation with support of those messages independently on\n" "DYNAMIC_DEBUG.\n" "\n" "If you want to switch to DYNAMIC_DEBUG you have to carefully check what\n" - "is done under=C2=A0SERIAL_DEBUG_PNP.\n" + "is done under\302\240SERIAL_DEBUG_PNP.\n" "\n" "git grep on current linux-next shows that SERIAL_DEBUG_PNP is an\n" "orphan.\n" @@ -61,25 +61,23 @@ "\n" "> -\t\t\"Setup PNP port: port %x, mem 0x%lx, irq %d, type\n" "> %d\\n\",\n" - "> -\t\t=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uart.port.iobase, uart.p=\n" - "ort.mapbase,\n" + "> -\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240uart.port.iobase, uart.port.mapbase,\n" "> uart.port.irq, uart.port.iotype);\n" "> +\tpr_debug(\"Setup PNP port: port %x, mem 0x%lx, irq %d, type\n" "> %d\\n\",\n" - "> +\t\t=C2=A0uart.port.iobase, uart.port.mapbase,\n" - "> +\t\t=C2=A0uart.port.irq, uart.port.iotype);\n" - "> =C2=A0#endif\n" - ">=20\n" + "> +\t\t\302\240uart.port.iobase, uart.port.mapbase,\n" + "> +\t\t\302\240uart.port.irq, uart.port.iotype);\n" + "> \302\240#endif\n" + "> \n" "\n" "\n" - "--=20\n" + "-- \n" "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" "Intel Finland Oy\n" "\n" "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\"=\n" - " in\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\" in\n" "the body of a message to majordomo@vger.kernel.org\n" More majordomo info at http://vger.kernel.org/majordomo-info.html -a2cc0ef89d5b3fe7aec96a6327d1cb68c45e9b02cdb0221a7748d29b554c85e3 +bc681eed7d8186a636713b90049a9d13bd808272349544857b09d9f2c0aa0f7d
diff --git a/a/1.txt b/N2/1.txt index 450111b..0ebf5bb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,19 +9,19 @@ On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: > +++ b/drivers/tty/serial/8250/8250_pnp.c > @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const > struct pnp_device_id *dev_id) -> =C2=A0 return -ENODEV; -> =C2=A0 -> =C2=A0#ifdef SERIAL_DEBUG_PNP +> return -ENODEV; +> +> #ifdef SERIAL_DEBUG_PNP > - printk(KERN_DEBUG I think it's not okay. -The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a +The rationale to have printk(KERN_DEBUG …) here is to allow a compilation with support of those messages independently on DYNAMIC_DEBUG. If you want to switch to DYNAMIC_DEBUG you have to carefully check what -is done under=C2=A0SERIAL_DEBUG_PNP. +is done under SERIAL_DEBUG_PNP. git grep on current linux-next shows that SERIAL_DEBUG_PNP is an orphan. @@ -30,23 +30,16 @@ So, I would suggest to remove #ifdef. > - "Setup PNP port: port %x, mem 0x%lx, irq %d, type > %d\n", -> - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uart.port.iobase, uart.p= -ort.mapbase, +> - uart.port.iobase, uart.port.mapbase, > uart.port.irq, uart.port.iotype); > + pr_debug("Setup PNP port: port %x, mem 0x%lx, irq %d, type > %d\n", -> + =C2=A0uart.port.iobase, uart.port.mapbase, -> + =C2=A0uart.port.irq, uart.port.iotype); -> =C2=A0#endif ->=20 +> + uart.port.iobase, uart.port.mapbase, +> + uart.port.irq, uart.port.iotype); +> #endif +> ---=20 +-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy - --- -To unsubscribe from this list: send the line "unsubscribe linux-parisc"= - in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 4bb1a0f..9ec49d1 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -40,19 +40,19 @@ "> +++ b/drivers/tty/serial/8250/8250_pnp.c\n" "> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const\n" "> struct pnp_device_id *dev_id)\n" - "> =C2=A0\t\treturn -ENODEV;\n" - "> =C2=A0\n" - "> =C2=A0#ifdef SERIAL_DEBUG_PNP\n" + "> \302\240\t\treturn -ENODEV;\n" + "> \302\240\n" + "> \302\240#ifdef SERIAL_DEBUG_PNP\n" "> -\tprintk(KERN_DEBUG\n" "\n" "I think it's not okay.\n" "\n" - "The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a\n" + "The rationale to have printk(KERN_DEBUG \342\200\246) here is to allow a\n" "compilation with support of those messages independently on\n" "DYNAMIC_DEBUG.\n" "\n" "If you want to switch to DYNAMIC_DEBUG you have to carefully check what\n" - "is done under=C2=A0SERIAL_DEBUG_PNP.\n" + "is done under\302\240SERIAL_DEBUG_PNP.\n" "\n" "git grep on current linux-next shows that SERIAL_DEBUG_PNP is an\n" "orphan.\n" @@ -61,25 +61,18 @@ "\n" "> -\t\t\"Setup PNP port: port %x, mem 0x%lx, irq %d, type\n" "> %d\\n\",\n" - "> -\t\t=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uart.port.iobase, uart.p=\n" - "ort.mapbase,\n" + "> -\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240uart.port.iobase, uart.port.mapbase,\n" "> uart.port.irq, uart.port.iotype);\n" "> +\tpr_debug(\"Setup PNP port: port %x, mem 0x%lx, irq %d, type\n" "> %d\\n\",\n" - "> +\t\t=C2=A0uart.port.iobase, uart.port.mapbase,\n" - "> +\t\t=C2=A0uart.port.irq, uart.port.iotype);\n" - "> =C2=A0#endif\n" - ">=20\n" + "> +\t\t\302\240uart.port.iobase, uart.port.mapbase,\n" + "> +\t\t\302\240uart.port.irq, uart.port.iotype);\n" + "> \302\240#endif\n" + "> \n" "\n" "\n" - "--=20\n" + "-- \n" "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" - "Intel Finland Oy\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\"=\n" - " in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Intel Finland Oy -a2cc0ef89d5b3fe7aec96a6327d1cb68c45e9b02cdb0221a7748d29b554c85e3 +6af02b7e466ddb05afd8ad28b9eef61d274141e46abff0212559e416b3b54ef3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.