From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9v0V-00054O-EQ for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:23:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9v0S-0005Qb-38 for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:23:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9v0R-0005QX-RS for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:23:36 -0500 Message-ID: <1450445013.15674.38.camel@redhat.com> From: Gerd Hoffmann Date: Fri, 18 Dec 2015 14:23:33 +0100 In-Reply-To: <20151218113844.GA31910@noname.redhat.com> References: <1441898372-32679-1-git-send-email-berto@igalia.com> <20151218113844.GA31910@noname.redhat.com> Content-Type: multipart/mixed; boundary="=-Ed3zX6wGk9Ln/eMPv5kZ" Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Alberto Garcia , qemu-devel@nongnu.org, Markus Armbruster --=-Ed3zX6wGk9Ln/eMPv5kZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fr, 2015-12-18 at 12:38 +0100, Kevin Wolf wrote: > Am 10.09.2015 um 17:19 hat Alberto Garcia geschrieben: > > The QEMU code is not internationalized and assumes that it runs under > > the C locale, but if we use the GTK+ UI we'll end up importing the > > locale settings from the environment. This can break things, such as > > the JSON generator and iotest 120 in locales that use a decimal comma. > >=20 > > We do however have translations for a few simple strings for the GTK+ > > menu items, so in order to run QEMU using the C locale, and yet have a > > translated UI let's use setlocale() for LC_MESSAGES only. > >=20 > > Signed-off-by: Alberto Garcia >=20 > Not sure why I noticed it only now and if it's related to any recent > package upgrade on my side (using RHEL 7), but I noticed that non-ASCII > characters in the GTK UI strings are broken for me and git bisect > pointed to this commit. I guess we need to set LC_CTYPE too. Can you try whenever the attached patch fixes the issue? thanks, Gerd --=-Ed3zX6wGk9Ln/eMPv5kZ Content-Disposition: attachment; filename="0001-gtk-fix-utf8-strings-in-the-ui.patch" Content-Type: text/x-patch; name="0001-gtk-fix-utf8-strings-in-the-ui.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA1NDgyMWE0YjQwNWNhMzFjOTk3NDg1YjU2M2VjNWM0M2RkNTNlNGVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KRGF0 ZTogRnJpLCAxOCBEZWMgMjAxNSAxNDoxNTo1NiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGd0azog Zml4IHV0Zjggc3RyaW5ncyBpbiB0aGUgdWkKCkNvbW1pdCAiMmNiNWQyYSBndGs6IHVzZSBzZXRs b2NhbGUoKSBmb3IgTENfTUVTU0FHRVMgb25seSIgcmVzdHJpY3RzCmxvY2F0ZSBzZXR0aW5ncyB0 byBMQ19NRVNTQUdFUywgdG8gYXZvaWQgYnVncyBjYXVzZWQgYnkgbG9jYWxlLXNwZWNpZmljCm51 bWJlciBwcmludGluZyAoTENfTlVNRVJJQykgYW5kIHBvc3NpYmx5IG90aGVycy4KCldlIG5lZWQg TENfQ1RZUEUgdG9vIHRvIG1ha2UgbWVzc2FnZXMgd2l0aCBjaGFycyBvdXRzaWRlIHVzLWFzY2lp IHdvcmsKY29ycmVjdGx5LiAgQWRkIGl0LgoKUmVwb3J0ZWQtYnk6IEtldmluIFdvbGYgPGt3b2xm QHJlZGhhdC5jb20+ClNpZ25lZC1vZmYtYnk6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQu Y29tPgotLS0KIHVpL2d0ay5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS91aS9ndGsuYyBiL3VpL2d0ay5jCmluZGV4 IDQ3YjM3ZTEuLjMwNDA3YTUgMTAwNjQ0Ci0tLSBhL3VpL2d0ay5jCisrKyBiL3VpL2d0ay5jCkBA IC0yMDQ0LDggKzIwNDQsOSBAQCB2b2lkIGd0a19kaXNwbGF5X2luaXQoRGlzcGxheVN0YXRlICpk cywgYm9vbCBmdWxsX3NjcmVlbiwgYm9vbCBncmFiX29uX2hvdmVyKQogCiAgICAgcy0+ZnJlZV9z Y2FsZSA9IEZBTFNFOwogCi0gICAgLyogTENfTUVTU0FHRVMgb25seS4gU2VlIGVhcmx5X2d0a19k aXNwbGF5X2luaXQoKSBmb3IgZGV0YWlscyAqLworICAgIC8qIExDX01FU1NBR0VTK0xDX0NUWVBF IG9ubHkuIFNlZSBlYXJseV9ndGtfZGlzcGxheV9pbml0KCkgZm9yIGRldGFpbHMgKi8KICAgICBz ZXRsb2NhbGUoTENfTUVTU0FHRVMsICIiKTsKKyAgICBzZXRsb2NhbGUoTENfQ1RZUEUsICIiKTsK ICAgICBiaW5kdGV4dGRvbWFpbigicWVtdSIsIENPTkZJR19RRU1VX0xPQ0FMRURJUik7CiAgICAg dGV4dGRvbWFpbigicWVtdSIpOwogCi0tIAoxLjguMy4xCgo= --=-Ed3zX6wGk9Ln/eMPv5kZ--