diff for duplicates of <1450638355.3430.34.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index e42f0e3..a39b761 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,15 +3,20 @@ On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > There is a type bug so it always returns success. -> >? +> > > > How many false positives do you have to sift > > through to find this sort of error? > -> The return type is thoughtfully bool, so it should be easy in this case.?? -> The function has a return -EINVAL and a return true, so even without the? +> The return type is thoughtfully bool, so it should be easy in this case. +> The function has a return -EINVAL and a return true, so even without the > return type it would be locally apparent that there is an inconsistency. True, -EINVAL is a non-bool constant, but bool returns can be a variable int. Dan, was the check any constant non-bool? + +-- +To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index f05974f..e99170d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,9 +2,16 @@ "ref\01450637228.3430.30.camel@perches.com\0" "ref\0alpine.DEB.2.02.1512201959090.2055@localhost6.localdomain6\0" "From\0Joe Perches <joe@perches.com>\0" - "Subject\0[ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" - "Date\0Sun, 20 Dec 2015 11:05:55 -0800\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "Subject\0Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" + "Date\0Sun, 20 Dec 2015 19:05:55 +0000\0" + "To\0Julia Lawall <julia.lawall@lip6.fr>\0" + "Cc\0Dan Carpenter <dan.carpenter@oracle.com>" + QCA ath9k Development <ath9k-devel@qca.qualcomm.com> + Martin Blumenstingl <martin.blumenstingl@googlemail.com> + Kalle Valo <kvalo@codeaurora.org> + linux-wireless@vger.kernel.org + ath9k-devel@venema.h4ckr.net + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote:\n" @@ -12,17 +19,22 @@ "> \n" "> > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote:\n" "> > > There is a type bug so it always returns success.\n" - "> >?\n" + "> >\302\240\n" "> > How many false positives do you have to sift\n" "> > through to find this sort of error?\n" "> \n" - "> The return type is thoughtfully bool, so it should be easy in this case.??\n" - "> The function has a return -EINVAL and a return true, so even without the?\n" + "> The return type is thoughtfully bool, so it should be easy in this case.\302\240\302\240\n" + "> The function has a return -EINVAL and a return true, so even without the\302\240\n" "> return type it would be locally apparent that there is an inconsistency.\n" "\n" "True, -EINVAL is a non-bool constant, but\n" "bool returns can be a variable int.\n" "\n" - Dan, was the check any constant non-bool? + "Dan, was the check any constant non-bool?\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -ceb4eb546e7ce3fd12f6c3cd452c89960093d2c44203c4f3d1fe99346a53ee69 +5812814f056697464a916834e6fd3da880f6a3d4fa17b2ac5d00c3bc58402afd
diff --git a/a/1.txt b/N2/1.txt index e42f0e3..d286d98 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,12 +3,12 @@ On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > There is a type bug so it always returns success. -> >? +> > > > How many false positives do you have to sift > > through to find this sort of error? > -> The return type is thoughtfully bool, so it should be easy in this case.?? -> The function has a return -EINVAL and a return true, so even without the? +> The return type is thoughtfully bool, so it should be easy in this case. +> The function has a return -EINVAL and a return true, so even without the > return type it would be locally apparent that there is an inconsistency. True, -EINVAL is a non-bool constant, but diff --git a/a/content_digest b/N2/content_digest index f05974f..e44e56f 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,9 +2,16 @@ "ref\01450637228.3430.30.camel@perches.com\0" "ref\0alpine.DEB.2.02.1512201959090.2055@localhost6.localdomain6\0" "From\0Joe Perches <joe@perches.com>\0" - "Subject\0[ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" + "Subject\0Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()\0" "Date\0Sun, 20 Dec 2015 11:05:55 -0800\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Julia Lawall <julia.lawall@lip6.fr>\0" + "Cc\0Dan Carpenter <dan.carpenter@oracle.com>" + QCA ath9k Development <ath9k-devel@qca.qualcomm.com> + Martin Blumenstingl <martin.blumenstingl@googlemail.com> + Kalle Valo <kvalo@codeaurora.org> + linux-wireless@vger.kernel.org + ath9k-devel@venema.h4ckr.net + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote:\n" @@ -12,12 +19,12 @@ "> \n" "> > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote:\n" "> > > There is a type bug so it always returns success.\n" - "> >?\n" + "> >\302\240\n" "> > How many false positives do you have to sift\n" "> > through to find this sort of error?\n" "> \n" - "> The return type is thoughtfully bool, so it should be easy in this case.??\n" - "> The function has a return -EINVAL and a return true, so even without the?\n" + "> The return type is thoughtfully bool, so it should be easy in this case.\302\240\302\240\n" + "> The function has a return -EINVAL and a return true, so even without the\302\240\n" "> return type it would be locally apparent that there is an inconsistency.\n" "\n" "True, -EINVAL is a non-bool constant, but\n" @@ -25,4 +32,4 @@ "\n" Dan, was the check any constant non-bool? -ceb4eb546e7ce3fd12f6c3cd452c89960093d2c44203c4f3d1fe99346a53ee69 +7aea8181b4ff588ae3c6d9ad253c2b6084583549a563db30485d9da92a336ec1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.