From: Brad Campbell <bradjc5@gmail.com>
To: Varka Bhadram <varkabhadram@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
linux-wpan@vger.kernel.org
Cc: Brad Campbell <bradjc5@gmail.com>
Subject: [PATCH 1/1] ieee802154-cc2520: Check CRC
Date: Sun, 20 Dec 2015 20:15:33 -0500 [thread overview]
Message-ID: <1450660533-38184-2-git-send-email-bradjc5@gmail.com> (raw)
In-Reply-To: <1450660533-38184-1-git-send-email-bradjc5@gmail.com>
Add checking the "CRC_OK" bit at the end of incoming packets to make
sure the cc2520 driver only passes up valid packets. Because the AUTOCRC
bit in the FRMCTRL0 register is set to 1 after init, the CC2520 handles
checking the CRC of incoming packets and sets the most significant bit
of the last byte of the incoming packet to 1 if the check passed. This
patch simply checks that bit.
Signed-off-by: Brad Campbell <bradjc5@gmail.com>
---
drivers/net/ieee802154/cc2520.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index e65b605..b54edbf 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -450,6 +450,17 @@ cc2520_read_rxfifo(struct cc2520_private *priv, u8 *data, u8 len, u8 *lqi)
mutex_unlock(&priv->buffer_mutex);
+ /* If we are reading the actual packet and not just the length byte,
+ * check that the CRC is valid.
+ */
+ if (len > 1) {
+ /* Most significant bit of the last byte of the data buffer
+ * is a 1 bit CRC indicator. See section 20.3.4.
+ */
+ if (data[len - 1] >> 7 == 0)
+ return -EINVAL;
+ }
+
return status;
}
--
2.6.3
next prev parent reply other threads:[~2015-12-21 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 1:15 [PATCH 0/1] ieee802154-cc2520: Check CRC Brad Campbell
2015-12-21 1:15 ` Brad Campbell [this message]
2015-12-21 11:54 ` [PATCH 1/1] " Alexander Aring
2015-12-21 12:57 ` Alexander Aring
[not found] ` <385C3987-300B-4E6F-A76A-85189A858790@gmail.com>
2015-12-21 21:48 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450660533-38184-2-git-send-email-bradjc5@gmail.com \
--to=bradjc5@gmail.com \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.