From: Oliver Neukum <oneukum@suse.de>
To: Hayes Wang <hayeswang@realtek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled
Date: Wed, 23 Dec 2015 09:20:13 +0100 [thread overview]
Message-ID: <1450858813.6437.2.camel@suse.de> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2F94FFF@RTITMBSV03.realtek.com.tw>
On Wed, 2015-12-23 at 03:31 +0000, Hayes Wang wrote:
> Oliver Neukum [mailto:oneukum@suse.com]
> [...]
> > It is clear to me that you cannot get away with using the same operation
> > for resume() and reset_resume() in your driver. It is fundamentally
> > impossible. Firmware cannot fix it.
>
> I would think how to fix it.
>
> > Sorry for the length of the explanation.
>
> Thanks for your response. I have some questions. What are the flows when
> the system resume follows a system suspend which follows a autosuspend?
> Are they as following?
>
> 1. suspend() with PMSG_IS_AUTO for autosuspned.
> 2. suspend() for system suspend.
> 3. resume() for system resume.
>
> And, should the device exist autosuspend before (2)?
No, step (2) does not exist. Calls to suspend() and [reset_]resume()
always balance. Usually a driver shouldn't care about system suspend.
The way the driver is currently coded will also fail for Port-Power Off.
Regards
Oliver
next prev parent reply other threads:[~2015-12-23 8:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 11:17 [PATCH v2] r8152: fix lockup when runtime PM is enabled Peter Wu
2015-12-08 12:39 ` Hayes Wang
2015-12-08 14:33 ` Peter Wu
2015-12-15 11:32 ` Oliver Neukum
2015-12-22 9:48 ` Hayes Wang
2015-12-22 11:01 ` Oliver Neukum
2015-12-23 3:31 ` Hayes Wang
2015-12-23 3:31 ` Hayes Wang
2015-12-23 8:20 ` Oliver Neukum [this message]
2015-12-23 9:20 ` Hayes Wang
2015-12-23 9:20 ` Hayes Wang
2015-12-23 10:45 ` Oliver Neukum
2015-12-23 11:15 ` Hayes Wang
2015-12-23 11:15 ` Hayes Wang
2015-12-24 1:32 ` Alan Stern
2015-12-24 7:14 ` Oliver Neukum
2015-12-24 15:14 ` Alan Stern
2015-12-24 15:47 ` Oliver Neukum
2015-12-24 16:08 ` Alan Stern
2015-12-09 3:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450858813.6437.2.camel@suse.de \
--to=oneukum@suse.de \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.