diff for duplicates of <1450868046.3316.11.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 18b8953..78723d3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Wed, 2015-12-23 at 14:46 +0800, zyjzyj2000 at gmail.com wrote: +On Wed, 2015-12-23 at 14:46 +0800, zyjzyj2000@gmail.com wrote: > From: Zhu Yanjun <zyjzyj2000@gmail.com> > > In X540 NIC, there is a time span between reporting "link on" and @@ -17,9 +17,9 @@ On Wed, 2015-12-23 at 14:46 +0800, zyjzyj2000 at gmail.com wrote: > > Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com> > --- -> ?drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |???16 +> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 > +++++++++++++++- -> ?1 file changed, 15 insertions(+), 1 deletion(-) +> 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -28,44 +28,37 @@ On Wed, 2015-12-23 at 14:46 +0800, zyjzyj2000 at gmail.com wrote: > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > @@ -6479,7 +6479,21 @@ static void ixgbe_watchdog_link_is_up(struct > ixgbe_adapter *adapter) -> ? ???????(flow_rx ? "RX" : -> ? ???????(flow_tx ? "TX" : "None")))); -> ? +> (flow_rx ? "RX" : +> (flow_tx ? "TX" : "None")))); +> > - netif_carrier_on(netdev); > + /* -> + ?* In X540 NIC, there is a time span between reporting "link +> + * In X540 NIC, there is a time span between reporting "link > on" -> + ?* and getting the speed and duplex. To a bonding driver in +> + * and getting the speed and duplex. To a bonding driver in > 802.3ad -> + ?* mode, this time span will make it not work well if the +> + * mode, this time span will make it not work well if the > time span -> + ?* is big enough. To 82599_SFP NIC and other kinds of NICs, +> + * is big enough. To 82599_SFP NIC and other kinds of NICs, > this -> + ?* problem does not exist. As such, it is better for X540 to +> + * problem does not exist. As such, it is better for X540 to > report -> + ?* "link on" when the link speed is not +> + * "link on" when the link speed is not > IXGBE_LINK_SPEED_UNKNOWN. -> + ?*/ +> + */ > + if ((hw->mac.type == ixgbe_mac_X540) && -> + ????(link_speed != IXGBE_LINK_SPEED_UNKNOWN)) { +> + (link_speed != IXGBE_LINK_SPEED_UNKNOWN)) { > + netif_carrier_on(netdev); > + } else { > + netif_carrier_on(netdev); > + } > + -> ? ixgbe_check_vf_rate_limit(adapter); -> ? -> ? /* enable transmits */ +> ixgbe_check_vf_rate_limit(adapter); +> +> /* enable transmits */ This patch only adds a needless test before -calling?netif_carrier_on(netdev), since the call happens no matter the -branch you take, it appears your running into a timing issue. ?So -adding a wait() before calling?netif_carrier_on(netdev) will accomplish +calling netif_carrier_on(netdev), since the call happens no matter the +branch you take, it appears your running into a timing issue. So +adding a wait() before calling netif_carrier_on(netdev) will accomplish the same result and you do not have to add a useless test. --------------- next part -------------- -A non-text attachment was scrubbed... -Name: signature.asc -Type: application/pgp-signature -Size: 819 bytes -Desc: This is a digitally signed message part -URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151223/f955f020/attachment.asc> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..5e51a75 --- /dev/null +++ b/N1/2.bin @@ -0,0 +1,17 @@ +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iQIcBAABCgAGBQJWen1OAAoJEOVv75VaS+3OSwMP/1MUTI1RtWCuSZRN6daLgyc9 +p7aejfgq+ta/mcmA5bjlyu1kJecyZXGdyHGK6Z78Dc5s2rnh4CyYnfg3QyDaxZrB +7Hskg2ujgkTuw5v9MGcpYYwzx1HwtvF05ZDsFVOJX7ngca7L4a1ojx2wJku/CLkA +vqIMuhAy8TlaeNA8EW3Rs5OnWeWR4Xptv4UYzfuedd1sKodWVcNG+j+LE7Z0a3Pv +qwzczpqovKpzxgMxzbuexbfZeMGHOpdXIs0oYcPWEITQv5vTPTDpm6VOKBvkRre8 +XUxWyBN+y6F8hKai3ewCaY/O1DSrx9ih7Vg1NgIbi+ocDaTJvdfhlvgj9WXGlLl/ +z4cjaUEEGi2DVclv2D1I6aVminIJCc7tWjjkNuHz9V/w4IGejaVpAJ0pnGefaRHN +mOAeTKiQj2RebBp8zr4Nqe7uGAn4BH+FPiwWIN999LgVaDwv3JLmJ/UHCa7bBkNN +0Ev1tdCrjBF+LqGcaCHHJoo2HotQP4KCq2ZyXuUph166RZ+X/CLppnNquTHJmvza +lcM28OaU1zYosU8ZkC+GDr1jgEVasf3mgUP2/ejYnnyM92S3eF9++eU12M+WuqBL +e4Gvgku7ZzarN4Zoooc0f/sMSCY+UFISE/8ZRCEoCs4ybcVctL9p6FzUakMHnKph +EAUw6V0Qe/ozucifBpWf +=vBdS +-----END PGP SIGNATURE----- diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..da6d245 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: This is a digitally signed message part +Content-Transfer-Encoding: 7bit diff --git a/a/content_digest b/N1/content_digest index 03a544e..e78fad6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,11 +1,24 @@ "ref\01450853205-27133-1-git-send-email-zyjzyj2000@gmail.com\0" "From\0Jeff Kirsher <jeffrey.t.kirsher@intel.com>\0" - "Subject\0[Intel-wired-lan] [PATCH 1/1] ixgbe: force to synchronize reporting \"link on\" and getting speed and duplex\0" + "Subject\0Re: [PATCH 1/1] ixgbe: force to synchronize reporting \"link on\" and getting speed and duplex\0" "Date\0Wed, 23 Dec 2015 02:54:06 -0800\0" - "To\0intel-wired-lan@osuosl.org\0" - "\00:1\0" + "To\0zyjzyj2000@gmail.com" + jesse.brandeburg@intel.com + shannon.nelson@intel.com + carolyn.wyborny@intel.com + donald.c.skidmore@intel.com + bruce.w.allan@intel.com + john.ronciak@intel.com + mitch.a.williams@intel.com + intel-wired-lan@lists.osuosl.org + netdev@vger.kernel.org + " e1000-devel@lists.sourceforge.net\0" + "Cc\0venkat.viswanathan@windriver.com" + Boris.Shteinbock@windriver.com + " Vincent.Bourg@windriver.com\0" + "\01:1\0" "b\0" - "On Wed, 2015-12-23 at 14:46 +0800, zyjzyj2000 at gmail.com wrote:\n" + "On Wed, 2015-12-23 at 14:46 +0800, zyjzyj2000@gmail.com wrote:\n" "> From: Zhu Yanjun <zyjzyj2000@gmail.com>\n" "> \n" "> In X540 NIC, there is a time span between reporting \"link on\" and\n" @@ -24,9 +37,9 @@ "> \n" "> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>\n" "> ---\n" - "> ?drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |???16\n" + "> \302\240drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |\302\240\302\240\302\24016\n" "> +++++++++++++++-\n" - "> ?1 file changed, 15 insertions(+), 1 deletion(-)\n" + "> \302\2401 file changed, 15 insertions(+), 1 deletion(-)\n" "> \n" "> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n" "> b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n" @@ -35,46 +48,60 @@ "> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n" "> @@ -6479,7 +6479,21 @@ static void ixgbe_watchdog_link_is_up(struct\n" "> ixgbe_adapter *adapter)\n" - "> ?\t???????(flow_rx ? \"RX\" :\n" - "> ?\t???????(flow_tx ? \"TX\" : \"None\"))));\n" - "> ?\n" + "> \302\240\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240(flow_rx ? \"RX\" :\n" + "> \302\240\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240(flow_tx ? \"TX\" : \"None\"))));\n" + "> \302\240\n" "> -\tnetif_carrier_on(netdev);\n" "> +\t/*\n" - "> +\t?* In X540 NIC, there is a time span between reporting \"link\n" + "> +\t\302\240* In X540 NIC, there is a time span between reporting \"link\n" "> on\"\n" - "> +\t?* and getting the speed and duplex. To a bonding driver in\n" + "> +\t\302\240* and getting the speed and duplex. To a bonding driver in\n" "> 802.3ad\n" - "> +\t?* mode, this time span will make it not work well if the\n" + "> +\t\302\240* mode, this time span will make it not work well if the\n" "> time span\n" - "> +\t?* is big enough. To 82599_SFP NIC and other kinds of NICs,\n" + "> +\t\302\240* is big enough. To 82599_SFP NIC and other kinds of NICs,\n" "> this\n" - "> +\t?* problem does not exist. As such, it is better for X540 to\n" + "> +\t\302\240* problem does not exist. As such, it is better for X540 to\n" "> report\n" - "> +\t?* \"link on\" when the link speed is not\n" + "> +\t\302\240* \"link on\" when the link speed is not\n" "> IXGBE_LINK_SPEED_UNKNOWN.\n" - "> +\t?*/\n" + "> +\t\302\240*/\n" "> +\tif ((hw->mac.type == ixgbe_mac_X540) &&\n" - "> +\t????(link_speed != IXGBE_LINK_SPEED_UNKNOWN)) {\n" + "> +\t\302\240\302\240\302\240\302\240(link_speed != IXGBE_LINK_SPEED_UNKNOWN)) {\n" "> +\t\tnetif_carrier_on(netdev);\n" "> +\t} else {\n" "> +\t\tnetif_carrier_on(netdev);\n" "> +\t}\n" "> +\n" - "> ?\tixgbe_check_vf_rate_limit(adapter);\n" - "> ?\n" - "> ?\t/* enable transmits */\n" + "> \302\240\tixgbe_check_vf_rate_limit(adapter);\n" + "> \302\240\n" + "> \302\240\t/* enable transmits */\n" "\n" "This patch only adds a needless test before\n" - "calling?netif_carrier_on(netdev), since the call happens no matter the\n" - "branch you take, it appears your running into a timing issue. ?So\n" - "adding a wait() before calling?netif_carrier_on(netdev) will accomplish\n" - "the same result and you do not have to add a useless test.\n" - "-------------- next part --------------\n" - "A non-text attachment was scrubbed...\n" - "Name: signature.asc\n" - "Type: application/pgp-signature\n" - "Size: 819 bytes\n" - "Desc: This is a digitally signed message part\n" - URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151223/f955f020/attachment.asc> + "calling\302\240netif_carrier_on(netdev), since the call happens no matter the\n" + "branch you take, it appears your running into a timing issue. \302\240So\n" + "adding a wait() before calling\302\240netif_carrier_on(netdev) will accomplish\n" + the same result and you do not have to add a useless test. + "\01:2\0" + "fn\0signature.asc\0" + "d\0This is a digitally signed message part\0" + "b\0" + "-----BEGIN PGP SIGNATURE-----\n" + "Version: GnuPG v1\n" + "\n" + "iQIcBAABCgAGBQJWen1OAAoJEOVv75VaS+3OSwMP/1MUTI1RtWCuSZRN6daLgyc9\n" + "p7aejfgq+ta/mcmA5bjlyu1kJecyZXGdyHGK6Z78Dc5s2rnh4CyYnfg3QyDaxZrB\n" + "7Hskg2ujgkTuw5v9MGcpYYwzx1HwtvF05ZDsFVOJX7ngca7L4a1ojx2wJku/CLkA\n" + "vqIMuhAy8TlaeNA8EW3Rs5OnWeWR4Xptv4UYzfuedd1sKodWVcNG+j+LE7Z0a3Pv\n" + "qwzczpqovKpzxgMxzbuexbfZeMGHOpdXIs0oYcPWEITQv5vTPTDpm6VOKBvkRre8\n" + "XUxWyBN+y6F8hKai3ewCaY/O1DSrx9ih7Vg1NgIbi+ocDaTJvdfhlvgj9WXGlLl/\n" + "z4cjaUEEGi2DVclv2D1I6aVminIJCc7tWjjkNuHz9V/w4IGejaVpAJ0pnGefaRHN\n" + "mOAeTKiQj2RebBp8zr4Nqe7uGAn4BH+FPiwWIN999LgVaDwv3JLmJ/UHCa7bBkNN\n" + "0Ev1tdCrjBF+LqGcaCHHJoo2HotQP4KCq2ZyXuUph166RZ+X/CLppnNquTHJmvza\n" + "lcM28OaU1zYosU8ZkC+GDr1jgEVasf3mgUP2/ejYnnyM92S3eF9++eU12M+WuqBL\n" + "e4Gvgku7ZzarN4Zoooc0f/sMSCY+UFISE/8ZRCEoCs4ybcVctL9p6FzUakMHnKph\n" + "EAUw6V0Qe/ozucifBpWf\n" + "=vBdS\n" + "-----END PGP SIGNATURE-----\n" -38868a575fc3dfcda7ec2176bb872eb63012f0f944305382dba5e8c9b6dc4571 +10a234eb454316145a5b2b1533ff79db99f5d2c2850dd7227780889d2d9fd820
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.