From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com. [2a00:1450:4010:c04::22e]) by gmr-mx.google.com with ESMTPS id ea7si1113203lbc.0.2015.12.24.03.07.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Dec 2015 03:07:50 -0800 (PST) Received: by mail-lb0-x22e.google.com with SMTP id sv6so52191527lbb.0 for ; Thu, 24 Dec 2015 03:07:50 -0800 (PST) Message-ID: <1450955268.15911.85.camel@gmail.com> Subject: [rtc-linux] Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x From: Sergei Ianovich To: Alexandre Belloni , Rob Herring Cc: "linux-kernel@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" Date: Thu, 24 Dec 2015 14:07:48 +0300 In-Reply-To: <20151224110453.GJ8623@piout.net> References: <397668667-27328-3-git-send-email-ynvich@gmail.com> <1450201525-9137-1-git-send-email-ynvich@gmail.com> <20151220033815.GD9883@rob-hp-laptop> <1450613656.15911.62.camel@gmail.com> <20151224110453.GJ8623@piout.net> Content-Type: text/plain; charset=UTF-8 Mime-Version: 1.0 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Thu, 2015-12-24 at 12:04 +0100, Alexandre Belloni wrote: > On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote : > > Well, the binding should reflect that, whether the driver needs to > > be > > re-written is somewhat a separate question. That should probably > > have > > been done for the DS1302 driver originally and it is not too fair > > for > > the 2nd person to fix it. You could just have a single driver bound > > to > > the controller node which is aware of the DS1302 being the slave > > device (ignoring that part of the DT for now). > > > > I agree with Rob here. I won't require that you fix the driver but it > would be better to have a proper DT binding from the beginning so that > when the driver is fixed it will still work with the previous device > trees. No problem. I'll fix the driver. That's how it should be done. What should be done with SECUREEDGE support? -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Ianovich Subject: Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Date: Thu, 24 Dec 2015 14:07:48 +0300 Message-ID: <1450955268.15911.85.camel@gmail.com> References: <397668667-27328-3-git-send-email-ynvich@gmail.com> <1450201525-9137-1-git-send-email-ynvich@gmail.com> <20151220033815.GD9883@rob-hp-laptop> <1450613656.15911.62.camel@gmail.com> <20151224110453.GJ8623@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151224110453.GJ8623@piout.net> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni , Rob Herring Cc: "linux-kernel@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" List-Id: devicetree@vger.kernel.org On Thu, 2015-12-24 at 12:04 +0100, Alexandre Belloni wrote: > On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote : > > Well, the binding should reflect that, whether the driver needs to > > be > > re-written is somewhat a separate question. That should probably > > have > > been done for the DS1302 driver originally and it is not too fair > > for > > the 2nd person to fix it. You could just have a single driver bound > > to > > the controller node which is aware of the DS1302 being the slave > > device (ignoring that part of the DT for now). > > > > I agree with Rob here. I won't require that you fix the driver but it > would be better to have a proper DT binding from the beginning so that > when the driver is fixed it will still work with the previous device > trees. No problem. I'll fix the driver. That's how it should be done. What should be done with SECUREEDGE support?