From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp Date: Sat, 02 Jan 2016 23:54:28 -0800 Message-ID: <1451807668.4334.38.camel@perches.com> References: <20160103050501.042035135@telegraphics.com.au> <20160103050520.752909053@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160103050520.752909053@telegraphics.com.au> Sender: linux-scsi-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-m68k@vger.kernel.org On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > Hanging indentation was a poor choice for the text inside comments. I= t > has been used in the wrong places and done badly elsewhere. There is > little consistency within any file. One fork of the core driver uses > tabs for this indentation while the other uses spaces. Better to use > flush-left alignment throughout. >=20 > This patch is the result of the following substitution. It replaces t= abs > and spaces at the start of a comment line with a single space. >=20 > perl -i -pe 's,^(\t*[/ ]\*)[ \t]+,$1 ,' drivers/scsi/{atari_,}NCR5380= =2Ec=A0 >=20 > This removes some unimportant discrepancies between the two core driv= er > forks so that the important ones become obvious, to facilitate > reunification. I still think this patch is poor at best and overall not useful. @@ -32,15 +32,15 @@ > =A0/* > =A0 * Further development / testing that should be done : > =A0 * 1.=A0=A0Cleanup the NCR5380_transfer_dma function and DMA opera= tion complete > - *=A0=A0=A0=A0=A0code so that everything does the same thing that's = done at the > - *=A0=A0=A0=A0=A0end of a pseudo-DMA read operation. > + * code so that everything does the same thing that's done at the > + * end of a pseudo-DMA read operation. > =A0 * > =A0 * 2.=A0=A0Fix REAL_DMA (interrupt driven, polled works fine) - > - *=A0=A0=A0=A0=A0basically, transfer size needs to be reduced by one > - *=A0=A0=A0=A0=A0and the last byte read as is done with PSEUDO_DMA. > + * basically, transfer size needs to be reduced by one > + * and the last byte read as is done with PSEUDO_DMA. > =A0 * > =A0 * 4.=A0=A0Test SCSI-II tagged queueing (I have no devices which s= upport > - *=A0=A0=A0=A0=A0=A0tagged queueing) > + * tagged queueing) Numbering 1, 2, then 4 could be improved. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbcACHyd (ORCPT ); Sun, 3 Jan 2016 02:54:33 -0500 Received: from smtprelay0234.hostedemail.com ([216.40.44.234]:52302 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751016AbcACHyc (ORCPT ); Sun, 3 Jan 2016 02:54:32 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2197:2198:2199:2200:2201:2393:2559:2562:2828:2904:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:4823:5007:6261:7903:8603:9108:10004:10400:10848:11232:11658:11783:11914:12043:12048:12296:12438:12517:12519:12740:13069:13311:13357:13894:14659:21080:21221:30012:30054:30055:30056:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: tent74_617068d570c53 X-Filterd-Recvd-Size: 2752 Message-ID: <1451807668.4334.38.camel@perches.com> Subject: Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp From: Joe Perches To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 02 Jan 2016 23:54:28 -0800 In-Reply-To: <20160103050520.752909053@telegraphics.com.au> References: <20160103050501.042035135@telegraphics.com.au> <20160103050520.752909053@telegraphics.com.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > Hanging indentation was a poor choice for the text inside comments. It > has been used in the wrong places and done badly elsewhere. There is > little consistency within any file. One fork of the core driver uses > tabs for this indentation while the other uses spaces. Better to use > flush-left alignment throughout. > > This patch is the result of the following substitution. It replaces tabs > and spaces at the start of a comment line with a single space. > > perl -i -pe 's,^(\t*[/ ]\*)[ \t]+,$1 ,' drivers/scsi/{atari_,}NCR5380.c  > > This removes some unimportant discrepancies between the two core driver > forks so that the important ones become obvious, to facilitate > reunification. I still think this patch is poor at best and overall not useful. @@ -32,15 +32,15 @@ >  /* >   * Further development / testing that should be done : >   * 1.  Cleanup the NCR5380_transfer_dma function and DMA operation complete > - *     code so that everything does the same thing that's done at the > - *     end of a pseudo-DMA read operation. > + * code so that everything does the same thing that's done at the > + * end of a pseudo-DMA read operation. >   * >   * 2.  Fix REAL_DMA (interrupt driven, polled works fine) - > - *     basically, transfer size needs to be reduced by one > - *     and the last byte read as is done with PSEUDO_DMA. > + * basically, transfer size needs to be reduced by one > + * and the last byte read as is done with PSEUDO_DMA. >   * >   * 4.  Test SCSI-II tagged queueing (I have no devices which support > - *      tagged queueing) > + * tagged queueing) Numbering 1, 2, then 4 could be improved.