From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: adrian.hunter@intel.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ubifs: Fix error codes in ubifs_iget()
Date: Sun, 03 Jan 2016 15:51:32 +0200 [thread overview]
Message-ID: <1451829092.13942.4.camel@gmail.com> (raw)
In-Reply-To: <1451772666-2139-1-git-send-email-richard@nod.at>
On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
> We cannot use positive error codes in ERR_PTR().
> IS_ERR() won't catch them.
Right, but why there is a "err = -EINVAL;" when at 'out_invalid'.
> Cc: stable@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
I do not see a bug, but I see a removal of a useful code which lets you
understand what verification failed. Do I miss something?
next prev parent reply other threads:[~2016-01-03 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 22:11 [PATCH] ubifs: Fix error codes in ubifs_iget() Richard Weinberger
2016-01-03 13:51 ` Artem Bityutskiy [this message]
2016-01-03 13:54 ` Artem Bityutskiy
2016-01-03 13:56 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451829092.13942.4.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.