All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "net: phy: delay only if reset handler is registered"
Date: Mon, 04 Jan 2016 13:49:43 +0100	[thread overview]
Message-ID: <1451911783.18759.4.camel@embedded.rocks> (raw)
In-Reply-To: <CAOMZO5CHgLm-HbDV6sEFkVyuaYd1=rVt8Z9naHW8ON_WCfwBHg@mail.gmail.com>

Hi Fabio,

On Mi, 2015-12-23 at 13:42 -0200, Fabio Estevam wrote:
> Hi J?rg,
> 
> On Mon, Nov 23, 2015 at 4:16 PM, Fabio Estevam <festevam@gmail.com>
> wrote:
> > Hi J?rg ,
> > 
> > On Fri, Nov 20, 2015 at 6:37 PM, Fabio Estevam <festevam@gmail.com>
> > wrote:
> > 
> > > Ok, I will test your proposal below on Monday when I get access
> > > to my
> > > mx6sxsabresd, thanks.
> > 
> > Your proposal worked fine, thanks. Will send it as a formal patch.
> 
> Ethernet on mx6cuboxi is also broken because of
> 59370f3fcd13508
> (""net: phy: delay only if reset handler is registered").
> 
> I tried doing:
> 
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -143,7 +143,7 @@ static void setup_iomux_enet(void)
> ????????SETUP_IOMUX_PADS(enet_pads);
> 
> ????????gpio_direction_output(ETH_PHY_RESET, 0);
> -???????mdelay(2);
> +???????mdelay(10);
> ????????gpio_set_value(ETH_PHY_RESET, 1);
> ?}
> 
> ,but it did not help.
> 
> Any suggestions?

Sorry for the long delay due to christmas vacation.


Do you know which PHY is used on?mx6cuboxi?

I am wondering if the ANATOP clock setting is correct (25MHz)?

http://git.denx.de/?p=u-boot.git;a=blob;f=board/solidrun/mx6cuboxi/mx6c
uboxi.c;h=fc37f1eef06da5147e5403d4272d220836c9cfbc;hb=HEAD#l167

Does it help to increase the delay and set it to 15ms?

Best regards
J?rg Krause

  parent reply	other threads:[~2016-01-04 12:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17 16:25 [U-Boot] [PATCH] Revert "net: phy: delay only if reset handler is registered" Fabio Estevam
2015-11-18  5:54 ` Stefan Roese
2015-11-18 11:30   ` Fabio Estevam
2015-11-18  8:44 ` Jörg Krause
2015-11-18 11:34   ` Fabio Estevam
2015-11-19  8:13     ` Jörg Krause
2015-11-20 20:37       ` Fabio Estevam
2015-11-23 18:16         ` Fabio Estevam
2015-11-23 20:08           ` Jörg Krause
2015-12-23 15:42           ` Fabio Estevam
2016-01-04 11:19             ` Fabio Estevam
2016-01-04 12:49             ` Jörg Krause [this message]
2016-01-04 12:57               ` Fabio Estevam
2016-01-04 13:48                 ` Jörg Krause
2016-01-04 14:24                   ` Fabio Estevam
2016-01-04 18:35                     ` Joe Hershberger
2016-01-04 18:37                       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451911783.18759.4.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.