Re: [xen-4.4-testing test] 66583: regressions - FAIL

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2016-01-04 at 15:15 +0000, Ian Campbell wrote:
> On Mon, 2016-01-04 at 15:03 +0000, Ian Campbell wrote:
> > On Mon, 2016-01-04 at 14:54 +0000, Ian Jackson wrote:
> > > Ian Campbell writes ("Re: [Xen-devel] [xen-4.4-testing test] 66583:
> > > regressions - FAIL"):
> > > > I think we want to backport:
> > > > 
> > > > commit 345e44a85d71a1a910385f33c7f1ba3683026d18
> > > > Author: Dario Faggioli <dario.faggioli@citrix.com>
> > > > Date:   Fri Jun 20 16:09:00 2014 +0200
> > > 
> > > This is already in stable-4.4, as 5e39eb05, and has been since June.
> > 
> > This failure is in build-*-prev, i.e. the backport needs to be to 4.3
> > (and
> > presumably earlier). Sorry for not making that clear.
> > 
> > But it is already there as c591613f8c62, also from June.
> > 
> > So now I am rather perplexed by the build failures, which look
> > identical
> > to
> > the ones in the commit message, modulo some line number skew.
> > 
> > http://logs.test-lab.xenproject.org/osstest/logs/66583/build-amd64-
> > prev/5.ts-xen-build.log
> 
> FYI (and obviously) this also happened to the proper build jobs in 66638
> which was a xen-4.3-testing flight. It was building 0574a773238f and:
> 
> $ git diff 0574a773238f origin/staging -- tools/blktap2/drivers/block-
> qcow.c
> $
> 
> Where origin/staging is 8e4d18e113c9 and flight 67053 built that just
> fine.
> 
> So, wtf...

Aha, this failure is in tools/blktap/drivers/block-qcow.c and not
tools/blktap2/drivers/block-qcow.c. 

345e44a85d71 was writing after blktap1 was remove from the tree so
backporting it wouldn't have helped.

    $ git show 345e44a85d71a | patch tools/blktap/drivers/block-qcow.c
    patching file tools/blktap/drivers/block-qcow.c
    Hunk #1 succeeded at 440 (offset 13 lines).
    Hunk #2 succeeded at 614 (offset 13 lines).
    $ 

Seems like the way to go for all branches which still have blktap1 (4.5 and
back, although it was disabled by default in 76c66c689b85 which was in
4.4.0-rc1.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel