From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 3E622731C4 for ; Mon, 4 Jan 2016 17:32:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u04HWpqX011553 for ; Mon, 4 Jan 2016 17:32:51 GMT Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7Ovz-b2wfgrg for ; Mon, 4 Jan 2016 17:32:51 +0000 (GMT) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u04HWj75011550 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 4 Jan 2016 17:32:46 GMT Message-ID: <1451928765.7598.14.camel@linuxfoundation.org> From: Richard Purdie To: bitbake-devel Date: Mon, 04 Jan 2016 17:32:45 +0000 X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Subject: [PATCH] cooker: Drop useless parsing exception X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2016 17:32:51 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit The SyntaxError exception simply shows the recipe that failed to parse which is pretty useless without the actual exception. We could make it print more info, however we can just use one of the more generic handlers instead and remove this one. For a python indentation error, this leads to a much more readable error message. Signed-off-by: Richard Purdie diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index 4df8881..5ceb198 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py @@ -2125,11 +2125,6 @@ class CookerParser(object): logger.error('ExpansionError during parsing %s: %s', value.recipe, str(exc)) self.shutdown(clean=False) return False - except SyntaxError as exc: - self.error += 1 - logger.error('Unable to parse %s', exc.recipe) - self.shutdown(clean=False) - return False except Exception as exc: self.error += 1 etype, value, tb = sys.exc_info()