From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Mathieu OTHACEHE <m.othacehe@gmail.com>
Subject: [PATCH v2 3/4] USB: mxu11x0: remove duplicated set_termios call
Date: Mon, 4 Jan 2016 19:49:38 +0100 [thread overview]
Message-ID: <1451933379-21994-4-git-send-email-m.othacehe@gmail.com> (raw)
In-Reply-To: <1451933379-21994-1-git-send-email-m.othacehe@gmail.com>
The function mxu1_set_termios is called twice in open callback.
Only the first call is necessary.
Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
---
drivers/usb/serial/mxu11x0.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index 7ad2727..6326cda 100644
--- a/drivers/usb/serial/mxu11x0.c
+++ b/drivers/usb/serial/mxu11x0.c
@@ -830,9 +830,6 @@ static int mxu1_open(struct tty_struct *tty, struct usb_serial_port *port)
usb_clear_halt(serial->dev, port->write_urb->pipe);
usb_clear_halt(serial->dev, port->read_urb->pipe);
- if (tty)
- mxu1_set_termios(tty, port, NULL);
-
status = usb_serial_generic_open(tty, port);
if (status)
goto unlink_int_urb;
--
2.6.4
next prev parent reply other threads:[~2016-01-04 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 18:49 [PATCH v2 0/4] USB: mxu11x0: fixes and follow ups Mathieu OTHACEHE
2016-01-04 18:49 ` [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data Mathieu OTHACEHE
2016-01-25 12:01 ` Johan Hovold
2016-01-30 17:40 ` Mathieu OTHACEHE
2016-02-28 12:20 ` Johan Hovold
2016-02-28 16:30 ` Mathieu OTHACEHE
2016-02-29 9:38 ` Johan Hovold
2016-01-04 18:49 ` [PATCH v2 2/4] USB: mxu11x0: clean device control commands Mathieu OTHACEHE
2016-01-04 18:49 ` Mathieu OTHACEHE [this message]
2016-01-04 18:49 ` [PATCH v2 4/4] USB: mxu11x0: move firmware download and endpoint testing to probe callback Mathieu OTHACEHE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451933379-21994-4-git-send-email-m.othacehe@gmail.com \
--to=m.othacehe@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.