All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: david1.zhou@amd.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/ttm: zero allocation only for CPU domain
Date: Tue, 05 Jan 2016 15:32:15 +0100	[thread overview]
Message-ID: <1452004335.6048.8.camel@lynxeye.de> (raw)
In-Reply-To: <1451966143-27368-1-git-send-email-david1.zhou@amd.com>

Hi David,

why is this patch 2/4 if it's just a single patch?

Am Dienstag, den 05.01.2016, 11:55 +0800 schrieb david1.zhou@amd.com:
> From: Chunming Zhou <David1.Zhou@amd.com>
> 
> Change-Id: I653d61e32faaa11c39bb978bf90301513a0c35b8

This change-id is just pure noise when you submit something upstream.

Please add a proper change log on why the change below is
necessary/helpful.

Regards,
Lucas

> Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
> ---
>  drivers/gpu/drm/ttm/ttm_bo.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
> b/drivers/gpu/drm/ttm/ttm_bo.c
> index 745e996..0633b65 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -301,6 +301,7 @@ static int ttm_bo_handle_move_mem(struct
> ttm_buffer_object *bo,
>  	if (!(new_man->flags & TTM_MEMTYPE_FLAG_FIXED)) {
>  		if (bo->ttm == NULL) {
>  			bool zero = !(old_man->flags &
> TTM_MEMTYPE_FLAG_FIXED);
> +			zero = (mem->mem_type == TTM_PL_SYSTEM) ?
> zero : false;
>  			ret = ttm_bo_add_ttm(bo, zero);
>  			if (ret)
>  				goto out_err;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-01-05 14:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  3:55 [PATCH 2/4] drm/ttm: zero allocation only for CPU domain david1.zhou
2016-01-05 14:32 ` Lucas Stach [this message]
2016-01-06  6:44   ` zhoucm1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452004335.6048.8.camel@lynxeye.de \
    --to=dev@lynxeye.de \
    --cc=david1.zhou@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.