From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools: allow configure time choice of libexec subdirectory. Date: Tue, 5 Jan 2016 14:52:27 +0000 Message-ID: <1452005547.13361.298.camel@citrix.com> References: <1450278395-23639-1-git-send-email-ian.campbell@citrix.com> <1450280017.4053.61.camel@citrix.com> <22154.42262.126829.326566@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22154.42262.126829.326566@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: wei.liu2@citrix.com, 805508@bugs.debian.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2016-01-04 at 17:00 +0000, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH] tools: allow configure time choice of > libexec subdirectory."): > > I somehow slipped a stray ` in there and didn't notice, sorry. > > This looks like a reasonable change aside from that but we should > definitely do some build tests at commit time. Right, my pre-push scripting involves a build on all architectures and a diff of the lists of installed files, I think that would have caught any remaining issues (and didn't). > With the stray ` removed: > > Acked-by: Ian Jackson Applied, thanks (and to Doug).