Re: [PATCH XEN v7 02/29] tools: Refactor "xentoollog" into its own library

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-12-16 at 12:31 +0000, Ian Campbell wrote:
> In attempting to disaggregate libxenctrl I found that many of the
> pieces were going to want access to this library, so split it out (as
> it probably should always have been).
> 
> Various build adjustments are needed. In particular things which use
> xtl_* themselves now need to explicity link against the library.
> 
> This has a nice side effect which is that users of libxl no longer
> need to link against libxenctrl just to create a logger, which was
> counter to the principal that applications using libxl shouldn't be
> required to look behind the curtain. This means that xl no longer
> links against libxenctrl.
> 
> The new library uses a version script to ensure that only expected
> symbols are exported and to version them such that ABI guarantees can
> be kept in the future.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Must be applied with:
> 
> - "qemu-xen-traditional: Use xentoollog as a separate library" and a
>   corresponding QEMU_TAG update folded here.
> - "mini-os: Include libxentoollog with libxc" and a corresponding bump
>   to MINIOS_UPSTREAM_REVISION folded in here.
> 
> Note that this patch was applied as c7d3afbb44b4 but reverted via
> ec0712576198. See
> http://lists.xen.org/archives/html/xen-devel/2015-12/msg01153.html

The corresponding libvirt support for this change was added to libvirt.git
in 716be2570a38bc92581e31e3fec6b1ca92302c1e
Author: Ian Campbell <ian.campbell@citrix.com>
Date:   Thu Dec 10 11:38:36 2015 +0000

    libxl: Use libxentoollog in preference to libxenctrl if available.

The contents of our output libvirt push gate is now d5a0cf10 which is after
that change.

Therefore I have reapplied.

> As of v7 the QEMU_TAG and MINIOS_UPSTREAM_REVISION updates
> corresponding to that push are included in the patch (since the master
> branches of those repos has not been reverted). If those patches are
> subsequently reverted as described in the mail then git am will gripe
> about this commit.

MINIOS_UPSTREAM_REVISION was unchanged in the interim.

QEMU_TRADITION_REVISION had since progressed to 569eac99e8dd which is after
9fad9ed28583, the commit needed here so I have dropped that hunk. Note that
9fad9ed28583 turned out to be harmless even without the corresponding
xen.git change (this patch) since all it did was add until now non-existent
 path to the include path and rpath-link.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel