From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbcAESxc (ORCPT ); Tue, 5 Jan 2016 13:53:32 -0500 Received: from smtprelay0177.hostedemail.com ([216.40.44.177]:33026 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751826AbcAESx2 (ORCPT ); Tue, 5 Jan 2016 13:53:28 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1963:2393:2559:2562:2828:2911:2915:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4362:4425:5007:6261:8603:10004:10400:10848:11232:11658:11914:12043:12048:12517:12519:12740:13069:13149:13230:13311:13357:14096:14097:14659:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sign40_d5e0ec2c52e X-Filterd-Recvd-Size: 1875 Message-ID: <1452020004.4334.156.camel@perches.com> Subject: Re: [PATCH 0/5] usb-misc: cleanup sisusbvga From: Joe Perches To: Peter Senna Tschudin , thomas@winischhofer.net, gregkh@linuxfoundation.org, trivial@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 05 Jan 2016 10:53:24 -0800 In-Reply-To: <1452012850-6990-1-git-send-email-peter.senna@collabora.com> References: <1452012850-6990-1-git-send-email-peter.senna@collabora.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote: [] > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used > > $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c > > to verify that this patch do not change any visible character. If the size of > this patch is a problem, please let me know in how many patches to split it. Thanks. Maybe for future series, but not one in particular unless you feel like respinning it: As porcelain is meant for script consumption, I think a good mechanism for human review is to separate patch 1 into 2 patches. 1: Only horizontal line whitespace changes git diff -w shouldn't show any changes and git blame -w would not show any change either. 2: Only vertical line changes additions/reformatting This makes it easy to use git diff -w on patch 1 and patch 2 can be more easily scanned visually. It's also nice to use objdiff and show no object changes.