From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Liang, Kan" <kan.liang@intel.com>
Subject: [PATCH 1/3] perf tools: Fix cpu conversion in cpu_map__from_entries
Date: Wed, 6 Jan 2016 11:49:55 +0100 [thread overview]
Message-ID: <1452077397-31958-2-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1452077397-31958-1-git-send-email-jolsa@kernel.org>
We can't convert u16 cpu_map_entries::cpu[x] value directly to int,
because it could hold -1, which would be converted as 65535.
Adding special treatment for -1, which is not real cpu number,
to be converted to (int -1).
Link: http://lkml.kernel.org/n/tip-6t5lp407ca76zlikz9rl2lcm@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/util/cpumap.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
index a0717b93d8f5..fa935093a599 100644
--- a/tools/perf/util/cpumap.c
+++ b/tools/perf/util/cpumap.c
@@ -188,8 +188,17 @@ static struct cpu_map *cpu_map__from_entries(struct cpu_map_entries *cpus)
if (map) {
unsigned i;
- for (i = 0; i < cpus->nr; i++)
- map->map[i] = (int)cpus->cpu[i];
+ for (i = 0; i < cpus->nr; i++) {
+ /*
+ * Special treatment for -1, which is not real cpu number,
+ * and we need to use (int) -1 to initialize map[i],
+ * otherwise it would become 65535.
+ */
+ if (cpus->cpu[i] == (u16) -1)
+ map->map[i] = -1;
+ else
+ map->map[i] = (int) cpus->cpu[i];
+ }
}
return map;
--
2.4.3
next prev parent reply other threads:[~2016-01-06 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 10:49 [PATCHv9 0/3] perf stat: Add scripting support Jiri Olsa
2016-01-06 10:49 ` Jiri Olsa [this message]
2016-01-09 16:31 ` [tip:perf/core] perf cpumap: Fix cpu conversion in cpu_map__from_entries tip-bot for Jiri Olsa
2016-01-06 10:49 ` [PATCH 2/3] perf script: Display stat events by default Jiri Olsa
2016-01-09 16:31 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-06 10:49 ` [PATCH 3/3] perf script: Add stat-cpi.py script Jiri Olsa
2016-01-09 16:32 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-06 14:18 ` [PATCHv9 0/3] perf stat: Add scripting support Arnaldo Carvalho de Melo
2016-01-06 14:38 ` Jiri Olsa
2016-01-06 15:05 ` Arnaldo Carvalho de Melo
2016-01-06 15:39 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452077397-31958-2-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.