All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: OVMF related osstest failures on multiple branches
Date: Wed, 6 Jan 2016 15:28:30 +0000	[thread overview]
Message-ID: <1452094110.21055.81.camel@citrix.com> (raw)
In-Reply-To: <1452090477.21055.48.camel@citrix.com>

(Adding Wei and Jan who I should have included before, thread starts at
 http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg00442.html )

On Wed, 2016-01-06 at 14:27 +0000, Ian Campbell wrote:


> Next step is I'm trying 4.6-testing with the newer OVMF to see if this is
> worth pursuing.

Running xen-4.6-testing with ovmf.git 52a99493cce8 instead of cb9a7ebabcd6
does seem to have worked (i.e. the flight hasn't actually finished yet but
it has passed the debian-hvm-install step).

We have in the past, after much discussion[0], backported changes to
Config.mk:OVMF_UPSTREAM_REVISION to pull forward wholesale to a newer ovmf.

On another (more recent) occasion there have been strong objections to
doing so[1]. I think we concluded there that we should add stable-X.Y
branches to git://xenbits.xen.org/ovmf.git and cherry-pick fixes, the
reason nothing happened then was that the backport in question was a
feature request for ovmf on arm64 which is not something we test and was
not therefore something I was comfortable with.

If we consider [0] as precedent then we would want to backport
xen.git 04c5efb0a141 and f046e501bbc to staging-4.4, -4.5 and -4.6 to bring
those branches up to ovmf.git 52a99493cce8.

If we want to follow [1] then the plan of attack is:
 * I need to identify the patch(es) which actually fix this issue and
   cherrypick it into new stable branches in ovmf.git for 4.4, 4.5 and 4.6.
 * Ian J to update OVMF_UPSTREAM_REVISION in the corresponding xen.git
   stable branches to point to all those commits (either branch name or
   SHA, not sure).
 * The release checklist needs updating to include tagging this new tree
   and updating OVMF_UPSTREAM_REVISION to point to the tag instead of the
   commit (I think this is strictly speaking option, but we should do it).
 * We might want to consider retroactively tagging the versions of ovmf
   used in 4.4.[01234], 4.5.[012] and 4.6.0 in ovmf.git, which would be
   helpful for people using gitk etc to look at the history I suppose 

That assumes a seabios/qemut style model to updating ovmf, i.e. ungated
manual Config.mk update, if we were to switch to a gate it would be
different but regardless of the merits of doing things that way it does't
seem like a thing to do on a stable branch.

Ian.

[0] http://lists.xenproject.org/archives/html/xen-devel/2015-07/msg04428.html
[1] http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg02381.html
 stemming from
http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg01534.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-01-06 15:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 12:35 OVMF related osstest failures on multiple branches Ian Campbell
2016-01-06 14:27 ` Ian Campbell
2016-01-06 15:28   ` Ian Campbell [this message]
2016-01-06 16:20     ` Jan Beulich
2016-01-06 16:28       ` Ian Jackson
2016-01-06 17:08         ` Ian Campbell
2016-01-06 17:14           ` Ian Jackson
2016-01-07 15:36             ` Ian Jackson
2016-01-07 15:42               ` Ian Campbell
2016-01-07 15:47                 ` Ian Jackson
2016-01-07 15:53                   ` Ian Jackson
2016-01-06 16:50     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452094110.21055.81.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.