From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1E1AF1A0202 for ; Fri, 8 Jan 2016 06:37:30 +1100 (AEDT) Message-ID: <1452195444.4028.21.camel@perches.com> Subject: Re: Build failure: -Wno-unused-const-variable DNE on old GCC From: Joe Perches To: Brian Norris , Michael Ellerman Cc: Anton Blanchard , Ian Munsie , Michael Neuling , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Michal Marek Date: Thu, 07 Jan 2016 11:37:24 -0800 In-Reply-To: <20160107185406.GA65420@google.com> References: <20160107185406.GA65420@google.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2016-01-07 at 10:54 -0800, Brian Norris wrote: > Hi, > > I'm using a GCC 4.6.3 compiler for some compile tests, and I noticed > that commit 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable > behaviour change") breaks my builds, because the > -Wno-unused-const-variable doesn't exist on GCC 4.6.3. > >   drivers/misc/cxl/base.c: At top level: >   cc1: error: unrecognized command line option "-Wno-unused-const-variable" [-Werror] > > Any thoughts on how to best fix this? I'd like not to have to scrounge > up a new cross compiler just for build tests. drivers/misc/cxl/Makefile:ccflags-y := -Werror -Wno-unused-const-variable You could take that -Wno-unused-const-variable out of the Makefile or maybe add something like: $(call cc-ifversion, -ge, 0530, -Wno-unused-const-variable) or whatever gcc version actually added that unused-const-variable check