All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>,
	<linux-mtd@lists.infradead.org>
Cc: <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] mtd: nand: add FSL_SOC dependency to drivers using FSL_LBC
Date: Thu, 7 Jan 2016 13:47:33 -0600	[thread overview]
Message-ID: <1452196053.19133.23.camel@freescale.com> (raw)
In-Reply-To: <1452194501-115280-1-git-send-email-computersforpeace@gmail.com>

On Thu, 2016-01-07 at 11:21 -0800, Brian Norris wrote:
> I've managed to construct .config files (for ppc64) that come across
> this Kconfig warning:
> 
>   warning: (MPC836x_RDK && MTD_NAND_FSL_ELBC && MTD_NAND_FSL_UPM) selects
> FSL_LBC which has unmet direct dependencies (FSL_SOC)
> 
> Let's add the FSL_SOC dependency to the NAND drivers. AFAICT, they are
> only supported on PPC32 FSL SoCs anyway.

There are other problems, if you can enable an 83xx board on ppc64.  PPC_83xx
does select FSL_SOC so I don't know why it's unmet.

FWIW, I think we should instead drop the FSL_SOC dependency from FSL_LBC.  It
doesn't use anything that I can see from fsl_soc.c.  It's been commonly abused
as a means for hiding the option on builds for other platforms, but that has
to stop anyway now that many of these devices are also on ARM-based chips. 
 eLBC isn't, since it was obsoleted by IFC, but it shouldn't be unnecessarily
different from IFC.  IFC currently depends on FSL_SOC but that needs to go
away.

-Scott

  reply	other threads:[~2016-01-07 19:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 19:21 [PATCH] mtd: nand: add FSL_SOC dependency to drivers using FSL_LBC Brian Norris
2016-01-07 19:47 ` Scott Wood [this message]
2016-01-07 20:34   ` Brian Norris
2016-01-07 20:40     ` Scott Wood
2016-01-07 20:45       ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452196053.19133.23.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.