From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcel.ziswiler@toradex.com (Marcel Ziswiler) Date: Fri, 8 Jan 2016 08:29:14 +0000 Subject: [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board In-Reply-To: References: <1452011942-11940-1-git-send-email-marcel.ziswiler@toradex.com> <1452011942-11940-3-git-send-email-marcel.ziswiler@toradex.com> Message-ID: <1452241753.3357.12.camel@toradex.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Stefan On Wed, 2016-01-06 at 22:38 -0800, Stefan Agner wrote: > Hi Marcel, > > On 2016-01-05 08:39, Marcel Ziswiler wrote: > > From: Petr ?tetiar > > > > Signed-off-by: Petr ?tetiar > > Signed-off-by: Marcel Ziswiler > > --- > > > > Changes in v2: None > > > > ?arch/arm/boot/dts/Makefile???????????????|???1 + > > ?arch/arm/boot/dts/imx6q-apalis-ixora.dts | 256 > > +++++++++++++++++++++++++++++++ > > ?2 files changed, 257 insertions(+) > > ?create mode 100644 arch/arm/boot/dts/imx6q-apalis-ixora.dts > > > > diff --git a/arch/arm/boot/dts/Makefile > > b/arch/arm/boot/dts/Makefile > > index 44508dc..29b1aae 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -315,6 +315,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > > ? imx6dl-udoo.dtb \ > > ? imx6dl-wandboard.dtb \ > > ? imx6dl-wandboard-revb1.dtb \ > > + imx6q-apalis-ixora.dtb \ > > ? imx6q-apf6dev.dtb \ > > ? imx6q-arm2.dtb \ > > ? imx6q-cm-fx6.dtb \ > > diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > > b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > > new file mode 100644 > > index 0000000..5494a13 > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > > @@ -0,0 +1,256 @@ > > +/* > > + * Copyright 2014-2016 Toradex AG > > + * Copyright 2012 Freescale Semiconductor, Inc. > > + * Copyright 2011 Linaro Ltd. > > + * > > + * This file is dual-licensed: you can use it either under the > > terms > > + * of the GPL or the X11 license, at your option. Note that this > > dual > > + * licensing only applies to this file, and not this project as a > > + * whole. > > + * > > + *??a) This file is free software; you can redistribute it and/or > > + *?????modify it under the terms of the GNU General Public License > > + *?????version 2 as published by the Free Software Foundation. > > + * > > + *?????This file is distributed in the hope that it will be useful > > + *?????but WITHOUT ANY WARRANTY; without even the implied warranty > > of > > + *?????MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.??See > > the > > + *?????GNU General Public License for more details. > > + * > > + * Or, alternatively > > + * > > + *??b) Permission is hereby granted, free of charge, to any person > > + *?????obtaining a copy of this software and associated > > documentation > > + *?????files (the "Software"), to deal in the Software without > > + *?????restriction, including without limitation the rights to use > > + *?????copy, modify, merge, publish, distribute, sublicense, > > and/or > > + *?????sell copies of the Software, and to permit persons to whom > > the > > + *?????Software is furnished to do so, subject to the following > > + *?????conditions: > > + * > > + *?????The above copyright notice and this permission notice shall > > be > > + *?????included in all copies or substantial portions of the > > Software. > > + * > > + *?????THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND > > + *?????EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE > > WARRANTIES > > + *?????OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > + *?????NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > > + *?????HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY > > + *?????WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > > ARISING > > + *?????FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE > > OR > > + *?????OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +/dts-v1/; > > + > > +#include > > +#include > > +#include > > +#include "imx6q.dtsi" > > +#include "imx6qdl-apalis.dtsi" > > + > > +/ { > > + model = "Toradex Apalis iMX6Q/D Module on Ixora Carrier > > Board"; > > + compatible = "toradex,apalis_imx6q-ixora", > > "toradex,apalis_imx6q", > > + ?????"fsl,imx6q"; > > + > > + aliases { > > + i2c0 = &i2cddc; > > + i2c1 = &i2c1; > > + i2c2 = &i2c2; > > + i2c3 = &i2c3; > > + }; > > + > > + aliases { > > + rtc0 = &rtc_i2c; > > + rtc1 = "/soc/aips-bus at 02000000/snvs at 020cc000/snvs- > > rtc-lp at 34"; > > Probably easier and better readable when using the label here > ("&snvs_rtc"). Agreed. > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gpio_keys>; > > + > > + wakeup { > > + label = "Wake-Up"; > > + gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; > > + linux,code = ; > > + debounce-interval = <10>; > > + gpio-key,wakeup; > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_leds_ixora>; > > + > > + led4-green { > > + label = "LED_4_GREEN"; > > + gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>; > > + }; > > + > > + led4-red { > > + label = "LED_4_RED"; > > + gpios = <&gpio1 21 GPIO_ACTIVE_HIGH>; > > + }; > > + > > + led5-green { > > + label = "LED_5_GREEN"; > > + gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>; > > + }; > > + > > + led5-red { > > + label = "LED_5_RED"; > > + gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; > > + }; > > + }; > > + > > + pwmleds { > > + compatible = "pwm-leds"; > > + ledpwm1 { > > + label = "PWM1"; > > + pwms = <&pwm1 0 50000>; > > + max-brightness = <255>; > > + }; > > + > > + ledpwm2 { > > + label = "PWM2"; > > + pwms = <&pwm2 0 50000>; > > + max-brightness = <255>; > > + }; > > + > > + ledpwm3 { > > + label = "PWM3"; > > + pwms = <&pwm3 0 50000>; > > + max-brightness = <255>; > > + }; > > + }; > > + > > + regulators { > > + reg_usb_otg_vbus: usb_otg_vbus { > > + status = "okay"; > > + }; > > + > > + reg_usb_host_vbus: usb_host_vbus { > > + status = "okay"; > > + }; > > + }; > > +}; > > + > > +&backlight { > > + brightness-levels = <0 127 191 223 239 247 251 255>; > > + default-brightness-level = <1>; > > + status = "okay"; > > +}; > > + > > +&can1 { > > + status = "okay"; > > +}; > > + > > +&can2 { > > + status = "okay"; > > +}; > > + > > +/* GEN1_I2C: I2C1_SDA/SCL on MXM3 209/211 (e.g. RTC on carrier > > board) */ > > +&i2c1 { > > + status = "okay"; > > + > > + cat24c02 at 50 { > > According to devicetree.org, nodes are named according to what kind > of > device it represents. Hence this should be eeprom at 50. Agreed. > > + compatible = "atmel,24c02"; > > + reg = <0x50>; > > + }; > > + > > + /* M41T0M6 real time clock on carrier board */ > > + rtc_i2c: rtc at 68 { > > + compatible = "st,m41t00"; > > + reg = <0x68>; > > + }; > > +}; > > + > > +&iomuxc { > > This should go to the end of the device tree. Agreed. > Otherwise looks good to me: > Reviewed-by: Stefan Agner Thanks! > -- > Stefan > > > + /* > > + ?* Mux the Apalis GPIOs, GPIO7 used for PCIe reset, > > + ?* GPIO5, 6 used by optional fusion_F0710A kernel module > > + ?*/ > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_apalis_gpio1 &pinctrl_apalis_gpio2 > > + ?????&pinctrl_apalis_gpio3 &pinctrl_apalis_gpio4 > > + ?????&pinctrl_apalis_gpio5 &pinctrl_apalis_gpio6 > > + ?????&pinctrl_apalis_gpio7 &pinctrl_apalis_gpio8>; > > + > > + leds_ixora { > > + pinctrl_leds_ixora: leds-ixora { > > + fsl,pins = < > > + MX6QDL_PAD_SD1_DAT1__GPIO1_IO17 > > PAD_CTRL_HYS_PU > > + MX6QDL_PAD_SD1_DAT3__GPIO1_IO21 > > PAD_CTRL_HYS_PU > > + MX6QDL_PAD_NANDF_D1__GPIO2_IO01 > > PAD_CTRL_HYS_PU > > + MX6QDL_PAD_NANDF_D2__GPIO2_IO02 > > PAD_CTRL_HYS_PU > > + >; > > + }; > > + }; > > +}; > > + > > +&pcie { > > + /* active-low meaning opposite of regular PERST# active- > > low polarity */ > > + reset-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>; > > + status = "okay"; > > +}; > > + > > +&pwm1 { > > + status = "okay"; > > +}; > > + > > +&pwm2 { > > + status = "okay"; > > +}; > > + > > +&pwm3 { > > + status = "okay"; > > +}; > > + > > +&pwm4 { > > + status = "okay"; > > +}; > > + > > +&sata { > > + status = "okay"; > > +}; > > + > > +&sound_spdif { > > + status = "okay"; > > +}; > > + > > +&spdif { > > + status = "okay"; > > +}; > > + > > +&uart1 { > > + status = "okay"; > > +}; > > + > > +&uart2 { > > + status = "okay"; > > +}; > > + > > +&uart4 { > > + status = "okay"; > > +}; > > + > > +&uart5 { > > + status = "okay"; > > +}; > > + > > +&usbh1 { > > + status = "okay"; > > +}; > > + > > +&usbotg { > > + status = "okay"; > > +}; > > + > > +/* SD1 */ > > +&usdhc2 { > > + status = "okay"; > > +}; Cheers Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Subject: Re: [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Date: Fri, 8 Jan 2016 08:29:14 +0000 Message-ID: <1452241753.3357.12.camel@toradex.com> References: <1452011942-11940-1-git-send-email-marcel.ziswiler@toradex.com> <1452011942-11940-3-git-send-email-marcel.ziswiler@toradex.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "stefan@agner.ch" Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "stillcompiling@gmail.com" , "linux@arm.linux.org.uk" , "pawel.moll@arm.com" , "ijc+devicetree@hellion.org.uk" , "shawnguo@kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "kernel@pengutronix.de" , "galak@codeaurora.org" , "ynezz@true.cz" , "shawn.guo@linaro.org" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" List-Id: devicetree@vger.kernel.org SGkgU3RlZmFuDQoNCk9uIFdlZCwgMjAxNi0wMS0wNiBhdCAyMjozOCAtMDgwMCwgU3RlZmFuIEFn bmVyIHdyb3RlOg0KPiBIaSBNYXJjZWwsDQo+IA0KPiBPbiAyMDE2LTAxLTA1IDA4OjM5LCBNYXJj ZWwgWmlzd2lsZXIgd3JvdGU6DQo+ID4gRnJvbTogUGV0ciDFoHRldGlhciA8eW5lenpAdHJ1ZS5j ej4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBQZXRyIMWgdGV0aWFyIDx5bmV6ekB0cnVlLmN6 Pg0KPiA+IFNpZ25lZC1vZmYtYnk6IE1hcmNlbCBaaXN3aWxlciA8bWFyY2VsLnppc3dpbGVyQHRv cmFkZXguY29tPg0KPiA+IC0tLQ0KPiA+IA0KPiA+IENoYW5nZXMgaW4gdjI6IE5vbmUNCj4gPiAN Cj4gPiDCoGFyY2gvYXJtL2Jvb3QvZHRzL01ha2VmaWxlwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgfMKgwqDCoDEgKw0KPiA+IMKgYXJjaC9hcm0vYm9vdC9kdHMvaW14NnEtYXBhbGlzLWl4 b3JhLmR0cyB8IDI1Ng0KPiA+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiDC oDIgZmlsZXMgY2hhbmdlZCwgMjU3IGluc2VydGlvbnMoKykNCj4gPiDCoGNyZWF0ZSBtb2RlIDEw MDY0NCBhcmNoL2FybS9ib290L2R0cy9pbXg2cS1hcGFsaXMtaXhvcmEuZHRzDQo+ID4gDQo+ID4g ZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL01ha2VmaWxlDQo+ID4gYi9hcmNoL2FybS9i b290L2R0cy9NYWtlZmlsZQ0KPiA+IGluZGV4IDQ0NTA4ZGMuLjI5YjFhYWUgMTAwNjQ0DQo+ID4g LS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvTWFrZWZpbGUNCj4gPiArKysgYi9hcmNoL2FybS9ib290 L2R0cy9NYWtlZmlsZQ0KPiA+IEBAIC0zMTUsNiArMzE1LDcgQEAgZHRiLSQoQ09ORklHX1NPQ19J TVg2USkgKz0gXA0KPiA+IMKgCWlteDZkbC11ZG9vLmR0YiBcDQo+ID4gwqAJaW14NmRsLXdhbmRi b2FyZC5kdGIgXA0KPiA+IMKgCWlteDZkbC13YW5kYm9hcmQtcmV2YjEuZHRiIFwNCj4gPiArCWlt eDZxLWFwYWxpcy1peG9yYS5kdGIgXA0KPiA+IMKgCWlteDZxLWFwZjZkZXYuZHRiIFwNCj4gPiDC oAlpbXg2cS1hcm0yLmR0YiBcDQo+ID4gwqAJaW14NnEtY20tZng2LmR0YiBcDQo+ID4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDZxLWFwYWxpcy1peG9yYS5kdHMNCj4gPiBiL2Fy Y2gvYXJtL2Jvb3QvZHRzL2lteDZxLWFwYWxpcy1peG9yYS5kdHMNCj4gPiBuZXcgZmlsZSBtb2Rl IDEwMDY0NA0KPiA+IGluZGV4IDAwMDAwMDAuLjU0OTRhMTMNCj4gPiAtLS0gL2Rldi9udWxsDQo+ ID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvaW14NnEtYXBhbGlzLWl4b3JhLmR0cw0KPiA+IEBA IC0wLDAgKzEsMjU2IEBADQo+ID4gKy8qDQo+ID4gKyAqIENvcHlyaWdodCAyMDE0LTIwMTYgVG9y YWRleCBBRw0KPiA+ICsgKiBDb3B5cmlnaHQgMjAxMiBGcmVlc2NhbGUgU2VtaWNvbmR1Y3Rvciwg SW5jLg0KPiA+ICsgKiBDb3B5cmlnaHQgMjAxMSBMaW5hcm8gTHRkLg0KPiA+ICsgKg0KPiA+ICsg KiBUaGlzIGZpbGUgaXMgZHVhbC1saWNlbnNlZDogeW91IGNhbiB1c2UgaXQgZWl0aGVyIHVuZGVy IHRoZQ0KPiA+IHRlcm1zDQo+ID4gKyAqIG9mIHRoZSBHUEwgb3IgdGhlIFgxMSBsaWNlbnNlLCBh dCB5b3VyIG9wdGlvbi4gTm90ZSB0aGF0IHRoaXMNCj4gPiBkdWFsDQo+ID4gKyAqIGxpY2Vuc2lu ZyBvbmx5IGFwcGxpZXMgdG8gdGhpcyBmaWxlLCBhbmQgbm90IHRoaXMgcHJvamVjdCBhcyBhDQo+ ID4gKyAqIHdob2xlLg0KPiA+ICsgKg0KPiA+ICsgKsKgwqBhKSBUaGlzIGZpbGUgaXMgZnJlZSBz b2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yDQo+ID4gKyAqwqDCoMKgwqDC oG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNl bnNlDQo+ID4gKyAqwqDCoMKgwqDCoHZlcnNpb24gMiBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUg U29mdHdhcmUgRm91bmRhdGlvbi4NCj4gPiArICoNCj4gPiArICrCoMKgwqDCoMKgVGhpcyBmaWxl IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwNCj4gPiAr ICrCoMKgwqDCoMKgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGlt cGxpZWQgd2FycmFudHkNCj4gPiBvZg0KPiA+ICsgKsKgwqDCoMKgwqBNRVJDSEFOVEFCSUxJVFkg b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuwqDCoFNlZQ0KPiA+IHRoZQ0KPiA+ ICsgKsKgwqDCoMKgwqBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxz Lg0KPiA+ICsgKg0KPiA+ICsgKiBPciwgYWx0ZXJuYXRpdmVseQ0KPiA+ICsgKg0KPiA+ICsgKsKg wqBiKSBQZXJtaXNzaW9uIGlzIGhlcmVieSBncmFudGVkLCBmcmVlIG9mIGNoYXJnZSwgdG8gYW55 IHBlcnNvbg0KPiA+ICsgKsKgwqDCoMKgwqBvYnRhaW5pbmcgYSBjb3B5IG9mIHRoaXMgc29mdHdh cmUgYW5kIGFzc29jaWF0ZWQNCj4gPiBkb2N1bWVudGF0aW9uDQo+ID4gKyAqwqDCoMKgwqDCoGZp bGVzICh0aGUgIlNvZnR3YXJlIiksIHRvIGRlYWwgaW4gdGhlIFNvZnR3YXJlIHdpdGhvdXQNCj4g PiArICrCoMKgwqDCoMKgcmVzdHJpY3Rpb24sIGluY2x1ZGluZyB3aXRob3V0IGxpbWl0YXRpb24g dGhlIHJpZ2h0cyB0byB1c2UNCj4gPiArICrCoMKgwqDCoMKgY29weSwgbW9kaWZ5LCBtZXJnZSwg cHVibGlzaCwgZGlzdHJpYnV0ZSwgc3VibGljZW5zZSwNCj4gPiBhbmQvb3INCj4gPiArICrCoMKg wqDCoMKgc2VsbCBjb3BpZXMgb2YgdGhlIFNvZnR3YXJlLCBhbmQgdG8gcGVybWl0IHBlcnNvbnMg dG8gd2hvbQ0KPiA+IHRoZQ0KPiA+ICsgKsKgwqDCoMKgwqBTb2Z0d2FyZSBpcyBmdXJuaXNoZWQg dG8gZG8gc28sIHN1YmplY3QgdG8gdGhlIGZvbGxvd2luZw0KPiA+ICsgKsKgwqDCoMKgwqBjb25k aXRpb25zOg0KPiA+ICsgKg0KPiA+ICsgKsKgwqDCoMKgwqBUaGUgYWJvdmUgY29weXJpZ2h0IG5v dGljZSBhbmQgdGhpcyBwZXJtaXNzaW9uIG5vdGljZSBzaGFsbA0KPiA+IGJlDQo+ID4gKyAqwqDC oMKgwqDCoGluY2x1ZGVkIGluIGFsbCBjb3BpZXMgb3Igc3Vic3RhbnRpYWwgcG9ydGlvbnMgb2Yg dGhlDQo+ID4gU29mdHdhcmUuDQo+ID4gKyAqDQo+ID4gKyAqwqDCoMKgwqDCoFRIRSBTT0ZUV0FS RSBJUyBQUk9WSURFRCAsIFdJVEhPVVQgV0FSUkFOVFkgT0YgQU5ZIEtJTkQNCj4gPiArICrCoMKg wqDCoMKgRVhQUkVTUyBPUiBJTVBMSUVELCBJTkNMVURJTkcgQlVUIE5PVCBMSU1JVEVEIFRPIFRI RQ0KPiA+IFdBUlJBTlRJRVMNCj4gPiArICrCoMKgwqDCoMKgT0YgTUVSQ0hBTlRBQklMSVRZLCBG SVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBTkQNCj4gPiArICrCoMKgwqDCoMKgTk9O SU5GUklOR0VNRU5ULiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQVVUSE9SUyBPUiBDT1BZUklHSFQN Cj4gPiArICrCoMKgwqDCoMKgSE9MREVSUyBCRSBMSUFCTEUgRk9SIEFOWSBDTEFJTSwgREFNQUdF UyBPUiBPVEhFUiBMSUFCSUxJVFkNCj4gPiArICrCoMKgwqDCoMKgV0hFVEhFUiBJTiBBTiBBQ1RJ T04gT0YgQ09OVFJBQ1QsIFRPUlQgT1IgT1RIRVJXSVNFLA0KPiA+IEFSSVNJTkcNCj4gPiArICrC oMKgwqDCoMKgRlJPTSwgT1VUIE9GIE9SIElOIENPTk5FQ1RJT04gV0lUSCBUSEUgU09GVFdBUkUg T1IgVEhFIFVTRQ0KPiA+IE9SDQo+ID4gKyAqwqDCoMKgwqDCoE9USEVSIERFQUxJTkdTIElOIFRI RSBTT0ZUV0FSRS4NCj4gPiArICovDQo+ID4gKw0KPiA+ICsvZHRzLXYxLzsNCj4gPiArDQo+ID4g KyNpbmNsdWRlIDxkdC1iaW5kaW5ncy9ncGlvL2dwaW8uaD4NCj4gPiArI2luY2x1ZGUgPGR0LWJp bmRpbmdzL2lucHV0L2lucHV0Lmg+DQo+ID4gKyNpbmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1 cHQtY29udHJvbGxlci9pcnEuaD4NCj4gPiArI2luY2x1ZGUgImlteDZxLmR0c2kiDQo+ID4gKyNp bmNsdWRlICJpbXg2cWRsLWFwYWxpcy5kdHNpIg0KPiA+ICsNCj4gPiArLyB7DQo+ID4gKwltb2Rl bCA9ICJUb3JhZGV4IEFwYWxpcyBpTVg2US9EIE1vZHVsZSBvbiBJeG9yYSBDYXJyaWVyDQo+ID4g Qm9hcmQiOw0KPiA+ICsJY29tcGF0aWJsZSA9ICJ0b3JhZGV4LGFwYWxpc19pbXg2cS1peG9yYSIs DQo+ID4gInRvcmFkZXgsYXBhbGlzX2lteDZxIiwNCj4gPiArCQnCoMKgwqDCoMKgImZzbCxpbXg2 cSI7DQo+ID4gKw0KPiA+ICsJYWxpYXNlcyB7DQo+ID4gKwkJaTJjMCA9ICZpMmNkZGM7DQo+ID4g KwkJaTJjMSA9ICZpMmMxOw0KPiA+ICsJCWkyYzIgPSAmaTJjMjsNCj4gPiArCQlpMmMzID0gJmky YzM7DQo+ID4gKwl9Ow0KPiA+ICsNCj4gPiArCWFsaWFzZXMgew0KPiA+ICsJCXJ0YzAgPSAmcnRj X2kyYzsNCj4gPiArCQlydGMxID0gIi9zb2MvYWlwcy1idXNAMDIwMDAwMDAvc252c0AwMjBjYzAw MC9zbnZzLQ0KPiA+IHJ0Yy1scEAzNCI7DQo+IA0KPiBQcm9iYWJseSBlYXNpZXIgYW5kIGJldHRl ciByZWFkYWJsZSB3aGVuIHVzaW5nIHRoZSBsYWJlbCBoZXJlDQo+ICgiJnNudnNfcnRjIikuDQoN CkFncmVlZC4NCg0KPiA+ICsJfTsNCj4gPiArDQo+ID4gKwlncGlvLWtleXMgew0KPiA+ICsJCWNv bXBhdGlibGUgPSAiZ3Bpby1rZXlzIjsNCj4gPiArCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQi Ow0KPiA+ICsJCXBpbmN0cmwtMCA9IDwmcGluY3RybF9ncGlvX2tleXM+Ow0KPiA+ICsNCj4gPiAr CQl3YWtldXAgew0KPiA+ICsJCQlsYWJlbCA9ICJXYWtlLVVwIjsNCj4gPiArCQkJZ3Bpb3MgPSA8 JmdwaW8xIDQgR1BJT19BQ1RJVkVfTE9XPjsNCj4gPiArCQkJbGludXgsY29kZSA9IDxLRVlfV0FL RVVQPjsNCj4gPiArCQkJZGVib3VuY2UtaW50ZXJ2YWwgPSA8MTA+Ow0KPiA+ICsJCQlncGlvLWtl eSx3YWtldXA7DQo+ID4gKwkJfTsNCj4gPiArCX07DQo+ID4gKw0KPiA+ICsJbGVkcyB7DQo+ID4g KwkJY29tcGF0aWJsZSA9ICJncGlvLWxlZHMiOw0KPiA+ICsNCj4gPiArCQlwaW5jdHJsLW5hbWVz ID0gImRlZmF1bHQiOw0KPiA+ICsJCXBpbmN0cmwtMCA9IDwmcGluY3RybF9sZWRzX2l4b3JhPjsN Cj4gPiArDQo+ID4gKwkJbGVkNC1ncmVlbiB7DQo+ID4gKwkJCWxhYmVsID0gIkxFRF80X0dSRUVO IjsNCj4gPiArCQkJZ3Bpb3MgPSA8JmdwaW8xIDE3IEdQSU9fQUNUSVZFX0hJR0g+Ow0KPiA+ICsJ CX07DQo+ID4gKw0KPiA+ICsJCWxlZDQtcmVkIHsNCj4gPiArCQkJbGFiZWwgPSAiTEVEXzRfUkVE IjsNCj4gPiArCQkJZ3Bpb3MgPSA8JmdwaW8xIDIxIEdQSU9fQUNUSVZFX0hJR0g+Ow0KPiA+ICsJ CX07DQo+ID4gKw0KPiA+ICsJCWxlZDUtZ3JlZW4gew0KPiA+ICsJCQlsYWJlbCA9ICJMRURfNV9H UkVFTiI7DQo+ID4gKwkJCWdwaW9zID0gPCZncGlvMiAxIEdQSU9fQUNUSVZFX0hJR0g+Ow0KPiA+ ICsJCX07DQo+ID4gKw0KPiA+ICsJCWxlZDUtcmVkIHsNCj4gPiArCQkJbGFiZWwgPSAiTEVEXzVf UkVEIjsNCj4gPiArCQkJZ3Bpb3MgPSA8JmdwaW8yIDIgR1BJT19BQ1RJVkVfSElHSD47DQo+ID4g KwkJfTsNCj4gPiArCX07DQo+ID4gKw0KPiA+ICsJcHdtbGVkcyB7DQo+ID4gKwkJY29tcGF0aWJs ZSA9ICJwd20tbGVkcyI7DQo+ID4gKwkJbGVkcHdtMSB7DQo+ID4gKwkJCWxhYmVsID0gIlBXTTEi Ow0KPiA+ICsJCQlwd21zID0gPCZwd20xIDAgNTAwMDA+Ow0KPiA+ICsJCQltYXgtYnJpZ2h0bmVz cyA9IDwyNTU+Ow0KPiA+ICsJCX07DQo+ID4gKw0KPiA+ICsJCWxlZHB3bTIgew0KPiA+ICsJCQls YWJlbCA9ICJQV00yIjsNCj4gPiArCQkJcHdtcyA9IDwmcHdtMiAwIDUwMDAwPjsNCj4gPiArCQkJ bWF4LWJyaWdodG5lc3MgPSA8MjU1PjsNCj4gPiArCQl9Ow0KPiA+ICsNCj4gPiArCQlsZWRwd20z IHsNCj4gPiArCQkJbGFiZWwgPSAiUFdNMyI7DQo+ID4gKwkJCXB3bXMgPSA8JnB3bTMgMCA1MDAw MD47DQo+ID4gKwkJCW1heC1icmlnaHRuZXNzID0gPDI1NT47DQo+ID4gKwkJfTsNCj4gPiArCX07 DQo+ID4gKw0KPiA+ICsJcmVndWxhdG9ycyB7DQo+ID4gKwkJcmVnX3VzYl9vdGdfdmJ1czogdXNi X290Z192YnVzIHsNCj4gPiArCQkJc3RhdHVzID0gIm9rYXkiOw0KPiA+ICsJCX07DQo+ID4gKw0K PiA+ICsJCXJlZ191c2JfaG9zdF92YnVzOiB1c2JfaG9zdF92YnVzIHsNCj4gPiArCQkJc3RhdHVz ID0gIm9rYXkiOw0KPiA+ICsJCX07DQo+ID4gKwl9Ow0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArJmJh Y2tsaWdodCB7DQo+ID4gKwlicmlnaHRuZXNzLWxldmVscyA9IDwwIDEyNyAxOTEgMjIzIDIzOSAy NDcgMjUxIDI1NT47DQo+ID4gKwlkZWZhdWx0LWJyaWdodG5lc3MtbGV2ZWwgPSA8MT47DQo+ID4g KwlzdGF0dXMgPSAib2theSI7DQo+ID4gK307DQo+ID4gKw0KPiA+ICsmY2FuMSB7DQo+ID4gKwlz dGF0dXMgPSAib2theSI7DQo+ID4gK307DQo+ID4gKw0KPiA+ICsmY2FuMiB7DQo+ID4gKwlzdGF0 dXMgPSAib2theSI7DQo+ID4gK307DQo+ID4gKw0KPiA+ICsvKiBHRU4xX0kyQzogSTJDMV9TREEv U0NMIG9uIE1YTTMgMjA5LzIxMSAoZS5nLiBSVEMgb24gY2Fycmllcg0KPiA+IGJvYXJkKSAqLw0K PiA+ICsmaTJjMSB7DQo+ID4gKwlzdGF0dXMgPSAib2theSI7DQo+ID4gKw0KPiA+ICsJY2F0MjRj MDJANTAgew0KPiANCj4gQWNjb3JkaW5nIHRvIGRldmljZXRyZWUub3JnLCBub2RlcyBhcmUgbmFt ZWQgYWNjb3JkaW5nIHRvIHdoYXQga2luZA0KPiBvZg0KPiBkZXZpY2UgaXQgcmVwcmVzZW50cy4g SGVuY2UgdGhpcyBzaG91bGQgYmUgZWVwcm9tQDUwLg0KDQpBZ3JlZWQuDQoNCj4gPiArCQljb21w YXRpYmxlID0gImF0bWVsLDI0YzAyIjsNCj4gPiArCQlyZWcgPSA8MHg1MD47DQo+ID4gKwl9Ow0K PiA+ICsNCj4gPiArCS8qIE00MVQwTTYgcmVhbCB0aW1lIGNsb2NrIG9uIGNhcnJpZXIgYm9hcmQg Ki8NCj4gPiArCXJ0Y19pMmM6IHJ0Y0A2OCB7DQo+ID4gKwkJY29tcGF0aWJsZSA9ICJzdCxtNDF0 MDAiOw0KPiA+ICsJCXJlZyA9IDwweDY4PjsNCj4gPiArCX07DQo+ID4gK307DQo+ID4gKw0KPiA+ ICsmaW9tdXhjIHsNCj4gDQo+IFRoaXMgc2hvdWxkIGdvIHRvIHRoZSBlbmQgb2YgdGhlIGRldmlj ZSB0cmVlLg0KDQpBZ3JlZWQuDQoNCj4gT3RoZXJ3aXNlIGxvb2tzIGdvb2QgdG8gbWU6DQo+IFJl dmlld2VkLWJ5OiBTdGVmYW4gQWduZXIgPHN0ZWZhbkBhZ25lci5jaD4NCg0KVGhhbmtzIQ0KDQo+ IC0tDQo+IFN0ZWZhbg0KPiANCj4gPiArCS8qDQo+ID4gKwnCoCogTXV4IHRoZSBBcGFsaXMgR1BJ T3MsIEdQSU83IHVzZWQgZm9yIFBDSWUgcmVzZXQsDQo+ID4gKwnCoCogR1BJTzUsIDYgdXNlZCBi eSBvcHRpb25hbCBmdXNpb25fRjA3MTBBIGtlcm5lbCBtb2R1bGUNCj4gPiArCcKgKi8NCj4gPiAr CXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7DQo+ID4gKwlwaW5jdHJsLTAgPSA8JnBpbmN0cmxf YXBhbGlzX2dwaW8xICZwaW5jdHJsX2FwYWxpc19ncGlvMg0KPiA+ICsJCcKgwqDCoMKgwqAmcGlu Y3RybF9hcGFsaXNfZ3BpbzMgJnBpbmN0cmxfYXBhbGlzX2dwaW80DQo+ID4gKwkJwqDCoMKgwqDC oCZwaW5jdHJsX2FwYWxpc19ncGlvNSAmcGluY3RybF9hcGFsaXNfZ3BpbzYNCj4gPiArCQnCoMKg wqDCoMKgJnBpbmN0cmxfYXBhbGlzX2dwaW83ICZwaW5jdHJsX2FwYWxpc19ncGlvOD47DQo+ID4g Kw0KPiA+ICsJbGVkc19peG9yYSB7DQo+ID4gKwkJcGluY3RybF9sZWRzX2l4b3JhOiBsZWRzLWl4 b3JhIHsNCj4gPiArCQkJZnNsLHBpbnMgPSA8DQo+ID4gKwkJCQlNWDZRRExfUEFEX1NEMV9EQVQx X19HUElPMV9JTzE3DQo+ID4gUEFEX0NUUkxfSFlTX1BVDQo+ID4gKwkJCQlNWDZRRExfUEFEX1NE MV9EQVQzX19HUElPMV9JTzIxDQo+ID4gUEFEX0NUUkxfSFlTX1BVDQo+ID4gKwkJCQlNWDZRRExf UEFEX05BTkRGX0QxX19HUElPMl9JTzAxDQo+ID4gUEFEX0NUUkxfSFlTX1BVDQo+ID4gKwkJCQlN WDZRRExfUEFEX05BTkRGX0QyX19HUElPMl9JTzAyDQo+ID4gUEFEX0NUUkxfSFlTX1BVDQo+ID4g KwkJCT47DQo+ID4gKwkJfTsNCj4gPiArCX07DQo+ID4gK307DQo+ID4gKw0KPiA+ICsmcGNpZSB7 DQo+ID4gKwkvKiBhY3RpdmUtbG93IG1lYW5pbmcgb3Bwb3NpdGUgb2YgcmVndWxhciBQRVJTVCMg YWN0aXZlLQ0KPiA+IGxvdyBwb2xhcml0eSAqLw0KPiA+ICsJcmVzZXQtZ3BpbyA9IDwmZ3BpbzEg MjggR1BJT19BQ1RJVkVfTE9XPjsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4g PiArDQo+ID4gKyZwd20xIHsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiAr DQo+ID4gKyZwd20yIHsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiArDQo+ ID4gKyZwd20zIHsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiArDQo+ID4g KyZwd200IHsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiArDQo+ID4gKyZz YXRhIHsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiArDQo+ID4gKyZzb3Vu ZF9zcGRpZiB7DQo+ID4gKwlzdGF0dXMgPSAib2theSI7DQo+ID4gK307DQo+ID4gKw0KPiA+ICsm c3BkaWYgew0KPiA+ICsJc3RhdHVzID0gIm9rYXkiOw0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArJnVh cnQxIHsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiArDQo+ID4gKyZ1YXJ0 MiB7DQo+ID4gKwlzdGF0dXMgPSAib2theSI7DQo+ID4gK307DQo+ID4gKw0KPiA+ICsmdWFydDQg ew0KPiA+ICsJc3RhdHVzID0gIm9rYXkiOw0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArJnVhcnQ1IHsN Cj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiArDQo+ID4gKyZ1c2JoMSB7DQo+ ID4gKwlzdGF0dXMgPSAib2theSI7DQo+ID4gK307DQo+ID4gKw0KPiA+ICsmdXNib3RnIHsNCj4g PiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCj4gPiArDQo+ID4gKy8qIFNEMSAqLw0KPiA+ ICsmdXNkaGMyIHsNCj4gPiArCXN0YXR1cyA9ICJva2F5IjsNCj4gPiArfTsNCg0KDQpDaGVlcnMN Cg0KTWFyY2VsDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754378AbcAHIpO (ORCPT ); Fri, 8 Jan 2016 03:45:14 -0500 Received: from mail-db3on0112.outbound.protection.outlook.com ([157.55.234.112]:8148 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754359AbcAHIpI (ORCPT ); Fri, 8 Jan 2016 03:45:08 -0500 From: Marcel Ziswiler To: "stefan@agner.ch" CC: "linux-kernel@vger.kernel.org" , "shawn.guo@linaro.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "stillcompiling@gmail.com" , "ynezz@true.cz" , "linux-arm-kernel@lists.infradead.org" , "shawnguo@kernel.org" , "l.stach@pengutronix.de" , "kernel@pengutronix.de" , "linux@arm.linux.org.uk" Subject: Re: [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Thread-Topic: [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Thread-Index: AQHRR9e4RGdLnFGHL0GV0OeYB2QBj57vnFQAgAGxS4A= Date: Fri, 8 Jan 2016 08:29:14 +0000 Message-ID: <1452241753.3357.12.camel@toradex.com> References: <1452011942-11940-1-git-send-email-marcel.ziswiler@toradex.com> <1452011942-11940-3-git-send-email-marcel.ziswiler@toradex.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [84.227.37.153] x-microsoft-exchange-diagnostics: 1;VI1PR05MB0973;5:TgROPUk9mMDlt3YkAaeClLMsidLBL0DpyofXZ9C5dkMB0+P8Wu9ic6Tn6mPSAbdIPFgKwWtsMpzrVenJo/ykQsu2GeBfHTEm3cBsswlyWN59KGM0agrVbspnxrrlN+lMTTFY9wwTYNEYp4T0JKUZ2w==;24:pUkcI/ykZUSCN7NI5iroqmqkCgE3jxCL1IOttJhvoNTpt1gJvVld4fxVgo5Uorm1jFi5pRYp4Z5/ZoMqpqDinQzophz6ZlFv5+8R+lM1Ui0= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0973; x-ms-office365-filtering-correlation-id: 13510c19-b64f-451d-d47e-08d31805cb20 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(90676262408878); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(10201501046)(3002001);SRVR:VI1PR05MB0973;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0973; x-forefront-prvs: 0815F8251E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(199003)(377424004)(189002)(5250100002)(11100500001)(5004730100002)(86362001)(103116003)(66066001)(19580395003)(1220700001)(6116002)(1730700002)(586003)(87936001)(3846002)(101416001)(19580405001)(575784001)(2501003)(1096002)(106356001)(5008740100001)(106116001)(102836003)(2351001)(33646002)(105586002)(2950100001)(4326007)(2906002)(40100003)(97736004)(2900100001)(54356999)(81156007)(110136002)(5001960100002)(189998001)(76176999)(50986999)(5002640100001)(92566002)(36756003)(2004002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR05MB0973;H:VI1PR05MB0974.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2016 08:29:14.9326 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB0973 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u088jIqM016049 Hi Stefan On Wed, 2016-01-06 at 22:38 -0800, Stefan Agner wrote: > Hi Marcel, > > On 2016-01-05 08:39, Marcel Ziswiler wrote: > > From: Petr Štetiar > > > > Signed-off-by: Petr Štetiar > > Signed-off-by: Marcel Ziswiler > > --- > > > > Changes in v2: None > > > >  arch/arm/boot/dts/Makefile               |   1 + > >  arch/arm/boot/dts/imx6q-apalis-ixora.dts | 256 > > +++++++++++++++++++++++++++++++ > >  2 files changed, 257 insertions(+) > >  create mode 100644 arch/arm/boot/dts/imx6q-apalis-ixora.dts > > > > diff --git a/arch/arm/boot/dts/Makefile > > b/arch/arm/boot/dts/Makefile > > index 44508dc..29b1aae 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -315,6 +315,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > >   imx6dl-udoo.dtb \ > >   imx6dl-wandboard.dtb \ > >   imx6dl-wandboard-revb1.dtb \ > > + imx6q-apalis-ixora.dtb \ > >   imx6q-apf6dev.dtb \ > >   imx6q-arm2.dtb \ > >   imx6q-cm-fx6.dtb \ > > diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > > b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > > new file mode 100644 > > index 0000000..5494a13 > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > > @@ -0,0 +1,256 @@ > > +/* > > + * Copyright 2014-2016 Toradex AG > > + * Copyright 2012 Freescale Semiconductor, Inc. > > + * Copyright 2011 Linaro Ltd. > > + * > > + * This file is dual-licensed: you can use it either under the > > terms > > + * of the GPL or the X11 license, at your option. Note that this > > dual > > + * licensing only applies to this file, and not this project as a > > + * whole. > > + * > > + *  a) This file is free software; you can redistribute it and/or > > + *     modify it under the terms of the GNU General Public License > > + *     version 2 as published by the Free Software Foundation. > > + * > > + *     This file is distributed in the hope that it will be useful > > + *     but WITHOUT ANY WARRANTY; without even the implied warranty > > of > > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See > > the > > + *     GNU General Public License for more details. > > + * > > + * Or, alternatively > > + * > > + *  b) Permission is hereby granted, free of charge, to any person > > + *     obtaining a copy of this software and associated > > documentation > > + *     files (the "Software"), to deal in the Software without > > + *     restriction, including without limitation the rights to use > > + *     copy, modify, merge, publish, distribute, sublicense, > > and/or > > + *     sell copies of the Software, and to permit persons to whom > > the > > + *     Software is furnished to do so, subject to the following > > + *     conditions: > > + * > > + *     The above copyright notice and this permission notice shall > > be > > + *     included in all copies or substantial portions of the > > Software. > > + * > > + *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND > > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE > > WARRANTIES > > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY > > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > > ARISING > > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE > > OR > > + *     OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +/dts-v1/; > > + > > +#include > > +#include > > +#include > > +#include "imx6q.dtsi" > > +#include "imx6qdl-apalis.dtsi" > > + > > +/ { > > + model = "Toradex Apalis iMX6Q/D Module on Ixora Carrier > > Board"; > > + compatible = "toradex,apalis_imx6q-ixora", > > "toradex,apalis_imx6q", > > +      "fsl,imx6q"; > > + > > + aliases { > > + i2c0 = &i2cddc; > > + i2c1 = &i2c1; > > + i2c2 = &i2c2; > > + i2c3 = &i2c3; > > + }; > > + > > + aliases { > > + rtc0 = &rtc_i2c; > > + rtc1 = "/soc/aips-bus@02000000/snvs@020cc000/snvs- > > rtc-lp@34"; > > Probably easier and better readable when using the label here > ("&snvs_rtc"). Agreed. > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gpio_keys>; > > + > > + wakeup { > > + label = "Wake-Up"; > > + gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; > > + linux,code = ; > > + debounce-interval = <10>; > > + gpio-key,wakeup; > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_leds_ixora>; > > + > > + led4-green { > > + label = "LED_4_GREEN"; > > + gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>; > > + }; > > + > > + led4-red { > > + label = "LED_4_RED"; > > + gpios = <&gpio1 21 GPIO_ACTIVE_HIGH>; > > + }; > > + > > + led5-green { > > + label = "LED_5_GREEN"; > > + gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>; > > + }; > > + > > + led5-red { > > + label = "LED_5_RED"; > > + gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; > > + }; > > + }; > > + > > + pwmleds { > > + compatible = "pwm-leds"; > > + ledpwm1 { > > + label = "PWM1"; > > + pwms = <&pwm1 0 50000>; > > + max-brightness = <255>; > > + }; > > + > > + ledpwm2 { > > + label = "PWM2"; > > + pwms = <&pwm2 0 50000>; > > + max-brightness = <255>; > > + }; > > + > > + ledpwm3 { > > + label = "PWM3"; > > + pwms = <&pwm3 0 50000>; > > + max-brightness = <255>; > > + }; > > + }; > > + > > + regulators { > > + reg_usb_otg_vbus: usb_otg_vbus { > > + status = "okay"; > > + }; > > + > > + reg_usb_host_vbus: usb_host_vbus { > > + status = "okay"; > > + }; > > + }; > > +}; > > + > > +&backlight { > > + brightness-levels = <0 127 191 223 239 247 251 255>; > > + default-brightness-level = <1>; > > + status = "okay"; > > +}; > > + > > +&can1 { > > + status = "okay"; > > +}; > > + > > +&can2 { > > + status = "okay"; > > +}; > > + > > +/* GEN1_I2C: I2C1_SDA/SCL on MXM3 209/211 (e.g. RTC on carrier > > board) */ > > +&i2c1 { > > + status = "okay"; > > + > > + cat24c02@50 { > > According to devicetree.org, nodes are named according to what kind > of > device it represents. Hence this should be eeprom@50. Agreed. > > + compatible = "atmel,24c02"; > > + reg = <0x50>; > > + }; > > + > > + /* M41T0M6 real time clock on carrier board */ > > + rtc_i2c: rtc@68 { > > + compatible = "st,m41t00"; > > + reg = <0x68>; > > + }; > > +}; > > + > > +&iomuxc { > > This should go to the end of the device tree. Agreed. > Otherwise looks good to me: > Reviewed-by: Stefan Agner Thanks! > -- > Stefan > > > + /* > > +  * Mux the Apalis GPIOs, GPIO7 used for PCIe reset, > > +  * GPIO5, 6 used by optional fusion_F0710A kernel module > > +  */ > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_apalis_gpio1 &pinctrl_apalis_gpio2 > > +      &pinctrl_apalis_gpio3 &pinctrl_apalis_gpio4 > > +      &pinctrl_apalis_gpio5 &pinctrl_apalis_gpio6 > > +      &pinctrl_apalis_gpio7 &pinctrl_apalis_gpio8>; > > + > > + leds_ixora { > > + pinctrl_leds_ixora: leds-ixora { > > + fsl,pins = < > > + MX6QDL_PAD_SD1_DAT1__GPIO1_IO17 > > PAD_CTRL_HYS_PU > > + MX6QDL_PAD_SD1_DAT3__GPIO1_IO21 > > PAD_CTRL_HYS_PU > > + MX6QDL_PAD_NANDF_D1__GPIO2_IO01 > > PAD_CTRL_HYS_PU > > + MX6QDL_PAD_NANDF_D2__GPIO2_IO02 > > PAD_CTRL_HYS_PU > > + >; > > + }; > > + }; > > +}; > > + > > +&pcie { > > + /* active-low meaning opposite of regular PERST# active- > > low polarity */ > > + reset-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>; > > + status = "okay"; > > +}; > > + > > +&pwm1 { > > + status = "okay"; > > +}; > > + > > +&pwm2 { > > + status = "okay"; > > +}; > > + > > +&pwm3 { > > + status = "okay"; > > +}; > > + > > +&pwm4 { > > + status = "okay"; > > +}; > > + > > +&sata { > > + status = "okay"; > > +}; > > + > > +&sound_spdif { > > + status = "okay"; > > +}; > > + > > +&spdif { > > + status = "okay"; > > +}; > > + > > +&uart1 { > > + status = "okay"; > > +}; > > + > > +&uart2 { > > + status = "okay"; > > +}; > > + > > +&uart4 { > > + status = "okay"; > > +}; > > + > > +&uart5 { > > + status = "okay"; > > +}; > > + > > +&usbh1 { > > + status = "okay"; > > +}; > > + > > +&usbotg { > > + status = "okay"; > > +}; > > + > > +/* SD1 */ > > +&usdhc2 { > > + status = "okay"; > > +}; Cheers Marcel