From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 5/7] Database locking: Tcl: for
 errorCode, use pg_exec, not pg_execute
Date: Fri, 8 Jan 2016 09:32:57 +0000
Message-ID: <1452245577.21055.282.camel@citrix.com>
References: <1452195496-16016-1-git-send-email-ian.jackson@eu.citrix.com>
	<1452195496-16016-6-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=80839a509=Ian.Campbell@citrix.com>)
	id 1aHTPt-0004NL-Jt
	for xen-devel@lists.xenproject.org; Fri, 08 Jan 2016 09:33:05 +0000
In-Reply-To: <1452195496-16016-6-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

T24gVGh1LCAyMDE2LTAxLTA3IGF0IDE5OjM4ICswMDAwLCBJYW4gSmFja3NvbiB3cm90ZToKPiBX
ZSB3b3VsZCBsaWtlIHRvIGJlIGFibGUgdG8gcmV0cnkgZGIgdHJhbnNhY3Rpb25zLsKgwqBUbyBk
byB0aGlzIHdlIG5lZWQKPiB0byBrbm93IHdoeSB0aGV5IGZhaWxlZCAoaWYgdGhleSBkaWQpLgo+
IAo+IEJ1dCBwZ19leGVjdXRlIGRvZXMgbm90IHNldCBlcnJvckNvZGUuwqDCoChUaGlzIGlzIGNs
ZWFybHkgYSBidWcuKcKgwqBBbmQKPiBzaW5jZSBpdCBpbW1lZGlhdGVseSBkaXNjYXJkcyBhIGZh
aWxlZCBzdGF0ZW1lbnQsIGFueSBlcnJvcgo+IGluZm9ybWF0aW9uIGhhcyBiZWVuIGxvc3QgYnkg
dGhlIHRpbWUgcGdfZXhlY3V0ZSByZXR1cm5zLgo+IAo+IFNvLCBpbnN0ZWFkLCB1c2UgcGdfZXhl
YywgYW5kIG1hbnVhbGx5IG1lc3MgYWJvdXQgd2l0aCBmaXNoaW5nCj4gc3VpdGFibGUgaW5mb3Jt
YXRpb24gb3V0IG9mIGEgZmFpbGVkIHN0YXRlbWVudCBoYW5kbGUsIGFuZCBnZW5lcmF0aW5nCj4g
YW4gYXBwcm9wcmlhdGUgZXJyb3JDb2RlLgo+IAo+IFRoZXJlIGFyZSBubyBjdXJyZW50IGNvbnN1
bWVycyBvZiB0aGlzIGVycm9yQ29kZTogdGhhdCB3aWxsIGNvbWUgaW4gYQo+IG1vbWVudC4KPiAK
PiBBIHdyaW5rbGUgaXMgdGhhdCBhcyBhIHJlc3VsdCBpdCBpcyBubyBsb25nZXIgcG9zc2libGUg
dG8gdXNlCj4gZGItZXhlY3V0ZSBvbiBhIFNFTEVDVCBzdGF0ZW1lbnQgbm9yIGRiLWV4ZWN1dGUt
YXJyYXkgb24gYSBub24tU0VMRUNUCj4gc3RhdGVtZW50LsKgwqBUaGlzIGlzIGJlY2F1c2UgdGhl
IDEuIHRoZSBgb2snIHN0YXR1cyB0aGF0IHdlIGhhdmUgdG8KClN0cmF5ICJ0aGUiIGJlZm9yZSAi
MS4iLgoKPiBjaGVjayBmb3IgaXMgZGlmZmVyZW50IGZvciBzdGF0ZW1lbnRzIHdoaWNoIGFyZSBj
b21tYW5kcyBhbmQgb25lcwo+IHdoaWNoIHJldHVybiB0dXBlcyBhbmQgMi4gd2UgbmVlZCB0byBm
aXNoIGEgZGlmZmVyZW50IHJldHVybiB2YWx1ZSBvdXQKCiJ0dXBsZXMiCgo+IG9mIHRoZSBzdGF0
ZW1lbnQgaGFuZGxlICgtY21kVHVwbGVzIHZzIC1udW1UdXBsZXMpLsKgwqBCdXQgYWxsIHVzZXMg
aW4KPiB0aGUgY29kZWJhc2UgYXJlIG5vdyBmaW5lIGZvciB0aGlzIGRpc3RpbmN0aW9uLgoKRG9l
cyB0aGlzIGltcGx5IHRoYXQgZGItZXhlY3V0ZS1hcnJheSBjb3VsZCBiZSByZW5hbWVkIGRiLWV4
ZWN1dGUtc2VsZWN0LApvciBldmVuIGp1c3QgZGItc2VsZWN0PwoKPiAKPiBTaWduZWQtb2ZmLWJ5
OiBJYW4gSmFja3NvbiA8SWFuLkphY2tzb25AZXUuY2l0cml4LmNvbT4KPiAtLS0KPiDCoHRjbC9K
b2JEQi1FeGVjdXRpdmUudGNsIHzCoMKgwqA1NAo+ICsrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrLS0tCj4gwqAxIGZpbGUgY2hhbmdlZCwgNTEgaW5zZXJ0aW9ucygr
KSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvdGNsL0pvYkRCLUV4ZWN1dGl2ZS50
Y2wgYi90Y2wvSm9iREItRXhlY3V0aXZlLnRjbAo+IGluZGV4IGJiY2U2ZmMuLmVkOWFiYmIgMTAw
NjQ0Cj4gLS0tIGEvdGNsL0pvYkRCLUV4ZWN1dGl2ZS50Y2wKPiArKysgYi90Y2wvSm9iREItRXhl
Y3V0aXZlLnRjbAo+IEBAIC0xMjEsMTMgKzEyMSw2MSBAQCBwcm9jIGRiLWV4ZWN1dGUtZGVidWcg
e3N0bXR9IHsKPiDCoAlwdXRzIHN0ZGVyciAiRVhFQ1VUSU5HID4kc3RtdDwiCj4gwqDCoMKgwqDC
oH0KPiDCoH0KPiArCj4gK3Byb2MgZGItLWV4ZWMtY2hlY2sge3NodmFyIHN0bXQgZXhwZWN0ZWRf
c3RhdHVzIGJvZHl9IHsKPiArwqDCoMKgwqAjIHBnX2V4ZWN1dGUgZG9lcyBub3Qgc2V0IGVycm9y
Q29kZSBhbmQgaXQgdGhyb3dzIGF3YXkgdGhlCj4gK8KgwqDCoMKgIyBzdGF0ZW1lbnQgaGFuZGxl
IHNvIHdlIGNhbid0IGdldCB0aGUgZXJyb3Igb3V0LsKgwqBTbwo+ICvCoMKgwqDCoCMgdXNlIHBn
X2V4ZWMsIGFzIHdyYXBwZWQgdXAgaGVyZS4KPiArCj4gK8KgwqDCoMKgIyBkYi0tZXhlYy1jaGVj
ayBleGVjdXRlcyBzdG10IGFuZCBjaGVja3MgdGhhdCB0aGUgc3RhdHVzIGlzCj4gK8KgwqDCoMKg
IyBgZXhwZWN0ZWRfc3RhdHVzJy7CoMKgSWYgT0ssIGV4ZWN1dGVzIGJvZHkgd2l0aCAkc2h2YXIg
c2V0IHRvIHRoZQo+ICvCoMKgwqDCoCMgc3RtdCBoYW5kbGUuwqDCoMKgT3RoZXJ3aXNlIHRocm93
cyB3aXRoIGVycm9yQ29kZQo+ICvCoMKgwqDCoCPCoMKgwqB7T1NTVEVTVC1QU1FMIDxwZy1zdGF0
dXM+IDxwZy1zcWxzdGF0ZT59Cj4gKwo+ICvCoMKgwqDCoGdsb2JhbCBlcnJvckluZm8gZXJyb3JD
b2RlCj4gK8KgwqDCoMKgdXB2YXIgMSAkc2h2YXIgc2gKPiArCj4gK8KgwqDCoMKgc2V0IHNoIFtw
Z19leGVjIGRiaCAkc3RtdF0KPiArCj4gK8KgwqDCoMKgc2V0IHJjIFtjYXRjaCB7Cj4gKwlzZXQg
c3RhdHVzIFtwZ19yZXN1bHQgJHNoIC1zdGF0dXNdCj4gKwlpZiB7W3N0cmluZyBjb21wYXJlICRz
dGF0dXMgJGV4cGVjdGVkX3N0YXR1c119IHsKPiArCcKgwqDCoMKgc2V0IGVtc2cgW3BnX3Jlc3Vs
dCAkc2ggLWVycm9yXQo+ICsJwqDCoMKgwqBzZXQgc3Fsc3RhdGUgW3BnX3Jlc3VsdCAkc2ggLWVy
cm9yIHNxbHN0YXRlXQo+ICsJwqDCoMKgwqBpZiB7IVtzdHJpbmcgbGVuZ3RoICRlbXNnXX0gewo+
ICsJCXNldCBlbXNnICJvc3N0ZXN0IGV4cGVjdGVkIHN0YXR1cyAkZXhwZWN0ZWRfc3RhdHVzIGdv
dAo+ICRzdGF0dXMiCj4gKwnCoMKgwqDCoH0KPiArCcKgwqDCoMKgc2V0IGNvbnRleHQgW3BnX3Jl
c3VsdCAkc2ggLWVycm9yIGNvbnRleHRdCj4gKwnCoMKgwqDCoGVycm9yICRlbXNnIFwKPiArCQki
wqDCoMKgwqB3aGlsZSBleGVjdXRpbmcgU1FMXG4kc3RtdFxuwqDCoMKgwqBpbiBTUUwKPiBjb250
ZXh0XG4kY29udGV4dCIgXAo+ICsJCVtsaXN0IE9TU1RFU1QtUFNRTCAkc3RhdHVzICRzcWxzdGF0
ZV0KPiArCX0KPiArCXVwbGV2ZWwgMSAkYm9keQo+ICvCoMKgwqDCoH0gZW1zZ10KPiArCj4gK8Kg
wqDCoMKgc2V0IGVpICRlcnJvckluZm8KPiArwqDCoMKgwqBzZXQgZWMgJGVycm9yQ29kZQo+ICvC
oMKgwqDCoGNhdGNoIHsgcGdfcmVzdWx0ICRzaCAtY2xlYXIgfQo+ICsKPiArwqDCoMKgwqByZXR1
cm4gLWNvZGUgJHJjIC1lcnJvcmluZm8gJGVpIC1lcnJvcmNvZGUgJGVjICRlbXNnCj4gK30KPiAr
Cj4gwqBwcm9jIGRiLWV4ZWN1dGUge3N0bXR9IHsKPiDCoMKgwqDCoMKgZGItZXhlY3V0ZS1kZWJ1
ZyAkc3RtdAo+IC3CoMKgwqDCoHVwbGV2ZWwgMSBbbGlzdCBwZ19leGVjdXRlIGRiaCAkc3RtdF0K
PiArwqDCoMKgwqBkYi0tZXhlYy1jaGVjayBzaCAkc3RtdCBQR1JFU19DT01NQU5EX09LIHsKPiAr
CXJldHVybiBbcGdfcmVzdWx0ICRzaCAtY21kVHVwbGVzXQo+ICvCoMKgwqDCoH0KPiDCoH0KPiAt
cHJvYyBkYi1leGVjdXRlLWFycmF5IHthcnJheXZhciBzdG10IGFyZ3N9IHsKPiArcHJvYyBkYi1l
eGVjdXRlLWFycmF5IHthcnJheXZhciBzdG10IHtib2R5IHt9fX0gewo+IMKgwqDCoMKgwqBkYi1l
eGVjdXRlLWRlYnVnICRzdG10Cj4gLcKgwqDCoMKgdXBsZXZlbCAxIFtsaXN0IHBnX2V4ZWN1dGUg
LWFycmF5ICRhcnJheXZhciBkYmggJHN0bXRdICRhcmdzCj4gK8KgwqDCoMKgZGItLWV4ZWMtY2hl
Y2sgc2ggJHN0bXQgUEdSRVNfVFVQTEVTX09LIHsKPiArCXNldCBucm93cyBbcGdfcmVzdWx0ICRz
aCAtbnVtVHVwbGVzXQo+ICsJZm9yIHtzZXQgcm93IDB9IHskcm93IDwgJG5yb3dzfSB7aW5jciBy
b3d9IHsKPiArCcKgwqDCoMKgdXBsZXZlbCAxIFtsaXN0IHBnX3Jlc3VsdCAkc2ggLXR1cGxlQXJy
YXkgJHJvdyAkYXJyYXl2YXJdCj4gKwnCoMKgwqDCoHVwbGV2ZWwgMSAkYm9keQo+ICsJfQo+ICsJ
cmV0dXJuICRucm93cwo+ICvCoMKgwqDCoH0KPiDCoH0KPiDCoAo+IMKgcHJvYyBsb2NrLXRhYmxl
cyB7dGFibGVzfSB7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6
Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=