From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 0/7] Better database handling in Tcl Date: Fri, 8 Jan 2016 09:40:54 +0000 Message-ID: <1452246054.21055.285.camel@citrix.com> References: <1452195496-16016-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aHTXY-0004oO-7n for xen-devel@lists.xenproject.org; Fri, 08 Jan 2016 09:41:00 +0000 In-Reply-To: <1452195496-16016-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2016-01-07 at 19:38 +0000, Ian Jackson wrote: > This series arranges for the owner daemon to be able to tolerate > database restarts, and is generally much more careful about database > errors in Tcl. I had a trivial comment on #3's commit message, assuming that rather than the code is wrong, Ack. I spotted a few typos in #5's commit message too. I asked about renaming db-execute-array db-{execute-,}select, but either way Ack. I'm not going to claim I really understood all the Tcl (especially towards the end of the series), but you've tested it, which is good enough I think. IOW, all Acked-by: Ian Campbell (with small caveats on #3 and #5) Ian.