From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcel.ziswiler@toradex.com (Marcel Ziswiler) Date: Fri, 8 Jan 2016 10:59:32 +0000 Subject: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM In-Reply-To: <20160108085734.GC27359@ibawizard.net> References: <1452011942-11940-1-git-send-email-marcel.ziswiler@toradex.com> <1452011942-11940-2-git-send-email-marcel.ziswiler@toradex.com> <20160108085734.GC27359@ibawizard.net> Message-ID: <1452250771.3357.26.camel@toradex.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2016-01-08 at 09:57 +0100, Petr ?tetiar wrote: > > + i2cddc: i2c at 0 { > > + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */ > > + ?&gpio2 30 GPIO_ACTIVE_HIGH /* scl */ > > + >; > > According to one of the comments, it should be changed to the > following: > > sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>; > scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>; No, I believe you mixed the i2c-imx binding with the i2c-gpio one [2]. > -- ynezz [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-imx.txt [2] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-gpio.txt Cheers Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Date: Fri, 8 Jan 2016 10:59:32 +0000 Message-ID: <1452250771.3357.26.camel@toradex.com> References: <1452011942-11940-1-git-send-email-marcel.ziswiler@toradex.com> <1452011942-11940-2-git-send-email-marcel.ziswiler@toradex.com> <20160108085734.GC27359@ibawizard.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160108085734.GC27359@ibawizard.net> Content-Language: en-US Content-ID: <938F68AE1B49B344BA28793368A843DA@eurprd05.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "ynezz@true.cz" Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "stillcompiling@gmail.com" , "linux@arm.linux.org.uk" , "pawel.moll@arm.com" , "ijc+devicetree@hellion.org.uk" , "shawnguo@kernel.org" , "linux-kernel@vger.kernel.org" , "stefan@agner.ch" , "robh+dt@kernel.org" , "kernel@pengutronix.de" , "galak@codeaurora.org" , "shawn.guo@linaro.org" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" List-Id: devicetree@vger.kernel.org T24gRnJpLCAyMDE2LTAxLTA4IGF0IDA5OjU3ICswMTAwLCBQZXRyIMWgdGV0aWFyIHdyb3RlOg0K PiA+ICsJaTJjZGRjOiBpMmNAMCB7DQo+ID4gKwkJZ3Bpb3MgPSA8JmdwaW8zIDE2IEdQSU9fQUNU SVZFX0hJR0ggLyogc2RhICovDQo+ID4gKwkJCcKgJmdwaW8yIDMwIEdQSU9fQUNUSVZFX0hJR0gg Lyogc2NsICovDQo+ID4gKwkJCT47DQo+IA0KPiBBY2NvcmRpbmcgdG8gb25lIG9mIHRoZSBjb21t ZW50cywgaXQgc2hvdWxkIGJlIGNoYW5nZWQgdG8gdGhlDQo+IGZvbGxvd2luZzoNCj4gDQo+IAkJ c2RhLWdwaW9zID0gPCZncGlvMyAxNiBHUElPX0FDVElWRV9ISUdIPjsNCj4gCQlzY2wtZ3Bpb3Mg PSA8JmdwaW8yIDMwIEdQSU9fQUNUSVZFX0hJR0g+Ow0KDQpObywgSSBiZWxpZXZlIHlvdSBtaXhl ZCB0aGUgaTJjLWlteCBiaW5kaW5nIHdpdGggdGhlIGkyYy1ncGlvIG9uZSBbMl0uDQoNCj4gLS0g eW5lenoNCg0KDQpbMV0gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9jZ2l0L2xpbnV4L2tlcm5lbC9n aXQvdG9ydmFsZHMvbGludXguZ2l0L3RyZWUvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2kyYy9pMmMtaW14LnR4dA0KWzJdIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51 eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9pMmMvaTJjLWdwaW8udHh0DQoNCkNoZWVycw0KDQpNYXJjZWwNCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932262AbcAHLOl (ORCPT ); Fri, 8 Jan 2016 06:14:41 -0500 Received: from mail-db3on0138.outbound.protection.outlook.com ([157.55.234.138]:42176 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932213AbcAHLOi (ORCPT ); Fri, 8 Jan 2016 06:14:38 -0500 From: Marcel Ziswiler To: "ynezz@true.cz" CC: "linux-kernel@vger.kernel.org" , "shawn.guo@linaro.org" , "robh+dt@kernel.org" , "stefan@agner.ch" , "pawel.moll@arm.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "stillcompiling@gmail.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" , "kernel@pengutronix.de" , "linux@arm.linux.org.uk" Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Thread-Topic: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Thread-Index: AQHRSgOnZoBPtfzz2EGWVDOBhKwBNg== Date: Fri, 8 Jan 2016 10:59:32 +0000 Message-ID: <1452250771.3357.26.camel@toradex.com> References: <1452011942-11940-1-git-send-email-marcel.ziswiler@toradex.com> <1452011942-11940-2-git-send-email-marcel.ziswiler@toradex.com> <20160108085734.GC27359@ibawizard.net> In-Reply-To: <20160108085734.GC27359@ibawizard.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [84.227.37.153] x-microsoft-exchange-diagnostics: 1;VI1PR05MB0976;5:HGOwtVF1l07DDZlljy30xqK0LhXnYyILB7QQfKRF+b/vO0Tqsqp3LQN3ODdRP5cRyaeJxmW6SGClzr5GHDz6sXBjZSBO7rf0ntuKPQvNjBDnVg9UssudqIN68Ll2Tf1CFSgIu5llJZdmdyCBfuudLg==;24:a5ivlLuvapQYAa72K4b58xS9bXpNpJPJR3GSoVYQO9CrXulhu8d7gW8yBkNrwugL6p65mlZv99DLWzr1biCNvGqTcSrW1yiTmLhuqz6VI/M= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0976; x-ms-office365-filtering-correlation-id: 40af1d5b-5544-4d87-61a2-08d3181aca27 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:VI1PR05MB0976;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0976; x-forefront-prvs: 0815F8251E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(377424004)(24454002)(189002)(106356001)(106116001)(105586002)(102836003)(3846002)(19580405001)(19580395003)(6116002)(1096002)(1220700001)(1730700002)(586003)(87936001)(5008740100001)(189998001)(103116003)(110136002)(5001960100002)(11100500001)(81156007)(101416001)(5004730100002)(97736004)(2351001)(86362001)(40100003)(33646002)(54356999)(76176999)(50986999)(2501003)(4326007)(2900100001)(2906002)(2950100001)(36756003)(5250100002)(15975445007)(92566002)(66066001)(5002640100001)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR05MB0976;H:VI1PR05MB0974.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <938F68AE1B49B344BA28793368A843DA@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2016 10:59:32.7760 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB0976 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u08BEkDn017007 On Fri, 2016-01-08 at 09:57 +0100, Petr Štetiar wrote: > > + i2cddc: i2c@0 { > > + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */ > > +  &gpio2 30 GPIO_ACTIVE_HIGH /* scl */ > > + >; > > According to one of the comments, it should be changed to the > following: > > sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>; > scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>; No, I believe you mixed the i2c-imx binding with the i2c-gpio one [2]. > -- ynezz [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-imx.txt [2] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-gpio.txt Cheers Marcel