Re: [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2016-01-08 at 09:19 -0500, Boris Ostrovsky wrote:
> index 2460818..cac4698 100644
> > > --- a/tools/libxc/include/xc_dom.h
> > > +++ b/tools/libxc/include/xc_dom.h
> > > @@ -71,6 +71,7 @@ struct xc_dom_image {
> > >   
> > >       /* arguments and parameters */
> > >       char *cmdline;
> > > +    size_t cmdline_size;
> > >       uint32_t f_requested[XENFEAT_NR_SUBMAPS];
> > >   
> > >       /* info from (elf) kernel image */
> > > @@ -91,6 +92,7 @@ struct xc_dom_image {
> > >       struct xc_dom_seg p2m_seg;
> > >       struct xc_dom_seg pgtables_seg;
> > >       struct xc_dom_seg devicetree_seg;
> > > +    struct xc_dom_seg start_info_seg; /* HVMlite only */
> > Instead of adding HVM specific members here, you could make use of
> > dom.arch_private and use just a local structure defined in
> > xc_dom_x86.c.
> 
> I did consider this but since we already keep type-specific segments in 
> this structure (e.g. p2m_seg) decided to add an explicit segment for 
> HVMlite.
> 
> Besides, I think to properly use it we'd need to add an arch hook and 
> IMHO it's not worth the trouble in this case.

Agreed, it is at best a potential future cleanup.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel