From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933075AbcAHTqH (ORCPT ); Fri, 8 Jan 2016 14:46:07 -0500 Received: from smtprelay0106.hostedemail.com ([216.40.44.106]:39083 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933025AbcAHTqE (ORCPT ); Fri, 8 Jan 2016 14:46:04 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:305:355:379:541:599:960:973:979:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2197:2198:2199:2200:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4383:4399:5007:6117:6261:7903:8526:8531:10004:10400:10450:10455:10848:11026:11232:11658:11783:11914:12043:12346:12517:12519:12555:12740:13894:14659:19904:19999:21080:21221:21324:30022:30030:30054:30056:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: story81_34bbc0c6a3b5a X-Filterd-Recvd-Size: 3143 Message-ID: <1452282361.4028.80.camel@perches.com> Subject: Re: [patch] get_maintainer: handle file names beginning with ./ From: Joe Perches To: Dan Carpenter Cc: linux-kernel@vger.kernel.org, Andrew Morton Date: Fri, 08 Jan 2016 11:46:01 -0800 In-Reply-To: <20160108184604.GE5177@mwanda> References: <20160108105155.GB32195@mwanda> <1452253076.4028.64.camel@perches.com> <20160108134402.GD5177@mwanda> <1452275227.4028.76.camel@perches.com> <20160108184604.GE5177@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-01-08 at 21:46 +0300, Dan Carpenter wrote: > On Fri, Jan 08, 2016 at 09:47:07AM -0800, Joe Perches wrote: > > > > Then maybe you'd also have to consider fully qualified > > > > file names, tilde expansion, $PWD, and probably a bunch > > > > of other things too. > > > > > > I don't think you'd "have" to consider those as well, but I won't stand > > > in your way if you want to... > > > > Half measures aren't generally good enough. > > > > Those are fake issues though and I can't imagine how they would affect > anyone.  My issue was super annoying for me because I was sending find > output to a script and it was almost mailing the correct people because > it was using git output.  I had to debug for a long time before I > spotted the difference between ./drivers/media/radio/wl128x/fmdrv_common.c > and drivers/media/radio/wl128x/fmdrv_common.c. > > I feel like I have seen this before and just manually added the correct > mailing lists back.  It's crazy annoying and easy to do. > > > Using a combination of CWnd abs_fast_path and $lk_path > > is probably better.  $lkpath is set to './' by default. > > I have no idea what this means...  It sounds like a good idea though. > :)  Please give me Reported-by credit. > Maybe this (probably won't apply because I still haven't converted from Evolution to something that doesn't futz up sending text emails) ---  scripts/get_maintainer.pl | 4 ++++  1 file changed, 4 insertions(+) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index cab641a..1873421 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -16,7 +16,9 @@ my $P = $0;  my $V = '0.26';    use Getopt::Long qw(:config no_auto_abbrev); +use Cwd;   +my $cur_path = fastgetcwd() . '/';  my $lk_path = "./";  my $email = 1;  my $email_usename = 1; @@ -429,6 +431,8 @@ foreach my $file (@ARGV) {   }      }      if ($from_filename) { + $file =~ s/^\Q${cur_path}\E//; #strip any absolute path + $file =~ s/^\Q${lk_path}\E//; #or the path to the lk tree   push(@files, $file);   if ($file ne "MAINTAINERS" && -f $file && ($keywords || $file_emails)) {       open(my $f, '<', $file)