From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers Date: Sun, 10 Jan 2016 07:07:05 -0800 Message-ID: <1452438425.7773.21.camel@perches.com> References: <1452427000-4520-1-git-send-email-mst@redhat.com> <1452427000-4520-2-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1452427000-4520-2-git-send-email-mst@redhat.com> Sender: linux-sh-owner@vger.kernel.org To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Andy Whitcroft , Peter Zijlstra , Arnd Bergmann , linux-arch@vger.kernel.org, Andrew Cooper , virtualization@lists.linux-foundation.org, Stefano Stabellini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , David Miller , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, adi-buildroot-devel@lists.sourceforge.net, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, xen-devel@lists.xenproject.org, Ingo Molnar , Tony Lindgren List-Id: linux-arch.vger.kernel.org On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > SMP-only barriers were missing in checkpatch.pl >=20 > Refactor code slightly to make adding more variants easier. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5116,7 +5116,25 @@ sub process { > =A0 } > =A0 } > =A0# check for memory barriers without a comment. > - if ($line =3D~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|= smp_wmb|smp_read_barrier_depends)\(/) { > + > + my $barriers =3D qr{ > + mb| > + rmb| > + wmb| > + read_barrier_depends > + }x; > + my $smp_barriers =3D qr{ > + store_release| > + load_acquire| > + store_mb| > + ($barriers) > + }x; If I use a variable called $smp_barriers, I'd expect it to actually be the smp_barriers, not to have to prefix it with smp_ before using it. my $smp_barriers =3D qr{ smp_store_release| smp_load_acquire| smp_store_mb| smp_read_barrier_depends }x; or my $smp_barriers =3D qr{ smp_(?:store_release|load_acquire|store_mb|read_barrier_depends) }x; =A0 > + my $all_barriers =3D qr{ > + $barriers| > + smp_($smp_barriers) > + }x; And this shouldn't have a capture group. my $all_barriers =3D qr{ $barriers| $smp_barriers }x; =09 > + > + if ($line =3D~ /\b($all_barriers)\s*\(/) { This doesn't need the capture group either (?:all_barriers) > =A0 if (!ctx_has_comment($first_line, $linenr)) > { > =A0 WARN("MEMORY_BARRIER", > =A0 =A0=A0=A0=A0=A0"memory barrier without > comment\n" . $herecurr); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0095.hostedemail.com ([216.40.44.95]:45545 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756405AbcAJPHM (ORCPT ); Sun, 10 Jan 2016 10:07:12 -0500 Message-ID: <1452438425.7773.21.camel@perches.com> Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers From: Joe Perches Date: Sun, 10 Jan 2016 07:07:05 -0800 In-Reply-To: <1452427000-4520-2-git-send-email-mst@redhat.com> References: <1452427000-4520-1-git-send-email-mst@redhat.com> <1452427000-4520-2-git-send-email-mst@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Andy Whitcroft , Peter Zijlstra , Arnd Bergmann , linux-arch@vger.kernel.org, Andrew Cooper , virtualization@lists.linux-foundation.org, Stefano Stabellini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , David Miller , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, adi-buildroot-devel@lists.sourceforge.net, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, xen-devel@lists.xenproject.org, Ingo Molnar , Tony Lindgren , Andrey Konovalov , Russell King - ARM Linux Message-ID: <20160110150705.MMDQ1mpKOUlLvICNRVDzhkYCTIWJ0H_V5mBhx6m_ZZc@z> On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > SMP-only barriers were missing in checkpatch.pl > > Refactor code slightly to make adding more variants easier. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5116,7 +5116,25 @@ sub process { >   } >   } >  # check for memory barriers without a comment. > - if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { > + > + my $barriers = qr{ > + mb| > + rmb| > + wmb| > + read_barrier_depends > + }x; > + my $smp_barriers = qr{ > + store_release| > + load_acquire| > + store_mb| > + ($barriers) > + }x; If I use a variable called $smp_barriers, I'd expect it to actually be the smp_barriers, not to have to prefix it with smp_ before using it. my $smp_barriers = qr{ smp_store_release| smp_load_acquire| smp_store_mb| smp_read_barrier_depends }x; or my $smp_barriers = qr{ smp_(?:store_release|load_acquire|store_mb|read_barrier_depends) }x;   > + my $all_barriers = qr{ > + $barriers| > + smp_($smp_barriers) > + }x; And this shouldn't have a capture group. my $all_barriers = qr{ $barriers| $smp_barriers }x; > + > + if ($line =~ /\b($all_barriers)\s*\(/) { This doesn't need the capture group either (?:all_barriers) >   if (!ctx_has_comment($first_line, $linenr)) > { >   WARN("MEMORY_BARRIER", >        "memory barrier without > comment\n" . $herecurr); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Sun, 10 Jan 2016 15:07:05 +0000 Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers Message-Id: <1452438425.7773.21.camel@perches.com> List-Id: References: <1452427000-4520-1-git-send-email-mst@redhat.com> <1452427000-4520-2-git-send-email-mst@redhat.com> In-Reply-To: <1452427000-4520-2-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Andy Whitcroft , Peter Zijlstra , Arnd Bergmann , linux-arch@vger.kernel.org, Andrew Cooper , virtualization@lists.linux-foundation.org, Stefano Stabellini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , David Miller , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, adi-buildroot-devel@lists.sourceforge.net, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, xen-devel@lists.xenproject.org, Ingo Molnar , Tony Lindgren On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > SMP-only barriers were missing in checkpatch.pl >=20 > Refactor code slightly to make adding more variants easier. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5116,7 +5116,25 @@ sub process { > =A0 } > =A0 } > =A0# check for memory barriers without a comment. > - if ($line =3D~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_= wmb|smp_read_barrier_depends)\(/) { > + > + my $barriers =3D qr{ > + mb| > + rmb| > + wmb| > + read_barrier_depends > + }x; > + my $smp_barriers =3D qr{ > + store_release| > + load_acquire| > + store_mb| > + ($barriers) > + }x; If I use a variable called $smp_barriers, I'd expect it to actually be the smp_barriers, not to have to prefix it with smp_ before using it. my $smp_barriers =3D qr{ smp_store_release| smp_load_acquire| smp_store_mb| smp_read_barrier_depends }x; or my $smp_barriers =3D qr{ smp_(?:store_release|load_acquire|store_mb|read_barrier_depends) }x; =A0 > + my $all_barriers =3D qr{ > + $barriers| > + smp_($smp_barriers) > + }x; And this shouldn't have a capture group. my $all_barriers =3D qr{ $barriers| $smp_barriers }x; =09 > + > + if ($line =3D~ /\b($all_barriers)\s*\(/) { This doesn't need the capture group either (?:all_barriers) > =A0 if (!ctx_has_comment($first_line, $linenr)) > { > =A0 WARN("MEMORY_BARRIER", > =A0 =A0=A0=A0=A0=A0"memory barrier without > comment\n" . $herecurr); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1452438425.7773.21.camel@perches.com> Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers From: Joe Perches Date: Sun, 10 Jan 2016 07:07:05 -0800 In-Reply-To: <1452427000-4520-2-git-send-email-mst@redhat.com> References: <1452427000-4520-1-git-send-email-mst@redhat.com> <1452427000-4520-2-git-send-email-mst@redhat.com> Content-Type: text/plain; charset="iso-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Andy Whitcroft , Peter Zijlstra , Arnd Bergmann , linux-arch@vger.kernel.org, Andrew Cooper , virtualization@lists.linux-foundation.org, Stefano Stabellini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , David Miller , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, adi-buildroot-devel@lists.sourceforge.net, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, xen-devel@lists.xenproject.org, Ingo Molnar , Tony Lindgren , Andrey Konovalov , Russell King - ARM Linux List-ID: On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > SMP-only barriers were missing in checkpatch.pl >=20 > Refactor code slightly to make adding more variants easier. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5116,7 +5116,25 @@ sub process { > =EF=BF=BD } > =EF=BF=BD } > =EF=BF=BD# check for memory barriers without a comment. > - if ($line =3D~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_= wmb|smp_read_barrier_depends)\(/) { > + > + my $barriers =3D qr{ > + mb| > + rmb| > + wmb| > + read_barrier_depends > + }x; > + my $smp_barriers =3D qr{ > + store_release| > + load_acquire| > + store_mb| > + ($barriers) > + }x; If I use a variable called $smp_barriers, I'd expect it to actually be the smp_barriers, not to have to prefix it with smp_ before using it. my $smp_barriers =3D qr{ smp_store_release| smp_load_acquire| smp_store_mb| smp_read_barrier_depends }x; or my $smp_barriers =3D qr{ smp_(?:store_release|load_acquire|store_mb|read_barrier_depends) }x; =EF=BF=BD > + my $all_barriers =3D qr{ > + $barriers| > + smp_($smp_barriers) > + }x; And this shouldn't have a capture group. my $all_barriers =3D qr{ $barriers| $smp_barriers }x; =09 > + > + if ($line =3D~ /\b($all_barriers)\s*\(/) { This doesn't need the capture group either (?:all_barriers) > =EF=BF=BD if (!ctx_has_comment($first_line, $linenr)) > { > =EF=BF=BD WARN("MEMORY_BARRIER", > =EF=BF=BD =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD"memory barrier= without > comment\n" . $herecurr); From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Sun, 10 Jan 2016 07:07:05 -0800 Subject: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers In-Reply-To: <1452427000-4520-2-git-send-email-mst@redhat.com> References: <1452427000-4520-1-git-send-email-mst@redhat.com> <1452427000-4520-2-git-send-email-mst@redhat.com> Message-ID: <1452438425.7773.21.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > SMP-only barriers were missing in checkpatch.pl > > Refactor code slightly to make adding more variants easier. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5116,7 +5116,25 @@ sub process { > ? } > ? } > ?# check for memory barriers without a comment. > - if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { > + > + my $barriers = qr{ > + mb| > + rmb| > + wmb| > + read_barrier_depends > + }x; > + my $smp_barriers = qr{ > + store_release| > + load_acquire| > + store_mb| > + ($barriers) > + }x; If I use a variable called $smp_barriers, I'd expect it to actually be the smp_barriers, not to have to prefix it with smp_ before using it. my $smp_barriers = qr{ smp_store_release| smp_load_acquire| smp_store_mb| smp_read_barrier_depends }x; or my $smp_barriers = qr{ smp_(?:store_release|load_acquire|store_mb|read_barrier_depends) }x; ? > + my $all_barriers = qr{ > + $barriers| > + smp_($smp_barriers) > + }x; And this shouldn't have a capture group. my $all_barriers = qr{ $barriers| $smp_barriers }x; > + > + if ($line =~ /\b($all_barriers)\s*\(/) { This doesn't need the capture group either (?:all_barriers) > ? if (!ctx_has_comment($first_line, $linenr)) > { > ? WARN("MEMORY_BARRIER", > ? ?????"memory barrier without > comment\n" . $herecurr);