diff for duplicates of <1452516463.26146.20.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 6fe1119..d16c744 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,49 +5,48 @@ On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote: > indentation > is changed to match the correct format specified in the Linux Kernel > Coding Style. ->=20 -> Signed-off-by: Anton W=C3=BCrfel <anton.wuerfel@fau.de> +> +> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de> > CC: linux-kernel@i4.cs.fau.de > --- -> =C2=A0drivers/tty/serial/8250/8250_pci.c=C2=A0=C2=A0| 12 ++++++------ -> =C2=A0drivers/tty/serial/8250/8250_pnp.c=C2=A0=C2=A0|=C2=A0=C2=A04 ++= --- -> =C2=A0drivers/tty/serial/8250/8250_port.c |=C2=A0=C2=A06 +++--- -> =C2=A03 files changed, 11 insertions(+), 11 deletions(-) ->=20 +> drivers/tty/serial/8250/8250_pci.c | 12 ++++++------ +> drivers/tty/serial/8250/8250_pnp.c | 4 ++-- +> drivers/tty/serial/8250/8250_port.c | 6 +++--- +> 3 files changed, 11 insertions(+), 11 deletions(-) +> > diff --git a/drivers/tty/serial/8250/8250_pci.c > b/drivers/tty/serial/8250/8250_pci.c > index 09157fa..b0b47f9 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -841,12 +841,12 @@ static int pci_netmos_init(struct pci_dev *dev) -> =C2=A0 return 0; -> =C2=A0 -> =C2=A0 switch (dev->device) { /* FALLTHROUGH on all */ +> return 0; +> +> switch (dev->device) { /* FALLTHROUGH on all */ > - case PCI_DEVICE_ID_NETMOS_9904: > - case PCI_DEVICE_ID_NETMOS_9912: > - case PCI_DEVICE_ID_NETMOS_9922: > - case PCI_DEVICE_ID_NETMOS_9900: -> - num_serial =3D pci_netmos_9900_numports(dev); +> - num_serial = pci_netmos_9900_numports(dev); > - break; > + case PCI_DEVICE_ID_NETMOS_9904: > + case PCI_DEVICE_ID_NETMOS_9912: > + case PCI_DEVICE_ID_NETMOS_9922: > + case PCI_DEVICE_ID_NETMOS_9900: -> + num_serial =3D pci_netmos_9900_numports(dev); +> + num_serial = pci_netmos_9900_numports(dev); > + break; -> =C2=A0 -> =C2=A0 default: +> +> default: You forget to shift above line as well. -> =C2=A0 if (num_serial =3D=3D 0) { +> if (num_serial == 0) { But before doing that I would suggest to refactor the warning message below in the code: copy it out of 'default:' to below condition and replace by 'break;' inside the switch-case. ---=20 +-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy diff --git a/a/content_digest b/N1/content_digest index b487787..fcf7d9b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -35,51 +35,50 @@ "> indentation\n" "> is changed to match the correct format specified in the Linux Kernel\n" "> Coding Style.\n" - ">=20\n" - "> Signed-off-by: Anton W=C3=BCrfel <anton.wuerfel@fau.de>\n" + "> \n" + "> Signed-off-by: Anton W\303\274rfel <anton.wuerfel@fau.de>\n" "> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>\n" "> CC: linux-kernel@i4.cs.fau.de\n" "> ---\n" - "> =C2=A0drivers/tty/serial/8250/8250_pci.c=C2=A0=C2=A0| 12 ++++++------\n" - "> =C2=A0drivers/tty/serial/8250/8250_pnp.c=C2=A0=C2=A0|=C2=A0=C2=A04 ++=\n" - "--\n" - "> =C2=A0drivers/tty/serial/8250/8250_port.c |=C2=A0=C2=A06 +++---\n" - "> =C2=A03 files changed, 11 insertions(+), 11 deletions(-)\n" - ">=20\n" + "> \302\240drivers/tty/serial/8250/8250_pci.c\302\240\302\240| 12 ++++++------\n" + "> \302\240drivers/tty/serial/8250/8250_pnp.c\302\240\302\240|\302\240\302\2404 ++--\n" + "> \302\240drivers/tty/serial/8250/8250_port.c |\302\240\302\2406 +++---\n" + "> \302\2403 files changed, 11 insertions(+), 11 deletions(-)\n" + "> \n" "> diff --git a/drivers/tty/serial/8250/8250_pci.c\n" "> b/drivers/tty/serial/8250/8250_pci.c\n" "> index 09157fa..b0b47f9 100644\n" "> --- a/drivers/tty/serial/8250/8250_pci.c\n" "> +++ b/drivers/tty/serial/8250/8250_pci.c\n" "> @@ -841,12 +841,12 @@ static int pci_netmos_init(struct pci_dev *dev)\n" - "> =C2=A0\t\treturn 0;\n" - "> =C2=A0\n" - "> =C2=A0\tswitch (dev->device) { /* FALLTHROUGH on all */\n" + "> \302\240\t\treturn 0;\n" + "> \302\240\n" + "> \302\240\tswitch (dev->device) { /* FALLTHROUGH on all */\n" "> -\t\tcase PCI_DEVICE_ID_NETMOS_9904:\n" "> -\t\tcase PCI_DEVICE_ID_NETMOS_9912:\n" "> -\t\tcase PCI_DEVICE_ID_NETMOS_9922:\n" "> -\t\tcase PCI_DEVICE_ID_NETMOS_9900:\n" - "> -\t\t\tnum_serial =3D pci_netmos_9900_numports(dev);\n" + "> -\t\t\tnum_serial = pci_netmos_9900_numports(dev);\n" "> -\t\t\tbreak;\n" "> +\tcase PCI_DEVICE_ID_NETMOS_9904:\n" "> +\tcase PCI_DEVICE_ID_NETMOS_9912:\n" "> +\tcase PCI_DEVICE_ID_NETMOS_9922:\n" "> +\tcase PCI_DEVICE_ID_NETMOS_9900:\n" - "> +\t\tnum_serial =3D pci_netmos_9900_numports(dev);\n" + "> +\t\tnum_serial = pci_netmos_9900_numports(dev);\n" "> +\t\tbreak;\n" - "> =C2=A0\n" - "> =C2=A0\t\tdefault:\n" + "> \302\240\n" + "> \302\240\t\tdefault:\n" "\n" "You forget to shift above line as well.\n" "\n" - "> =C2=A0\t\t\tif (num_serial =3D=3D 0) {\n" + "> \302\240\t\t\tif (num_serial == 0) {\n" "\n" "But before doing that I would suggest to refactor the warning message\n" "below in the code: copy it out of 'default:' to below condition and\n" "replace by 'break;' inside the switch-case.\n" "\n" - "--=20\n" + "-- \n" "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -a78cd94144346a10c5eadc54cdadb9af615cf34b297d619845cd33e10d136052 +f1fecb12e130972ac021b0223a26ee58bef6ba7d5e2d27fe033aaa8c4b00ec09
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.