From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shevchenko, Andriy" Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Date: Mon, 11 Jan 2016 13:03:27 +0000 Message-ID: <1452517435.26146.24.camel@intel.com> References: <1452275039-18787-1-git-send-email-anton.wuerfel@fau.de> <1452275039-18787-2-git-send-email-anton.wuerfel@fau.de> <1452515294.26146.10.camel@linux.intel.com> <1452516646.26146.22.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Cc: "anton.wuerfel@fau.de" , "linux-kernel@vger.kernel.org" , "mail@maciej.szmigiero.name" , "desmondl@broadcom.com" , "Zha, Qipeng" , "heikki.krogerus@linux.intel.com" , "long.wanglong@huawei.com" , "soeren.grunewald@desy.de" , "deller@gmx.de" , "jslaby@suse.com" , "phillip.raffeck@fau.de" , "paul.burton@imgtec.com" , "hpeter@gmail.com" , "ralf@linux-mips.org" , "linux-kernel@i4.cs.fau.de" , "adam.lee@canonical.com" , "gregkh@linuxfoundation.org" , "jejb@parisc-linux.or To: "mans@mansr.com" Return-path: In-Reply-To: List-ID: List-Id: linux-parisc.vger.kernel.org T24gTW9uLCAyMDE2LTAxLTExIGF0IDEyOjU0ICswMDAwLCBNw6VucyBSdWxsZ8OlcmQgd3JvdGU6 DQo+ICJTaGV2Y2hlbmtvLCBBbmRyaXkiIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+IHdy aXRlczoNCj4gDQo+ID4gT24gTW9uLCAyMDE2LTAxLTExIGF0IDE0OjI4ICswMjAwLCBBbmR5IFNo ZXZjaGVua28gd3JvdGU6DQo+ID4gPiBPbiBGcmksIDIwMTYtMDEtMDggYXQgMTg6NDMgKzAxMDAs IEFudG9uIFd1ZXJmZWwgd3JvdGU6DQo+ID4gPiA+IFRoaXMgcGF0Y2ggZml4ZXMgd2hpdGVzcGFj ZSBlcnJvcnMgcmVwb3J0ZWQgYnkgY2hlY2twYXRjaCB0bw0KPiA+ID4gPiBpbmNyZWFzZQ0KPiA+ ID4gPiByZWFkYWJpbGl0eS4gTWFpbiBmb2N1cyBpcyBvbiBtaXNzaW5nIHNwYWNlcyBhZnRlciBj b21tYXMgaW4NCj4gPiA+ID4gZnVuY3Rpb24gaGVhZGVycyBhbmQgbWFjcm9zIChsaWtlIGZvbyxi YXIgZWRpdGVkIHRvIGZvbywgYmFyKS4NCj4gPiA+ID4gDQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6 IEFudG9uIFfDvHJmZWwgPGFudG9uLnd1ZXJmZWxAZmF1LmRlPg0KPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBQaGlsbGlwIFJhZmZlY2sgPHBoaWxsaXAucmFmZmVja0BmYXUuZGU+DQo+ID4gPiA+IEND OiBsaW51eC1rZXJuZWxAaTQuY3MuZmF1LmRlDQo+ID4gPiANCj4gPiA+IENjOiBsb29rcyBtb3Jl IHN0YW5kYXJkLg0KPiA+ID4gDQo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdHR5L3NlcmlhbC84MjUw LzgyNTBfYWNjZW50LmMNCj4gPiA+ID4gKysrIGIvZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1 MF9hY2NlbnQuYw0KPiA+ID4gPiBAQCAtMTAsNyArMTAsNyBAQA0KPiA+ID4gPiDCoCNpbmNsdWRl IDxsaW51eC9pbml0Lmg+DQo+ID4gPiA+IMKgI2luY2x1ZGUgPGxpbnV4L3NlcmlhbF84MjUwLmg+ DQo+ID4gPiA+IMKgDQo+ID4gPiA+IC0jZGVmaW5lIFBPUlQoX2Jhc2UsX2lycSkJCQkJXA0KPiA+ ID4gPiArI2RlZmluZSBQT1JUKF9iYXNlLCBfaXJxKQkJCQlcDQo+ID4gPiA+IMKgCXsJCQkJCQlc DQo+ID4gPiA+IMKgCQkuaW9iYXNlCQk9IF9iYXNlLAkJDQo+ID4gPiA+IFwNCj4gPiA+ID4gwqAJ CS5pcnEJCT0gX2lycSwJCQkNCj4gPiA+ID4gXA0KPiA+IA0KPiA+IDgyNTBfUE9SVCgpDQo+ID4g DQo+ID4gPiA+IA0KPiA+ID4gDQo+ID4gPiBXaGlsZSB0aG9zZSBhcmUgb2theSwgSSB3b3VsZCBz dWdnZXN0IHRvIG1ha2UgYSBtYWNybyBpbg0KPiA+ID4gZHJpdmVycy/igKYvODI1MC5oIG9uZSBm b3IgYWxsLCBzb21ldGhpbmcgbGlrZSB0aGlzOg0KPiA+ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBf UE9SVF9GTEFHUyhfYmFzZSwgX2lycSwgX2ZsYWdzKQ0KPiA+ID4g4oCmDQo+ID4gPiAJLmZsYWdz wqDCoMKgwqDCoMKgwqDCoMKgwqA9IFVQRl9CT09UX0FVVE9DT05GIHwgKF9mbGFncykgXA0KPiA+ ID4gDQo+ID4gPiAjZGVmaW5lIDgyNTBfUE9SVChfYmFzZSwgX2lycSkJODI1MF9QT1JUX0ZMQUdT KF9iYXNlLA0KPiA+ID4gX2lycSwgMCkNCj4gPiA+IA0KPiA+ID4gQW5kIHVzZSBpdC4NCj4gPiAN Cj4gPiAjZGVmaW5lIDgyNTBfRk9VUlBPUlQoX2Jhc2UsIF9pcnEpCTgyNTBfUE9SVF9GTEFHUyhf YmFzZSwNCj4gPiBfaXJxLA0KPiA+IFVQRl9GT1VSUE9SVCkNCj4gDQo+IE1hY3JvIG5hbWVzIGNh bid0IHN0YXJ0IHdpdGggYSBudW1iZXIuDQoNCk9oLCByaWdodCwgdGhhbmtzLg0KDQpTRVJJQUw4 MjUwX1BPUlQqIHdpbGwgd29yay4NCg0KLS0gDQpBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2 Y2hlbmtvQGludGVsLmNvbT4NCkludGVsIEZpbmxhbmQgT3kNCi0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbnRlbCBG aW5sYW5kIE95ClJlZ2lzdGVyZWQgQWRkcmVzczogUEwgMjgxLCAwMDE4MSBIZWxzaW5raSAKQnVz aW5lc3MgSWRlbnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCkRvbWljaWxlZCBpbiBIZWxzaW5raSAK ClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFs IG1hdGVyaWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4g QW55IHJldmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0 ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBjb250YWN0 IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933003AbcAKNEE (ORCPT ); Mon, 11 Jan 2016 08:04:04 -0500 Received: from mga03.intel.com ([134.134.136.65]:16453 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932982AbcAKNEC (ORCPT ); Mon, 11 Jan 2016 08:04:02 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,552,1444719600"; d="scan'208";a="631619035" From: "Shevchenko, Andriy" To: "mans@mansr.com" CC: "anton.wuerfel@fau.de" , "linux-kernel@vger.kernel.org" , "mail@maciej.szmigiero.name" , "desmondl@broadcom.com" , "Zha, Qipeng" , "heikki.krogerus@linux.intel.com" , "long.wanglong@huawei.com" , "soeren.grunewald@desy.de" , "deller@gmx.de" , "jslaby@suse.com" , "phillip.raffeck@fau.de" , "paul.burton@imgtec.com" , "hpeter@gmail.com" , "ralf@linux-mips.org" , "linux-kernel@i4.cs.fau.de" , "adam.lee@canonical.com" , "gregkh@linuxfoundation.org" , "jejb@parisc-linux.org" , "linux-parisc@vger.kernel.org" , "peter@hurleysoftware.com" , "matt.redfearn@imgtec.com" , "k.kozlowski@samsung.com" Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Thread-Topic: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Thread-Index: AQHRTG8p23xRPjsY5E6tMRrhwlK61Z72SC+A Date: Mon, 11 Jan 2016 13:03:27 +0000 Message-ID: <1452517435.26146.24.camel@intel.com> References: <1452275039-18787-1-git-send-email-anton.wuerfel@fau.de> <1452275039-18787-2-git-send-email-anton.wuerfel@fau.de> <1452515294.26146.10.camel@linux.intel.com> <1452516646.26146.22.camel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.86] Content-Type: text/plain; charset="utf-8" Content-ID: <966EEF0CEF80034EA37EFB5820A95D37@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u0BD49uD031657 On Mon, 2016-01-11 at 12:54 +0000, Måns Rullgård wrote: > "Shevchenko, Andriy" writes: > > > On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote: > > > On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote: > > > > This patch fixes whitespace errors reported by checkpatch to > > > > increase > > > > readability. Main focus is on missing spaces after commas in > > > > function headers and macros (like foo,bar edited to foo, bar). > > > > > > > > Signed-off-by: Anton Würfel > > > > Signed-off-by: Phillip Raffeck > > > > CC: linux-kernel@i4.cs.fau.de > > > > > > Cc: looks more standard. > > > > > > > --- a/drivers/tty/serial/8250/8250_accent.c > > > > +++ b/drivers/tty/serial/8250/8250_accent.c > > > > @@ -10,7 +10,7 @@ > > > >  #include > > > >  #include > > > >   > > > > -#define PORT(_base,_irq) \ > > > > +#define PORT(_base, _irq) \ > > > >   { \ > > > >   .iobase = _base, > > > > \ > > > >   .irq = _irq, > > > > \ > > > > 8250_PORT() > > > > > > > > > > > > While those are okay, I would suggest to make a macro in > > > drivers/…/8250.h one for all, something like this: > > > > > > #define 8250_PORT_FLAGS(_base, _irq, _flags) > > > … > > > .flags          = UPF_BOOT_AUTOCONF | (_flags) \ > > > > > > #define 8250_PORT(_base, _irq) 8250_PORT_FLAGS(_base, > > > _irq, 0) > > > > > > And use it. > > > > #define 8250_FOURPORT(_base, _irq) 8250_PORT_FLAGS(_base, > > _irq, > > UPF_FOURPORT) > > Macro names can't start with a number. Oh, right, thanks. SERIAL8250_PORT* will work. -- Andy Shevchenko Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.