From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] fetch2/local.py: avoid using PREMIRROR
Date: Mon, 11 Jan 2016 13:23:16 +0000 [thread overview]
Message-ID: <1452518596.7598.173.camel@linuxfoundation.org> (raw)
In-Reply-To: <11cf5052016496de57d2253aff35c20c62d90703.1451902509.git.liezhi.yang@windriver.com>
On Mon, 2016-01-04 at 02:15 -0800, Robert Yang wrote:
> The PREMIRROR isn't useful for "file://", so avoid using it, this is
> good for searching speed and can reduce useless lines in
> log.do_fetch.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> bitbake/lib/bb/fetch2/local.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/bitbake/lib/bb/fetch2/local.py
> b/bitbake/lib/bb/fetch2/local.py
> index 2d921f7..7245651 100644
> --- a/bitbake/lib/bb/fetch2/local.py
> +++ b/bitbake/lib/bb/fetch2/local.py
> @@ -126,3 +126,8 @@ class Local(FetchMethod):
> def clean(self, urldata, d):
> return
>
> + def try_premirror(self, urldata, d):
> + """
> + Should premirrors be used?
> + """
> + return False
Hi Robert,
I applied this but I think I'm going to have to revert this since it is
in fact a valid use case.
The sstate.bbclass code sets up SSTATE_MIRRORS as PREMIRRORS. Its quite
common to map those file:// urls to remote http:// urls and with the
above change, this no longer works.
Cheers,
Richard
next prev parent reply other threads:[~2016-01-11 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 10:15 [PATCH 0/1] fetch2/local.py: avoid using PREMIRROR Robert Yang
2016-01-04 10:15 ` [PATCH 1/1] " Robert Yang
2016-01-11 13:23 ` Richard Purdie [this message]
2016-01-12 1:31 ` Robert Yang
2016-01-12 8:19 ` Richard Purdie
2016-01-13 3:02 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452518596.7598.173.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=liezhi.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.