From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 2/2] build: convert NR_CPUS to Kconfig Date: Mon, 11 Jan 2016 16:49:49 +0100 Message-ID: <1452527389.11427.3.camel@citrix.com> References: <1452295045-30903-1-git-send-email-cardoe@cardoe.com> <1452295045-30903-2-git-send-email-cardoe@cardoe.com> <5693C91C02000078000C572F@prv-mh.provo.novell.com> <5693C4F5.8060002@cardoe.com> <5693D8BB02000078000C57FE@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6800936441850438124==" Return-path: In-Reply-To: <5693D8BB02000078000C57FE@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Doug Goldstein Cc: Keir Fraser , Ian Campbell , George Dunlap , Liu Jinsong , xen-devel@lists.xen.org, Stefano Stabellini , Andrew Cooper List-Id: xen-devel@lists.xenproject.org --===============6800936441850438124== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-bWxL1UR8KSz6lCeAKQtT" --=-bWxL1UR8KSz6lCeAKQtT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-01-11 at 08:30 -0700, Jan Beulich wrote: > > > > On 11.01.16 at 16:06, wrote: > > On 1/11/16 8:24 AM, Jan Beulich wrote: > > > Considering the size of the patch, the doubling of the > > > identifier's > > > length, and the fact that even Linux continues to use NR_CPUS > > > I wonder whether we wouldn't be better of simply having > > >=20 > > > #define NR_CPUS CONFIG_NR_CPUS > >=20 > > Is that a "please do this for a v2" or "what do the other > > maintainers > > think?" statement? >=20 > More the former, unless the latter gets answered by "no, this is a > bad idea". >=20 FWIW, I like Jan's idea and, although not too big of a deal, I'd be happy to still have the shorter identifier (NR_CPUS) available in sched_credit2.c Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-bWxL1UR8KSz6lCeAKQtT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlaTzx0ACgkQk4XaBE3IOsS6TACeP6KZR/nitxW6KycoXQ6HhdvR HIsAoJDyTLimvqgDQc8lI77Z1x0Pwh8A =YgVd -----END PGP SIGNATURE----- --=-bWxL1UR8KSz6lCeAKQtT-- --===============6800936441850438124== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6800936441850438124==--