From: Joe Perches <joe@perches.com>
To: Chaehyun Lim <chaehyun.lim@gmail.com>, gregkh@linuxfoundation.org
Cc: johnny.kim@atmel.com, austin.shin@atmel.com,
chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com,
leo.kim@atmel.com, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/5] staging: wilc1000: remove typedef from struct wilc_cfg_byte_t
Date: Mon, 11 Jan 2016 17:00:19 -0800 [thread overview]
Message-ID: <1452560419.7773.87.camel@perches.com> (raw)
In-Reply-To: <1452558775-21532-2-git-send-email-chaehyun.lim@gmail.com>
On Tue, 2016-01-12 at 09:32 +0900, Chaehyun Lim wrote:
> This patch removes typedef from struct wilc_cfg_byte_t and renames it to
> wilc_cfg_byte.
Is this really a good name?
> diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.h b/drivers/staging/wilc1000/wilc_wlan_cfg.h
[]
> @@ -10,10 +10,10 @@
> #ifndef WILC_WLAN_CFG_H
> #define WILC_WLAN_CFG_H
>
> -typedef struct {
> +struct wilc_cfg_byte {
> u16 id;
> u16 val;
> -} wilc_cfg_byte_t;
> +};
val is a u16, calling it cfg_byte seems misleading.
next prev parent reply other threads:[~2016-01-12 1:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 0:32 [PATCH 1/5] staging: wilc1000: fix alignment of open parenthesis Chaehyun Lim
2016-01-12 0:32 ` [PATCH 2/5] staging: wilc1000: remove typedef from struct wilc_cfg_byte_t Chaehyun Lim
2016-01-12 1:00 ` Joe Perches [this message]
2016-01-12 23:18 ` Chaehyun Lim
2016-01-12 0:32 ` [PATCH 3/5] staging: wilc1000: remove typedef from struct wilc_cfg_hword_t Chaehyun Lim
2016-01-12 0:32 ` [PATCH 4/5] staging: wilc1000: remove typedef from struct wilc_cfg_word_t Chaehyun Lim
2016-01-12 0:32 ` [PATCH 5/5] staging: wilc1000: remove typedef from struct wilc_cfg_str_t Chaehyun Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452560419.7773.87.camel@perches.com \
--to=joe@perches.com \
--cc=austin.shin@atmel.com \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.