All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Li Xin <lixin.fnst@cn.fujitsu.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] net-tools_1.60-26.bb: Error fix
Date: Tue, 12 Jan 2016 11:32:25 +0000	[thread overview]
Message-ID: <1452598345.28375.12.camel@linuxfoundation.org> (raw)
In-Reply-To: <1452574934-2053-1-git-send-email-lixin.fnst@cn.fujitsu.com>

On Tue, 2016-01-12 at 08:02 +0300, Li Xin wrote:
> when set PATCHTOOL = "patch" in conf/local.conf,error will occur
> in the step of do_patch.
> The error is: "quilt: command not found",so fix it.
> 
> Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com>
> ---
>  meta/recipes-extended/net-tools/net-tools_1.60-26.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/net-tools/net-tools_1.60-26.bb
> b/meta/recipes-extended/net-tools/net-tools_1.60-26.bb
> index 923d048..e173f54 100644
> --- a/meta/recipes-extended/net-tools/net-tools_1.60-26.bb
> +++ b/meta/recipes-extended/net-tools/net-tools_1.60-26.bb
> @@ -30,6 +30,7 @@ SRC_URI[patch.sha256sum] =
> "aeeeafaff68866a446f01bb639d4e0146a60af34dcd20e31a3e4
>  UPSTREAM_CHECK_URI = "${DEBIAN_MIRROR}/main/n/net-tools/"
>  
>  inherit gettext
> +DEPENDS = "quilt-native"


DEPENDS works against do_configure and you need this in do_patch so
this is incorrect. You need something like:

do_patch[depends] = "quilt-native:do_populate_sysroot"

Cheers,

Richard

>  
>  # The Makefile is lame, no parallel build
>  PARALLEL_MAKE = ""
> @@ -40,7 +41,7 @@ PARALLEL_MAKE = ""
>  # up all previously applied patches in the start
>  nettools_do_patch() {
>  	cd ${S}
> -	quilt pop -a || true
> +	${STAGING_BINDIR_NATIVE}/quilt pop -a || true
>  	if [ -d ${S}/.pc-nettools ]; then
>  		rm -rf ${S}/.pc
>  		mv ${S}/.pc-nettools ${S}/.pc
> -- 
> 1.8.4.2
> 
> 
> 


  parent reply	other threads:[~2016-01-12 11:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12  5:02 [PATCH] net-tools_1.60-26.bb: Error fix Li Xin
2016-01-12  8:49 ` Khem Raj
2016-01-12 11:32 ` Richard Purdie [this message]
2016-01-13  1:05   ` [PATCH v2] " Li Xin
2016-01-13 13:10     ` Burton, Ross
2016-01-15  1:25       ` [PATCH v3] " Li Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452598345.28375.12.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=lixin.fnst@cn.fujitsu.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.