All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bastien Nocera <hadess@hadess.net>, linux-wireless@vger.kernel.org
Subject: Re: How to revert RFKILL_IOC_NOINPUT ioctl?
Date: Tue, 12 Jan 2016 14:05:50 +0100	[thread overview]
Message-ID: <1452603950.3473.6.camel@sipsolutions.net> (raw)
In-Reply-To: <1452600332.17103.10.camel@hadess.net>

On Tue, 2016-01-12 at 13:05 +0100, Bastien Nocera wrote:
> 
> I realised looking at the rfkill kernel configuration, and noticed
> that it wasn't possible to disable CONFIG_RFKILL_INPUT without
> enabling the expert mode. "Why" would be the first question in this
> mail.

I guess the answer would be that at the time, you couldn't really get a
fully functional setup without it, and there wasn't really any default
userspace to deal with it. Perhaps there is now at least a bigger
chance that userspace will deal with it.

That said, I don't really see a need to disable this code since
userspace that wants to handle it should use the ioctl to disable the
in-kernel code (if it's at all present.)

> See https://lists.fedoraproject.org/archives/list/kernel@lists.fedora
> project.org/thread/FWCOCU2ODZHK7AQVOWSFJLBXL744LYNO/
> 
> To make my GNOME code work, I'd need to disable rfkill-input. But if
> I still wanted to allow rfkill-input to work when GNOME isn't
> running, such as when switching to a console, or another less-capable 
> desktop environment. But there doesn't seem to be a counterpart
> for RFKILL_IOC_NOINPUT. Any reason why?

It's automatically released when you close the fd.

johannes

  reply	other threads:[~2016-01-12 13:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 12:05 How to revert RFKILL_IOC_NOINPUT ioctl? Bastien Nocera
2016-01-12 13:05 ` Johannes Berg [this message]
2016-01-12 13:08   ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452603950.3473.6.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=hadess@hadess.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.